)]}'
{"oslo_middleware/sizelimit.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"e4f3b54fe662a35833ea217277b28987538b60b7","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                req.content_length \u003e max_size):"},{"line_number":90,"context_line":"            msg \u003d _(\"Request is too large.\")"},{"line_number":91,"context_line":"            raise webob.exc.HTTPRequestEntityTooLarge(explanation\u003dmsg)"},{"line_number":92,"context_line":"        if req.content_length is None:"},{"line_number":93,"context_line":"            limiter \u003d LimitingReader(req.body_file, max_size)"},{"line_number":94,"context_line":"            req.body_file \u003d limiter"},{"line_number":95,"context_line":"        return self.application"}],"source_content_type":"text/x-python","patch_set":1,"id":"bff0334d_486b1eb6","line":92,"updated":"2017-04-11 09:02:38.000000000","message":"so basically this can never happen IIUC, since in the commit message you\u0027re saying WebOb will set a content length anyway?\n\nif this is the case this condition can be deleted and its code with it","commit_id":"d19143da0f7fb42621512dddcd2d189287fe8008"}],"oslo_middleware/tests/test_sizelimit.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"cad05219b43b71e602b0fc06b2e80683046adaf2","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        self.assertEqual(413, response.status_int)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def test_request_too_large_no_content_length(self):"},{"line_number":105,"context_line":"        self.request.body \u003d b\"0\" * (self.MAX_REQUEST_BODY_SIZE + 1)"},{"line_number":106,"context_line":"        response \u003d self.request.get_response(self.middleware)"},{"line_number":107,"context_line":"        self.assertEqual(413, response.status_int)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ff52f3f_ad2a64e4","line":105,"updated":"2017-04-13 10:31:46.000000000","message":"can you add self.assertIsNone(self.request.headers[\u0027Content-Length\u0027]) ?\n\nbecause if it\u0027s False, then it means this is the same test has above","commit_id":"d19143da0f7fb42621512dddcd2d189287fe8008"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"664c97426bc9146815b94d4c54e8d625819ef0df","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        self.assertEqual(413, response.status_int)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def test_request_too_large_no_content_length(self):"},{"line_number":105,"context_line":"        self.request.body \u003d b\"0\" * (self.MAX_REQUEST_BODY_SIZE + 1)"},{"line_number":106,"context_line":"        response \u003d self.request.get_response(self.middleware)"},{"line_number":107,"context_line":"        self.assertEqual(413, response.status_int)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ff52f3f_60afbe94","line":105,"in_reply_to":"9ff52f3f_ad2a64e4","updated":"2017-04-13 12:56:44.000000000","message":"yes, it\u0027s False on WebOb 1.7, need remove duplicated tests.","commit_id":"d19143da0f7fb42621512dddcd2d189287fe8008"}]}
