)]}'
{".pre-commit-config.yaml":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"d47e063df3edcc40d36b965a8b0422257e54c2cf","unresolved":true,"context_lines":[{"line_number":32,"context_line":"      - id: flake8"},{"line_number":33,"context_line":"        name: flake8"},{"line_number":34,"context_line":"        additional_dependencies:"},{"line_number":35,"context_line":"          - hacking\u003e\u003d3.0.1,\u003c3.1.0"},{"line_number":36,"context_line":"        language: python"},{"line_number":37,"context_line":"        entry: flake8"},{"line_number":38,"context_line":"        files: \u0027^.*\\.py$\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fbeae2c3_61e3e0bd","side":"PARENT","line":35,"range":{"start_line":35,"start_character":12,"end_line":35,"end_character":33},"updated":"2022-02-16 09:57:45.000000000","message":"Hello,\n\nWell, the version of flake8 to use here will be determined by the pulled version of hacking, here \u003e\u003d3.0.1,\u003c3.1.0. So, here, hacking will pull flake8 \u003c3.8.0,\u003e\u003d3.6.0 [1].\n\nThis is not the root cause of your problem. Something in your environment install an higher version of flake8 which break the pep8 tests, but this code is not the culprit concerning this bug.\n\nThe question is more why lot of your `requirements` are not aligned to what is supported by Wallaby.\n\nFor now I can\u0027t reproduce the issue locally. I created another patch to check this bug without this patch in our gates [2], let see what\u0027s happen with this patch.\n\nYou should notice that I\u0027m not against upgrading hacking for the `master` branch, though I don\u0027t want to upgrade it on stable branch. Upgrading requirements is forbidden by our policy if it don\u0027t fix a bug, and it seems to not be the case here. Your bugzilla refer to wallaby, I don\u0027t think we will agree to backport this patch to that old stable branch, especially if this is not the root cause of the problem.\n\n[1] https://opendev.org/openstack/hacking/src/tag/3.0.1/requirements.txt#L1\n[2] https://review.opendev.org/c/openstack/oslo.middleware/+/829508","commit_id":"2f72b30cbabef86be3ca91c45346f3d9ec92a75a"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"8fb27eddd4b4ef7fc68d3eff31ecc22537f5a529","unresolved":true,"context_lines":[{"line_number":32,"context_line":"      - id: flake8"},{"line_number":33,"context_line":"        name: flake8"},{"line_number":34,"context_line":"        additional_dependencies:"},{"line_number":35,"context_line":"          - hacking\u003e\u003d3.0.1,\u003c3.1.0"},{"line_number":36,"context_line":"        language: python"},{"line_number":37,"context_line":"        entry: flake8"},{"line_number":38,"context_line":"        files: \u0027^.*\\.py$\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"4fe0d2b9_7a1360b5","side":"PARENT","line":35,"range":{"start_line":35,"start_character":12,"end_line":35,"end_character":33},"in_reply_to":"0ede1f56_18bd33c3","updated":"2022-02-17 17:38:11.000000000","message":"My main concern with these downstream jobs, is that they are based on rhel8 even for OSP17 (wallaby) (`nodeset: pod-rhel-8`) [1]. OSP17 is on rhel9.\n\nAlso, as a side note, I noticed that bindep has been enabled for the pep8 [2] job all the time, I don\u0027t think we need it all the time, especially for pep8 in our case...\n\n[1] https://code.engineering.redhat.com/gerrit/gitweb?p\u003dopenstack/osp-internal-jobs.git;a\u003dblob;f\u003dzuul.d/osp-tox-jobs.yaml;h\u003dfae71a0640049f9cca5f6723da4513ed69c9dfe7;hb\u003drefs/heads/master#l51\n[2] https://code.engineering.redhat.com/gerrit/gitweb?p\u003dopenstack/osp-internal-jobs.git;a\u003dcommitdiff;h\u003dd6e3dca1b42e4578d417d31e13049c6095135a57","commit_id":"2f72b30cbabef86be3ca91c45346f3d9ec92a75a"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"59a0e25ec1287c90854deb49a896490bcd60db88","unresolved":true,"context_lines":[{"line_number":32,"context_line":"      - id: flake8"},{"line_number":33,"context_line":"        name: flake8"},{"line_number":34,"context_line":"        additional_dependencies:"},{"line_number":35,"context_line":"          - hacking\u003e\u003d3.0.1,\u003c3.1.0"},{"line_number":36,"context_line":"        language: python"},{"line_number":37,"context_line":"        entry: flake8"},{"line_number":38,"context_line":"        files: \u0027^.*\\.py$\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"0ede1f56_18bd33c3","side":"PARENT","line":35,"range":{"start_line":35,"start_character":12,"end_line":35,"end_character":33},"in_reply_to":"808e4d70_0f724dcb","updated":"2022-02-17 14:35:03.000000000","message":"@Stephen: Here are the downstream patch and its zuul logs who triggered this discussion.\n\nhttps://code.engineering.redhat.com/gerrit/c/oslo.middleware/+/304286\nhttps://sf.hosted.upshift.rdu2.redhat.com/zuul/t/osp-internal/build/50e5bdc2767346a886659253bbedf597/log/job-output.txt\n\nIf you read the logs then you can observe a weird behavior.\n\nIndeed, in a first time tox is executed without tests [1] and tox install all the requirements, hacking and flake8 are installed in a compatible version [2], everything goes fine and this tox target exit 0 [3]. The requirements versions are identicals between pre-commit [4] and test-requirements [5].\n\n[1] https://sf.hosted.upshift.rdu2.redhat.com/zuul/t/osp-internal/build/50e5bdc2767346a886659253bbedf597/log/job-output.txt#290\n[2] https://sf.hosted.upshift.rdu2.redhat.com/zuul/t/osp-internal/build/50e5bdc2767346a886659253bbedf597/log/job-output.txt#781\n[3] https://sf.hosted.upshift.rdu2.redhat.com/zuul/t/osp-internal/build/50e5bdc2767346a886659253bbedf597/log/job-output.txt#794\n[4] https://opendev.org/openstack/oslo.middleware/src/branch/stable/wallaby/.pre-commit-config.yaml#L35\n[6] https://opendev.org/openstack/oslo.middleware/src/branch/stable/wallaby/test-requirements.txt#L6\n\nThen after this target another tox target is executed with tests, however, here it will fail to retrieve a compatible versions of flake8 and then this target will exit in error (the pep8 job will exit in error). \n\n[7] https://sf.hosted.upshift.rdu2.redhat.com/zuul/t/osp-internal/build/50e5bdc2767346a886659253bbedf597/log/job-output.txt#882\n[8] https://sf.hosted.upshift.rdu2.redhat.com/zuul/t/osp-internal/build/50e5bdc2767346a886659253bbedf597/log/job-output.txt#1239\n[9] https://sf.hosted.upshift.rdu2.redhat.com/zuul/t/osp-internal/build/50e5bdc2767346a886659253bbedf597/log/job-output.txt#1256\n\nThe same requirements file installed through tox don\u0027t lead to the same situation. Unfortunatelly I can\u0027t reproduce this problem locally, however, this problem appear at each zuul job running.\n\nStephen can take a look to these logs, maybe you\u0027ll see something that I missed.\n\nAn interesting point is that the same problem occur downstream on some of the other oslo projects (oslo.cache by example). As I inspired from nova to create the pre-commit stuff on oslo, I compared with nova downstream, however they didn\u0027t face this issue downstream as they already use hacking \u003e\u003d 3.1 on wallaby, which is compatible with flake8 3.8.x.","commit_id":"2f72b30cbabef86be3ca91c45346f3d9ec92a75a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6b599abac2855ef6a143c26d41ef1f1cd39eba5a","unresolved":true,"context_lines":[{"line_number":32,"context_line":"      - id: flake8"},{"line_number":33,"context_line":"        name: flake8"},{"line_number":34,"context_line":"        additional_dependencies:"},{"line_number":35,"context_line":"          - hacking\u003e\u003d3.0.1,\u003c3.1.0"},{"line_number":36,"context_line":"        language: python"},{"line_number":37,"context_line":"        entry: flake8"},{"line_number":38,"context_line":"        files: \u0027^.*\\.py$\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"808e4d70_0f724dcb","side":"PARENT","line":35,"range":{"start_line":35,"start_character":12,"end_line":35,"end_character":33},"in_reply_to":"e76bd06a_b93368c8","updated":"2022-02-17 10:44:31.000000000","message":"Yeah, I\u0027m seeing the same thing as Herve. There\u0027s something else wrong with your environment. Both pre-commit and tox should be installing in an isolated virtualenv so this is weird. It might help to share what the zuul job you have running locally is actually doing?","commit_id":"2f72b30cbabef86be3ca91c45346f3d9ec92a75a"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"93b86a8e20285dbf47af5cec48b9c8b99b70d493","unresolved":true,"context_lines":[{"line_number":32,"context_line":"      - id: flake8"},{"line_number":33,"context_line":"        name: flake8"},{"line_number":34,"context_line":"        additional_dependencies:"},{"line_number":35,"context_line":"          - hacking\u003e\u003d3.0.1,\u003c3.1.0"},{"line_number":36,"context_line":"        language: python"},{"line_number":37,"context_line":"        entry: flake8"},{"line_number":38,"context_line":"        files: \u0027^.*\\.py$\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e76bd06a_b93368c8","side":"PARENT","line":35,"range":{"start_line":35,"start_character":12,"end_line":35,"end_character":33},"in_reply_to":"fbeae2c3_61e3e0bd","updated":"2022-02-16 14:12:49.000000000","message":"\u003e For now I can\u0027t reproduce the issue locally. I created another patch to check this bug without this patch in our gates [2], let see what\u0027s happen with this patch.\n\nEven our gates, without this patch, installed the hacking and the flake8 packages in the right version:\n\n```\n2022-02-16 09:38:59.080190 | ubuntu-focal | Collecting hacking\u003c3.1.0,\u003e\u003d3.0.1\n\n2022-02-16 09:38:59.084071 | ubuntu-focal |   Downloading https://mirror.mtl01.iweb.opendev.org/pypifiles/packages/d8/1e/87943c48e3bcd6010d2539130f322168e46186429ae4d26128d7cf496d13/hacking-3.0.1-py3-none-any.whl (37 kB)\n---\n2022-02-16 09:39:00.716487 | ubuntu-focal | Collecting flake8\u003c3.8.0,\u003e\u003d3.6.0\n\n2022-02-16 09:39:00.721006 | ubuntu-focal |   Downloading https://mirror.mtl01.iweb.opendev.org/pypifiles/packages/f8/1f/7ea40d1e4146ea55dbab41cda1376db092a75794914169aabd7e8d7a7def/flake8-3.7.9-py2.py3-none-any.whl (69 kB)\n```\n\n[1] https://review.opendev.org/c/openstack/oslo.middleware/+/829508\n[2] https://zuul.opendev.org/t/openstack/build/3520fab2ccdf400181624c9037dac584/log/job-output.txt#924","commit_id":"2f72b30cbabef86be3ca91c45346f3d9ec92a75a"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34319,"name":"Adrian Fusco Arnejo","email":"afuscoar@redhat.com","username":"adrianfuscoar"},"change_message_id":"97d298779f3fbb339b4bf0f9430e5b4038f10ab1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0a719998_d0b5e3f3","updated":"2022-02-15 13:13:08.000000000","message":"Hello!\n\nCan you review this change? Thx.","commit_id":"c60cb8e09e4200bd01e7a8d1deb581c721962738"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"d47e063df3edcc40d36b965a8b0422257e54c2cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"71b53b4f_7308a778","updated":"2022-02-16 09:57:45.000000000","message":"Hello,\n\nThanks for this patch.\n\nI\u0027ve some concerns related to your bugzilla, please see my inline comment.\n\nAlso you should notice that oslo is currently in feature freeze, so if these changes really fix something I think we could merge this patch before yoga\u0027s final, else I\u0027d suggest to wait for Z series before merging these changes and avoid to upgrade the requirements versions in the middle of the libs freeze.","commit_id":"c60cb8e09e4200bd01e7a8d1deb581c721962738"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6b599abac2855ef6a143c26d41ef1f1cd39eba5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c3813b40_6555dba8","updated":"2022-02-17 10:44:31.000000000","message":"I have no issues with bumping the hacking version, but I don\u0027t think it will fix your issue unfortunately. -1 is to highlight that and potentially get the commit message rewritten","commit_id":"c60cb8e09e4200bd01e7a8d1deb581c721962738"}]}