)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3912fe61d88393f1d16929e59c07d61358e458b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"653c5bcf_f07b86f0","updated":"2023-12-19 17:22:54.000000000","message":"Seems reasonable to me","commit_id":"25f91a7b19ad06b0113a5f139141325f155545e1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8fbb16e6aea7eeae5bebec957a3bd65361adb7dc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"67acee01_267136ef","updated":"2024-02-20 09:33:27.000000000","message":"This has been open for a while without 2nd review. I wonder if we can include this in Caracal.","commit_id":"25f91a7b19ad06b0113a5f139141325f155545e1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"70a15785eca3e3b345895f360e78255ad89689a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"db7c2763_f4446429","updated":"2023-12-19 18:31:41.000000000","message":"i guess this makses sense.\n\ni assume stephen added me since im workign on healthcheck for nova but that will not be using this code.\n\ni could add something similar there i guess but we are intentlaly trying to keep the nova healthcheck endpoint simple so this is kind of out of scope.\n\nthat said its pretty easy to do so i may add this functionality there.","commit_id":"25f91a7b19ad06b0113a5f139141325f155545e1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6e01027c9fd8a06201ee340768a6278dcc7a8421","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"88ec7ae4_f5ce7396","in_reply_to":"db7c2763_f4446429","updated":"2023-12-20 02:13:50.000000000","message":"I think his is not required for the healthcheck implementation[1] currently proposed in nova.\n\nThe main problem with the healthcheck middleware implementation is that the healthcheck endpoint is availabe at the same endpoint as the normal API, so users need to set additional protection to hide only the healthcheck endpoint. IIUC your proposal in nova implements a dedicated endpoint (address/port) for healthcheck so the healthcheck endpoint may not be exposed by load balancers.\n\n[1] https://review.opendev.org/c/openstack/nova/+/825015/","commit_id":"25f91a7b19ad06b0113a5f139141325f155545e1"}],"oslo_middleware/healthcheck/opts.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"70a15785eca3e3b345895f360e78255ad89689a7","unresolved":true,"context_lines":[{"line_number":36,"context_line":"                     \u0027outside of these network addresses are ignored.\u0027),"},{"line_number":37,"context_line":"    cfg.BoolOpt(\u0027ignore_proxied_requests\u0027,"},{"line_number":38,"context_line":"                default\u003dFalse,"},{"line_number":39,"context_line":"                help\u003d\u0027Ignore requests with proxy headers.\u0027)"},{"line_number":40,"context_line":"]"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ee95ae31_86376068","line":39,"updated":"2023-12-19 18:31:41.000000000","message":"i was gong to say that this need to be opt in as people may access this internally via a proxy such as a k8s service or a haproxy endpoint provided to only on a management interface.\n\n+1","commit_id":"25f91a7b19ad06b0113a5f139141325f155545e1"}]}