)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"9b51039b759d7bba23fd41ac15110dc00a95e721","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"71303b6b_40442f13","updated":"2024-06-20 16:28:54.000000000","message":"Looks good to me as a Glance core reviewer","commit_id":"87148d08faddbc4c2accd5b2711023b720aa9251"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"734cd16dd94fbb6d99dadc681633e8d8d9b48edf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"19390d8c_907bfc7f","updated":"2024-07-02 21:12:39.000000000","message":"Abhishek asked me to send the next version of this patch.","commit_id":"d9f2db135dfef7f27f44d64cf07b78e53f0c8a29"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"a793b5855332bbba3da78282b9f93157752240b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"30ca500a_6993ff68","updated":"2024-07-02 15:15:22.000000000","message":"Thank you Hervé and Takashi san for suggestion, will upload a new PS soon!","commit_id":"d9f2db135dfef7f27f44d64cf07b78e53f0c8a29"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"009d0e0a64148d5851672916c085396e4aaf8933","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ee0aba01_c437fdde","updated":"2024-07-02 09:55:46.000000000","message":"Thank you for suggestions Hervé, added some inline replies for the same.","commit_id":"d9f2db135dfef7f27f44d64cf07b78e53f0c8a29"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"d90ad0f725776195697213bea123daf4dec86149","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3d7b393c_00c462b3","updated":"2024-07-02 09:48:13.000000000","message":"Thanks Abhishek for this new patch.\n-1 to highlight my inline comments.","commit_id":"d9f2db135dfef7f27f44d64cf07b78e53f0c8a29"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"c1ae4950288901420e53c1e97403ab254971022e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1dbe79ca_6fb0804e","updated":"2024-07-03 13:55:31.000000000","message":"Makes sense :)","commit_id":"97739a52fa9cc5dd9b416263bf876d1c6f6da978"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b38d6ec23f4367425706fd186d7ac6df2e2d70ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"50f10ba2_954c94a9","updated":"2024-07-04 02:51:02.000000000","message":"I\u0027ll address a few follow-up items in a subsequent change.","commit_id":"01cd6081044256aaaafe8cf149e4e91801bf66b7"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"7c6b9b6feaa0645a7db0522f80f54f55a3ab4d54","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b94a5daf_420a0a85","updated":"2024-07-03 16:00:30.000000000","message":"LGTM, thanks guys","commit_id":"01cd6081044256aaaafe8cf149e4e91801bf66b7"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"e707a1906bf4a7b960de634b394a46687d83162a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"bdfaf30a_f7a6da3d","updated":"2024-07-03 14:07:24.000000000","message":"thank you!","commit_id":"01cd6081044256aaaafe8cf149e4e91801bf66b7"}],"oslo_middleware/healthcheck/__init__.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"d90ad0f725776195697213bea123daf4dec86149","unresolved":true,"context_lines":[{"line_number":428,"context_line":"        desired_plugins \u003d [\u0027disable_by_file\u0027, \u0027enable_by_files\u0027]"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"        if set(desired_plugins).issubset(set(backends)):"},{"line_number":431,"context_line":"            LOG.warning(\u0027`enable_by_files` and `disable_by_file`\u0027"},{"line_number":432,"context_line":"                        \u0027 healthcheck middleware should not be \u0027"},{"line_number":433,"context_line":"                        \u0027configured at once.\u0027)"},{"line_number":434,"context_line":"            sys.exit(0)"}],"source_content_type":"text/x-python","patch_set":3,"id":"058f69cc_5cbf92e4","line":431,"range":{"start_line":431,"start_character":12,"end_line":431,"end_character":23},"updated":"2024-07-02 09:48:13.000000000","message":"I would rather suggest to raise an exception. It would avoid importing logging and would avoid exit by using sys.\n\nAlso, if you prefer to use your approach, I\u0027d suggest exit in error rather than with `0` else, process manager could try to restart it indefinitely, thoughts?","commit_id":"d9f2db135dfef7f27f44d64cf07b78e53f0c8a29"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"009d0e0a64148d5851672916c085396e4aaf8933","unresolved":true,"context_lines":[{"line_number":428,"context_line":"        desired_plugins \u003d [\u0027disable_by_file\u0027, \u0027enable_by_files\u0027]"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"        if set(desired_plugins).issubset(set(backends)):"},{"line_number":431,"context_line":"            LOG.warning(\u0027`enable_by_files` and `disable_by_file`\u0027"},{"line_number":432,"context_line":"                        \u0027 healthcheck middleware should not be \u0027"},{"line_number":433,"context_line":"                        \u0027configured at once.\u0027)"},{"line_number":434,"context_line":"            sys.exit(0)"}],"source_content_type":"text/x-python","patch_set":3,"id":"927cf01a_9b0d8085","line":431,"range":{"start_line":431,"start_character":12,"end_line":431,"end_character":23},"in_reply_to":"058f69cc_5cbf92e4","updated":"2024-07-02 09:55:46.000000000","message":"In spec we said that we will log warning that is why used LOG.warning.\n\nSO should I use sys.exit(\"error message\")?","commit_id":"d9f2db135dfef7f27f44d64cf07b78e53f0c8a29"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"734cd16dd94fbb6d99dadc681633e8d8d9b48edf","unresolved":false,"context_lines":[{"line_number":428,"context_line":"        desired_plugins \u003d [\u0027disable_by_file\u0027, \u0027enable_by_files\u0027]"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"        if set(desired_plugins).issubset(set(backends)):"},{"line_number":431,"context_line":"            LOG.warning(\u0027`enable_by_files` and `disable_by_file`\u0027"},{"line_number":432,"context_line":"                        \u0027 healthcheck middleware should not be \u0027"},{"line_number":433,"context_line":"                        \u0027configured at once.\u0027)"},{"line_number":434,"context_line":"            sys.exit(0)"}],"source_content_type":"text/x-python","patch_set":3,"id":"c264ac37_981576d8","line":431,"range":{"start_line":431,"start_character":12,"end_line":431,"end_character":23},"in_reply_to":"7c79fb57_e7e88d0b","updated":"2024-07-02 21:12:39.000000000","message":"Done","commit_id":"d9f2db135dfef7f27f44d64cf07b78e53f0c8a29"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"571642ff9208547232d2c8cd0cde6be45886a4cc","unresolved":true,"context_lines":[{"line_number":428,"context_line":"        desired_plugins \u003d [\u0027disable_by_file\u0027, \u0027enable_by_files\u0027]"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"        if set(desired_plugins).issubset(set(backends)):"},{"line_number":431,"context_line":"            LOG.warning(\u0027`enable_by_files` and `disable_by_file`\u0027"},{"line_number":432,"context_line":"                        \u0027 healthcheck middleware should not be \u0027"},{"line_number":433,"context_line":"                        \u0027configured at once.\u0027)"},{"line_number":434,"context_line":"            sys.exit(0)"}],"source_content_type":"text/x-python","patch_set":3,"id":"a41faa49_ac0c7575","line":431,"range":{"start_line":431,"start_character":12,"end_line":431,"end_character":23},"in_reply_to":"927cf01a_9b0d8085","updated":"2024-07-02 13:52:11.000000000","message":"I agree with Herve and I also prefer just raising an exception rather than sys.exit here, to leave the error handling to outer api service mechanism. Actually we already have such behavior in basic_auth middleware.\n\nhttps://github.com/openstack/oslo.middleware/blob/master/oslo_middleware/basic_auth.py#L37-L40\n\nIf we just raise an exception the we can skip adding the warning message in the middleware logic itself, because we expect the traceback would be caught by api process mechanism such as uwsgi.","commit_id":"d9f2db135dfef7f27f44d64cf07b78e53f0c8a29"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"c5dc119fa1c71fc7caefefc7c55d451f94085506","unresolved":true,"context_lines":[{"line_number":428,"context_line":"        desired_plugins \u003d [\u0027disable_by_file\u0027, \u0027enable_by_files\u0027]"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"        if set(desired_plugins).issubset(set(backends)):"},{"line_number":431,"context_line":"            LOG.warning(\u0027`enable_by_files` and `disable_by_file`\u0027"},{"line_number":432,"context_line":"                        \u0027 healthcheck middleware should not be \u0027"},{"line_number":433,"context_line":"                        \u0027configured at once.\u0027)"},{"line_number":434,"context_line":"            sys.exit(0)"}],"source_content_type":"text/x-python","patch_set":3,"id":"c9c379d9_80ec2530","line":431,"range":{"start_line":431,"start_character":12,"end_line":431,"end_character":23},"in_reply_to":"927cf01a_9b0d8085","updated":"2024-07-02 15:11:09.000000000","message":"yeah raising an exception would do the same thing than a sys exit with an error message. raising an exception would exit the process and log the error at the same time. But indeed it would logged as an error and not as a warning...","commit_id":"d9f2db135dfef7f27f44d64cf07b78e53f0c8a29"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"a793b5855332bbba3da78282b9f93157752240b6","unresolved":true,"context_lines":[{"line_number":428,"context_line":"        desired_plugins \u003d [\u0027disable_by_file\u0027, \u0027enable_by_files\u0027]"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"        if set(desired_plugins).issubset(set(backends)):"},{"line_number":431,"context_line":"            LOG.warning(\u0027`enable_by_files` and `disable_by_file`\u0027"},{"line_number":432,"context_line":"                        \u0027 healthcheck middleware should not be \u0027"},{"line_number":433,"context_line":"                        \u0027configured at once.\u0027)"},{"line_number":434,"context_line":"            sys.exit(0)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7c79fb57_e7e88d0b","line":431,"range":{"start_line":431,"start_character":12,"end_line":431,"end_character":23},"in_reply_to":"c9c379d9_80ec2530","updated":"2024-07-02 15:15:22.000000000","message":"Ack, we will make changes as per suggestion!","commit_id":"d9f2db135dfef7f27f44d64cf07b78e53f0c8a29"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"a3c83ee761bed4d891dd2298e2cbdeca5fb630d2","unresolved":true,"context_lines":[{"line_number":18,"context_line":"import io"},{"line_number":19,"context_line":"import ipaddress"},{"line_number":20,"context_line":"import json"},{"line_number":21,"context_line":"import logging"},{"line_number":22,"context_line":"import platform"},{"line_number":23,"context_line":"import socket"},{"line_number":24,"context_line":"import sys"}],"source_content_type":"text/x-python","patch_set":5,"id":"53d4d3d2_3d7aab52","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":2},"updated":"2024-07-03 02:02:58.000000000","message":"You can remove it now","commit_id":"97739a52fa9cc5dd9b416263bf876d1c6f6da978"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"c1ae4950288901420e53c1e97403ab254971022e","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import io"},{"line_number":19,"context_line":"import ipaddress"},{"line_number":20,"context_line":"import json"},{"line_number":21,"context_line":"import logging"},{"line_number":22,"context_line":"import platform"},{"line_number":23,"context_line":"import socket"},{"line_number":24,"context_line":"import sys"}],"source_content_type":"text/x-python","patch_set":5,"id":"14cade6a_68c68aa4","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":2},"in_reply_to":"53d4d3d2_3d7aab52","updated":"2024-07-03 13:55:31.000000000","message":"Done","commit_id":"97739a52fa9cc5dd9b416263bf876d1c6f6da978"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"a3c83ee761bed4d891dd2298e2cbdeca5fb630d2","unresolved":true,"context_lines":[{"line_number":43,"context_line":"from oslo_middleware.basic_auth import ConfigInvalid"},{"line_number":44,"context_line":"from oslo_middleware.healthcheck import opts"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"def _find_objects(t):"}],"source_content_type":"text/x-python","patch_set":5,"id":"4f3ed4cf_8dbfa924","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":2},"updated":"2024-07-03 02:02:58.000000000","message":"I think you can remove it now","commit_id":"97739a52fa9cc5dd9b416263bf876d1c6f6da978"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"c1ae4950288901420e53c1e97403ab254971022e","unresolved":false,"context_lines":[{"line_number":43,"context_line":"from oslo_middleware.basic_auth import ConfigInvalid"},{"line_number":44,"context_line":"from oslo_middleware.healthcheck import opts"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"def _find_objects(t):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff091a74_08c3cb9e","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":2},"in_reply_to":"4f3ed4cf_8dbfa924","updated":"2024-07-03 13:55:31.000000000","message":"Done","commit_id":"97739a52fa9cc5dd9b416263bf876d1c6f6da978"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b38d6ec23f4367425706fd186d7ac6df2e2d70ab","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    greenlet \u003d None"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"from oslo_middleware import base"},{"line_number":42,"context_line":"from oslo_middleware.basic_auth import ConfigInvalid"},{"line_number":43,"context_line":"from oslo_middleware.healthcheck import opts"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"b2cf5220_1b83bab1","line":42,"range":{"start_line":42,"start_character":39,"end_line":42,"end_character":52},"updated":"2024-07-04 02:51:02.000000000","message":"This probably should be moved to a more common place but that can be done in follow-up.\n\nhttps://review.opendev.org/c/openstack/oslo.middleware/+/923458/1","commit_id":"01cd6081044256aaaafe8cf149e4e91801bf66b7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b38d6ec23f4367425706fd186d7ac6df2e2d70ab","unresolved":true,"context_lines":[{"line_number":422,"context_line":""},{"line_number":423,"context_line":"    def _verify_configured_plugins(self):"},{"line_number":424,"context_line":"        backends \u003d self._conf_get(\u0027backends\u0027)"},{"line_number":425,"context_line":"        desired_plugins \u003d [\u0027disable_by_file\u0027, \u0027enable_by_files\u0027]"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"        if set(desired_plugins).issubset(set(backends)):"},{"line_number":428,"context_line":"            raise ConfigInvalid(\u0027`enable_by_files` and `disable_by_file`\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"c0def643_3447c00f","line":425,"range":{"start_line":425,"start_character":8,"end_line":425,"end_character":23},"updated":"2024-07-04 02:51:02.000000000","message":"Can `exclusive_plugins` be better ?","commit_id":"01cd6081044256aaaafe8cf149e4e91801bf66b7"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"6ae63648301be8efd4208fcdfa32995f4ed46de4","unresolved":true,"context_lines":[{"line_number":422,"context_line":""},{"line_number":423,"context_line":"    def _verify_configured_plugins(self):"},{"line_number":424,"context_line":"        backends \u003d self._conf_get(\u0027backends\u0027)"},{"line_number":425,"context_line":"        desired_plugins \u003d [\u0027disable_by_file\u0027, \u0027enable_by_files\u0027]"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"        if set(desired_plugins).issubset(set(backends)):"},{"line_number":428,"context_line":"            raise ConfigInvalid(\u0027`enable_by_files` and `disable_by_file`\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"bc013275_b3d975dd","line":425,"range":{"start_line":425,"start_character":8,"end_line":425,"end_character":23},"in_reply_to":"c0def643_3447c00f","updated":"2024-07-04 09:38:54.000000000","message":"I agree with Takashi, the semantic of exclusive is more explicit","commit_id":"01cd6081044256aaaafe8cf149e4e91801bf66b7"}],"oslo_middleware/healthcheck/enable_by_files.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"d90ad0f725776195697213bea123daf4dec86149","unresolved":true,"context_lines":[{"line_number":47,"context_line":"                                     group\u003d\u0027healthcheck\u0027)"},{"line_number":48,"context_line":"        self.file_paths \u003d self._conf_get(\u0027enable_by_file_paths\u0027)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def healthcheck(self, server_port):"},{"line_number":51,"context_line":"        for file_path in self.file_paths:"},{"line_number":52,"context_line":"            if not os.path.exists(file_path):"},{"line_number":53,"context_line":"                LOG.warning(\u0027EnableByFiles healthcheck middleware: Path %s \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"99100559_d28460f0","line":50,"range":{"start_line":50,"start_character":24,"end_line":50,"end_character":37},"updated":"2024-07-02 09:48:13.000000000","message":"do not seems to be used...","commit_id":"d9f2db135dfef7f27f44d64cf07b78e53f0c8a29"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"a793b5855332bbba3da78282b9f93157752240b6","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                                     group\u003d\u0027healthcheck\u0027)"},{"line_number":48,"context_line":"        self.file_paths \u003d self._conf_get(\u0027enable_by_file_paths\u0027)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def healthcheck(self, server_port):"},{"line_number":51,"context_line":"        for file_path in self.file_paths:"},{"line_number":52,"context_line":"            if not os.path.exists(file_path):"},{"line_number":53,"context_line":"                LOG.warning(\u0027EnableByFiles healthcheck middleware: Path %s \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"8eefaa20_f41fe7d0","line":50,"range":{"start_line":50,"start_character":24,"end_line":50,"end_character":37},"in_reply_to":"4c06d67c_6252f774","updated":"2024-07-02 15:15:22.000000000","message":"Acknowledged","commit_id":"d9f2db135dfef7f27f44d64cf07b78e53f0c8a29"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"009d0e0a64148d5851672916c085396e4aaf8933","unresolved":true,"context_lines":[{"line_number":47,"context_line":"                                     group\u003d\u0027healthcheck\u0027)"},{"line_number":48,"context_line":"        self.file_paths \u003d self._conf_get(\u0027enable_by_file_paths\u0027)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def healthcheck(self, server_port):"},{"line_number":51,"context_line":"        for file_path in self.file_paths:"},{"line_number":52,"context_line":"            if not os.path.exists(file_path):"},{"line_number":53,"context_line":"                LOG.warning(\u0027EnableByFiles healthcheck middleware: Path %s \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"b83c4223_dadb583b","line":50,"range":{"start_line":50,"start_character":24,"end_line":50,"end_character":37},"in_reply_to":"99100559_d28460f0","updated":"2024-07-02 09:55:46.000000000","message":"yes, can\u0027t help though, it is implemented in init to call like this, I can change that calling if required.\n\nhttps://github.com/openstack/oslo.middleware/blob/master/oslo_middleware/healthcheck/__init__.py#L577","commit_id":"d9f2db135dfef7f27f44d64cf07b78e53f0c8a29"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"c5dc119fa1c71fc7caefefc7c55d451f94085506","unresolved":true,"context_lines":[{"line_number":47,"context_line":"                                     group\u003d\u0027healthcheck\u0027)"},{"line_number":48,"context_line":"        self.file_paths \u003d self._conf_get(\u0027enable_by_file_paths\u0027)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def healthcheck(self, server_port):"},{"line_number":51,"context_line":"        for file_path in self.file_paths:"},{"line_number":52,"context_line":"            if not os.path.exists(file_path):"},{"line_number":53,"context_line":"                LOG.warning(\u0027EnableByFiles healthcheck middleware: Path %s \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"4c06d67c_6252f774","line":50,"range":{"start_line":50,"start_character":24,"end_line":50,"end_character":37},"in_reply_to":"b83c4223_dadb583b","updated":"2024-07-02 15:11:09.000000000","message":"ok no problem","commit_id":"d9f2db135dfef7f27f44d64cf07b78e53f0c8a29"}],"oslo_middleware/healthcheck/opts.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"d90ad0f725776195697213bea123daf4dec86149","unresolved":true,"context_lines":[{"line_number":62,"context_line":"ENABLE_BY_FILES_OPTS \u003d ["},{"line_number":63,"context_line":"    cfg.ListOpt(\u0027enable_by_file_paths\u0027,"},{"line_number":64,"context_line":"                default\u003d[],"},{"line_number":65,"context_line":"                help\u003d\u0027Check the presence of a file. Used by \u0027"},{"line_number":66,"context_line":"                     \u0027EnableByFilesHealthcheck plugin.\u0027),"},{"line_number":67,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"99d903c2_f364bf1a","line":65,"range":{"start_line":65,"start_character":46,"end_line":65,"end_character":50},"updated":"2024-07-02 09:48:13.000000000","message":"is it not a list of files?","commit_id":"d9f2db135dfef7f27f44d64cf07b78e53f0c8a29"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"009d0e0a64148d5851672916c085396e4aaf8933","unresolved":false,"context_lines":[{"line_number":62,"context_line":"ENABLE_BY_FILES_OPTS \u003d ["},{"line_number":63,"context_line":"    cfg.ListOpt(\u0027enable_by_file_paths\u0027,"},{"line_number":64,"context_line":"                default\u003d[],"},{"line_number":65,"context_line":"                help\u003d\u0027Check the presence of a file. Used by \u0027"},{"line_number":66,"context_line":"                     \u0027EnableByFilesHealthcheck plugin.\u0027),"},{"line_number":67,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"bc828b13_d10facbc","line":65,"range":{"start_line":65,"start_character":46,"end_line":65,"end_character":50},"in_reply_to":"99d903c2_f364bf1a","updated":"2024-07-02 09:55:46.000000000","message":"Acknowledged","commit_id":"d9f2db135dfef7f27f44d64cf07b78e53f0c8a29"}],"releasenotes/notes/enable-by-files-healthcheck-29938e3d6b8e5730.yaml":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"d90ad0f725776195697213bea123daf4dec86149","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The new ``enable_by_files`` healthcheck plugin has been added."},{"line_number":5,"context_line":"    This plugin will help to check whether specified file path in"},{"line_number":6,"context_line":"    ``[healthcheck] enable_by_file_paths`` is present or not."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"28bc710b_ee3ea530","line":5,"range":{"start_line":5,"start_character":53,"end_line":5,"end_character":62},"updated":"2024-07-02 09:48:13.000000000","message":"same thing here, I think we should pluralize it, else people may misunderstood the right semantic of this plugin.","commit_id":"d9f2db135dfef7f27f44d64cf07b78e53f0c8a29"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"009d0e0a64148d5851672916c085396e4aaf8933","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The new ``enable_by_files`` healthcheck plugin has been added."},{"line_number":5,"context_line":"    This plugin will help to check whether specified file path in"},{"line_number":6,"context_line":"    ``[healthcheck] enable_by_file_paths`` is present or not."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"914580e2_3b1d22b4","line":5,"range":{"start_line":5,"start_character":53,"end_line":5,"end_character":62},"in_reply_to":"28bc710b_ee3ea530","updated":"2024-07-02 09:55:46.000000000","message":"Acknowledged","commit_id":"d9f2db135dfef7f27f44d64cf07b78e53f0c8a29"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"d90ad0f725776195697213bea123daf4dec86149","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The new ``enable_by_files`` healthcheck plugin has been added."},{"line_number":5,"context_line":"    This plugin will help to check whether specified file path in"},{"line_number":6,"context_line":"    ``[healthcheck] enable_by_file_paths`` is present or not."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"c03b61c4_7513f264","line":6,"range":{"start_line":6,"start_character":43,"end_line":6,"end_character":45},"updated":"2024-07-02 09:48:13.000000000","message":"are","commit_id":"d9f2db135dfef7f27f44d64cf07b78e53f0c8a29"},{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"009d0e0a64148d5851672916c085396e4aaf8933","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The new ``enable_by_files`` healthcheck plugin has been added."},{"line_number":5,"context_line":"    This plugin will help to check whether specified file path in"},{"line_number":6,"context_line":"    ``[healthcheck] enable_by_file_paths`` is present or not."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"c9763159_0899f9b7","line":6,"range":{"start_line":6,"start_character":43,"end_line":6,"end_character":45},"in_reply_to":"c03b61c4_7513f264","updated":"2024-07-02 09:55:46.000000000","message":"Acknowledged","commit_id":"d9f2db135dfef7f27f44d64cf07b78e53f0c8a29"}]}