)]}'
{"oslo_middleware/cors.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"8e345d908577aefa3e00c72832c7edfca64a3c12","unresolved":true,"context_lines":[{"line_number":74,"context_line":"    # there\u0027s no good way for a user to override only one option, because all"},{"line_number":75,"context_line":"    # the others would be overridden to \u0027None\u0027."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    valid_params \u003d {k.name for k in CORS_OPTS"},{"line_number":78,"context_line":"                    if k.name !\u003d \u0027allowed_origin\u0027}"},{"line_number":79,"context_line":"    passed_params \u003d {k for k in kwargs}"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    wrong_params \u003d passed_params - valid_params"}],"source_content_type":"text/x-python","patch_set":3,"id":"15e8fc9e_e3073c89","line":78,"range":{"start_line":77,"start_character":4,"end_line":78,"end_character":50},"updated":"2024-10-21 13:22:29.000000000","message":"I personaly prefer continue the explicit call to the set function, that I feel less confusing that the brace syntax. I\u0027m personaly more used to use brace for dicts.","commit_id":"06123454ef49914dfb14a47f94278ad71b5169bc"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"8bdac8f9cfc51e1a3139920c3b64c5ec9539ac94","unresolved":true,"context_lines":[{"line_number":74,"context_line":"    # there\u0027s no good way for a user to override only one option, because all"},{"line_number":75,"context_line":"    # the others would be overridden to \u0027None\u0027."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    valid_params \u003d {k.name for k in CORS_OPTS"},{"line_number":78,"context_line":"                    if k.name !\u003d \u0027allowed_origin\u0027}"},{"line_number":79,"context_line":"    passed_params \u003d {k for k in kwargs}"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    wrong_params \u003d passed_params - valid_params"}],"source_content_type":"text/x-python","patch_set":3,"id":"269fce52_e530a6f2","line":78,"range":{"start_line":77,"start_character":4,"end_line":78,"end_character":50},"in_reply_to":"15e8fc9e_e3073c89","updated":"2024-10-21 13:24:10.000000000","message":"but that\u0027s just my preference, your code is correct and here brace will conduct to a set, which is what we want to avoid duplicated entries, so feel free to ignore my previous comment","commit_id":"06123454ef49914dfb14a47f94278ad71b5169bc"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"d1f5646c1907ab624c05962eda461660f944ba50","unresolved":true,"context_lines":[{"line_number":74,"context_line":"    # there\u0027s no good way for a user to override only one option, because all"},{"line_number":75,"context_line":"    # the others would be overridden to \u0027None\u0027."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    valid_params \u003d {k.name for k in CORS_OPTS"},{"line_number":78,"context_line":"                    if k.name !\u003d \u0027allowed_origin\u0027}"},{"line_number":79,"context_line":"    passed_params \u003d {k for k in kwargs}"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    wrong_params \u003d passed_params - valid_params"}],"source_content_type":"text/x-python","patch_set":3,"id":"e1cdfe89_21fd669b","line":78,"range":{"start_line":77,"start_character":4,"end_line":78,"end_character":50},"in_reply_to":"269fce52_e530a6f2","updated":"2024-10-24 11:28:50.000000000","message":"For me it\u0027s ok with that new syntax.","commit_id":"06123454ef49914dfb14a47f94278ad71b5169bc"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5a5456ef4d69714c6ed7894673143061688c4acd","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    # there\u0027s no good way for a user to override only one option, because all"},{"line_number":75,"context_line":"    # the others would be overridden to \u0027None\u0027."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    valid_params \u003d {k.name for k in CORS_OPTS"},{"line_number":78,"context_line":"                    if k.name !\u003d \u0027allowed_origin\u0027}"},{"line_number":79,"context_line":"    passed_params \u003d {k for k in kwargs}"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    wrong_params \u003d passed_params - valid_params"}],"source_content_type":"text/x-python","patch_set":3,"id":"ea6135e1_f5b97684","line":78,"range":{"start_line":77,"start_character":4,"end_line":78,"end_character":50},"in_reply_to":"e1cdfe89_21fd669b","updated":"2025-09-30 16:02:46.000000000","message":"Done","commit_id":"06123454ef49914dfb14a47f94278ad71b5169bc"}]}