)]}'
{"oslo_policy/openstack/common/fileutils.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"49f32d967ba8280994667c78d243ae055a5f63c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"da9b358b_9174d1fd","updated":"2015-03-30 07:18:29.000000000","message":"these changes should be made to oslo-incubator first.","commit_id":"a691fab75a0250cead5177fe767770664115f9ee"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"e0fbf2848635175419f0c2b5757e092498106bde","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"da9b358b_f762e4d7","in_reply_to":"da9b358b_9174d1fd","updated":"2015-03-30 13:09:24.000000000","message":"++","commit_id":"a691fab75a0250cead5177fe767770664115f9ee"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"01fc4abed696b5032947e2a599e15e100b3900fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"da9b358b_39ef0789","in_reply_to":"da9b358b_f762e4d7","updated":"2015-03-31 00:46:13.000000000","message":"thanks Rodrigo and Steve, it\u0027s here.\nhttps://review.openstack.org/168819","commit_id":"a691fab75a0250cead5177fe767770664115f9ee"}],"oslo_policy/policy.py":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"e0fbf2848635175419f0c2b5757e092498106bde","unresolved":false,"context_lines":[{"line_number":386,"context_line":""},{"line_number":387,"context_line":"    @staticmethod"},{"line_number":388,"context_line":"    def _walk_through_policy_directory(path, func, *args):"},{"line_number":389,"context_line":"        # We check if the directory is fresh or not"},{"line_number":390,"context_line":"        reloaded, _ \u003d fileutils.read_cached_file("},{"line_number":391,"context_line":"            path, force_reload\u003dargs[0])"},{"line_number":392,"context_line":"        if not reloaded:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_37b04c43","line":389,"updated":"2015-03-30 13:09:24.000000000","message":"prefer to have this as a private method","commit_id":"a691fab75a0250cead5177fe767770664115f9ee"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"01fc4abed696b5032947e2a599e15e100b3900fb","unresolved":false,"context_lines":[{"line_number":386,"context_line":""},{"line_number":387,"context_line":"    @staticmethod"},{"line_number":388,"context_line":"    def _walk_through_policy_directory(path, func, *args):"},{"line_number":389,"context_line":"        # We check if the directory is fresh or not"},{"line_number":390,"context_line":"        reloaded, _ \u003d fileutils.read_cached_file("},{"line_number":391,"context_line":"            path, force_reload\u003dargs[0])"},{"line_number":392,"context_line":"        if not reloaded:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_9985f3ae","line":389,"in_reply_to":"da9b358b_37b04c43","updated":"2015-03-31 00:46:13.000000000","message":"hi Rodrigo, thanks for the reviewing.\nhmm... I wonder if it is really worth to do that ?\nin line 389, I only check if the directory fresh or not, and I don\u0027t care about the data.\n\nbut for line 401, I need to get the date of that file(not directory), the logic is kinds of different, so it will be not easy to do that.\nor do you have any other good solution?\nI am good to listen.\n\nthanks Eli.","commit_id":"a691fab75a0250cead5177fe767770664115f9ee"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"18a7e86ceb5747f2716f7b3864cccff24e025aa4","unresolved":false,"context_lines":[{"line_number":386,"context_line":""},{"line_number":387,"context_line":"    @staticmethod"},{"line_number":388,"context_line":"    def _walk_through_policy_directory(path, func, *args):"},{"line_number":389,"context_line":"        # We check if the directory is fresh or not"},{"line_number":390,"context_line":"        reloaded, _ \u003d fileutils.read_cached_file("},{"line_number":391,"context_line":"            path, force_reload\u003dargs[0])"},{"line_number":392,"context_line":"        if not reloaded:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_5608442d","line":389,"in_reply_to":"da9b358b_9985f3ae","updated":"2015-03-31 13:18:17.000000000","message":"makes sense, so I suggest to add a more descriptive comment and assign args[0] to a var with meaningful name before actually using","commit_id":"a691fab75a0250cead5177fe767770664115f9ee"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"e0fbf2848635175419f0c2b5757e092498106bde","unresolved":false,"context_lines":[{"line_number":398,"context_line":"            func(os.path.join(path, policy_file), *args)"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"    def _load_policy_file(self, path, force_reload, overwrite\u003dTrue):"},{"line_number":401,"context_line":"            reloaded, data \u003d fileutils.read_cached_file("},{"line_number":402,"context_line":"                path, force_reload\u003dforce_reload)"},{"line_number":403,"context_line":"            if reloaded or not self.rules or (not overwrite and force_reload):"},{"line_number":404,"context_line":"                rules \u003d Rules.load_json(data, self.default_rule)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_b7e9fc1c","line":401,"updated":"2015-03-30 13:09:24.000000000","message":"the method can be reused here","commit_id":"a691fab75a0250cead5177fe767770664115f9ee"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"01fc4abed696b5032947e2a599e15e100b3900fb","unresolved":false,"context_lines":[{"line_number":398,"context_line":"            func(os.path.join(path, policy_file), *args)"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"    def _load_policy_file(self, path, force_reload, overwrite\u003dTrue):"},{"line_number":401,"context_line":"            reloaded, data \u003d fileutils.read_cached_file("},{"line_number":402,"context_line":"                path, force_reload\u003dforce_reload)"},{"line_number":403,"context_line":"            if reloaded or not self.rules or (not overwrite and force_reload):"},{"line_number":404,"context_line":"                rules \u003d Rules.load_json(data, self.default_rule)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da9b358b_598f6bcc","line":401,"in_reply_to":"da9b358b_b7e9fc1c","updated":"2015-03-31 00:46:13.000000000","message":"ditto.","commit_id":"a691fab75a0250cead5177fe767770664115f9ee"}]}