)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"7968d796ac9e848055db0b4e49417c6242aecafe","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Support policy file in YAML"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"YAML provides the advantage of being able to add comments."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ic6236665f2d55b24a56a99120ac57fc2b18e32eb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a57f1b5_0dd3b205","line":10,"updated":"2016-02-11 11:03:37.000000000","message":"maybe add a bp to track this","commit_id":"31bb4e100895dd9c591d5f333d5bcd60abd78a80"}],"oslo_policy/policy.py":[{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"f382e526ede22a65f4697789214df40fa0ab546e","unresolved":false,"context_lines":[{"line_number":299,"context_line":"    \"\"\"A store for rules. Handles the default_rule setting directly.\"\"\""},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    @classmethod"},{"line_number":302,"context_line":"    def load_json(cls, data, default_rule\u003dNone):"},{"line_number":303,"context_line":"        \"\"\"Allow loading of YAML/JSON rule data.\"\"\""},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a57f1b5_d1f8c84b","line":302,"updated":"2016-02-11 13:58:05.000000000","message":"the name of this method is no longer accurate. Can we change it to load_rules? Or add a load_rules method that supports yaml, leave load_json only supporting json, and deprecate load_json?","commit_id":"31bb4e100895dd9c591d5f333d5bcd60abd78a80"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"a40009f07df7b46d24947491de6f4930298fa79e","unresolved":false,"context_lines":[{"line_number":299,"context_line":"    \"\"\"A store for rules. Handles the default_rule setting directly.\"\"\""},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    @classmethod"},{"line_number":302,"context_line":"    def load_json(cls, data, default_rule\u003dNone):"},{"line_number":303,"context_line":"        \"\"\"Allow loading of YAML/JSON rule data.\"\"\""},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a57f1b5_1d598efe","line":302,"in_reply_to":"3a57f1b5_d1f8c84b","updated":"2016-02-11 15:35:54.000000000","message":"adding a general purpose method + deprecating this one makes sense to me, but leaving this one also reading YAML","commit_id":"31bb4e100895dd9c591d5f333d5bcd60abd78a80"}],"oslo_policy/tests/test_policy.py":[{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"7968d796ac9e848055db0b4e49417c6242aecafe","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                          \u0027default\u0027)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    @mock.patch.object(_parser, \u0027parse_rule\u0027, lambda x: x)"},{"line_number":110,"context_line":"    def test_load_yaml(self):"},{"line_number":111,"context_line":"        exemplar \u003d \"\"\""},{"line_number":112,"context_line":"# Define a custom rule."},{"line_number":113,"context_line":"admin_or_owner: role:admin or project_id:%(project_id)s"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a57f1b5_2d6a2e1b","line":110,"range":{"start_line":110,"start_character":8,"end_line":110,"end_character":22},"updated":"2016-02-11 11:03:37.000000000","message":"add a comment saying this is testing the usage of comments which isn\u0027t a valid JSON (all the other tests use json.dumps())","commit_id":"31bb4e100895dd9c591d5f333d5bcd60abd78a80"},{"author":{"_account_id":10608,"name":"Matthew Edmonds","email":"edmondsw@us.ibm.com","username":"edmondsw"},"change_message_id":"f382e526ede22a65f4697789214df40fa0ab546e","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                          \u0027default\u0027)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    @mock.patch.object(_parser, \u0027parse_rule\u0027, lambda x: x)"},{"line_number":110,"context_line":"    def test_load_yaml(self):"},{"line_number":111,"context_line":"        exemplar \u003d \"\"\""},{"line_number":112,"context_line":"# Define a custom rule."},{"line_number":113,"context_line":"admin_or_owner: role:admin or project_id:%(project_id)s"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a57f1b5_71323412","line":110,"range":{"start_line":110,"start_character":8,"end_line":110,"end_character":22},"in_reply_to":"3a57f1b5_2d6a2e1b","updated":"2016-02-11 13:58:05.000000000","message":"The larger purpose of this method is to test yaml, not to test comments. Testing comments is just part of testing yaml support.","commit_id":"31bb4e100895dd9c591d5f333d5bcd60abd78a80"},{"author":{"_account_id":11022,"name":"Rodrigo Duarte Sousa","email":"rodrigodsousa@gmail.com","username":"rodrigods"},"change_message_id":"a40009f07df7b46d24947491de6f4930298fa79e","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                          \u0027default\u0027)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    @mock.patch.object(_parser, \u0027parse_rule\u0027, lambda x: x)"},{"line_number":110,"context_line":"    def test_load_yaml(self):"},{"line_number":111,"context_line":"        exemplar \u003d \"\"\""},{"line_number":112,"context_line":"# Define a custom rule."},{"line_number":113,"context_line":"admin_or_owner: role:admin or project_id:%(project_id)s"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a57f1b5_fdc0327e","line":110,"range":{"start_line":110,"start_character":8,"end_line":110,"end_character":22},"in_reply_to":"3a57f1b5_71323412","updated":"2016-02-11 15:35:54.000000000","message":"sure, but the main difference from JSON to YAML in our case is exactly that (the comments)","commit_id":"31bb4e100895dd9c591d5f333d5bcd60abd78a80"}]}