)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"9d31da58065c31e2f9ec6ffd3ab2b634a58b0907","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Remove example about using user_id in the rules"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Policy enforcement by user_id was untested, so this isn\u0027t"},{"line_number":10,"context_line":"feature supported by openstack projects. This patch the example"},{"line_number":11,"context_line":"about using user_id in the policy, avoid to confuse user that"},{"line_number":12,"context_line":"enforcement by user_id is supported feature."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_9017e6ec","line":10,"updated":"2016-06-05 18:13:08.000000000","message":"It\u0027s used by keystone, see the sample policy.json: http://git.openstack.org/cgit/openstack/keystone/tree/etc/policy.json#n5","commit_id":"0d6981377f4b0fccc2d87531f602daf9276e4fa5"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"c9c072fe73b6ae55cc602f5e5d2fd3ed8b2f9afe","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Remove example about using user_id in the rules"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Policy enforcement by user_id was untested, so this isn\u0027t"},{"line_number":10,"context_line":"feature supported by openstack projects. This patch the example"},{"line_number":11,"context_line":"about using user_id in the policy, avoid to confuse user that"},{"line_number":12,"context_line":"enforcement by user_id is supported feature."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7aa08908_b6c49a40","line":10,"in_reply_to":"7aa08908_9017e6ec","updated":"2016-06-06 01:11:00.000000000","message":"thanks, indeed, some of resource in some of projects still use user_id, maybe I should add a note at here.","commit_id":"0d6981377f4b0fccc2d87531f602daf9276e4fa5"}],"oslo_policy/policy.py":[{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"15256815cd9a5380ad0b8f5aea4361f340e31d63","unresolved":false,"context_lines":[{"line_number":133,"context_line":"Together with the previously shown example, a complete generic check"},{"line_number":134,"context_line":"would be::"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    project_id:%(user.id)s"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"It is also possible to perform checks against other attributes that"},{"line_number":139,"context_line":"represent the credentials.  This is done by adding additional values to"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_423bf4eb","line":136,"range":{"start_line":136,"start_character":17,"end_line":136,"end_character":24},"updated":"2016-06-05 14:01:32.000000000","message":"should probably fix this up in another patch","commit_id":"0d6981377f4b0fccc2d87531f602daf9276e4fa5"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"792dcdbc4ff180e94f7d5f28dc1fc04a560e7eee","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    - domain_id or project_id (depending on the token scope)"},{"line_number":128,"context_line":"    - list of roles held for the given token scope"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":".. note:: Some of resources which are exposed by API don\u0027t support policy"},{"line_number":131,"context_line":"enforcement by user_id, only support policy enforcement by project_id. Also"},{"line_number":132,"context_line":"have some of resources are global resources, they don\u0027t support policy"},{"line_number":133,"context_line":"enforcement by both user_id and project_id."}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_2420adf6","line":130,"range":{"start_line":130,"start_character":10,"end_line":130,"end_character":27},"updated":"2016-06-08 17:22:39.000000000","message":"Since these notes end up in docs, please correct the grammar as follows:\n\n\"Some resources which are exposed by the API do not support policy enforcement by user_id, and only support policy enforcement by project_id. Also some resources are global and do not support policy enforcement by both user_id and project_id.\"","commit_id":"547c991e7e3215a40ba0745a9348fa59c949e848"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"243581251c54363e62b9d238d466432f960c0dee","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    - domain_id or project_id (depending on the token scope)"},{"line_number":128,"context_line":"    - list of roles held for the given token scope"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":".. note:: Some of resources which are exposed by API don\u0027t support policy"},{"line_number":131,"context_line":"enforcement by user_id, only support policy enforcement by project_id. Also"},{"line_number":132,"context_line":"have some of resources are global resources, they don\u0027t support policy"},{"line_number":133,"context_line":"enforcement by both user_id and project_id."}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_2d24a6ad","line":130,"range":{"start_line":130,"start_character":10,"end_line":130,"end_character":14},"updated":"2016-06-06 18:43:54.000000000","message":"seems not proper to mention nova here, nova has the doc for this \u0027not support\u0027?","commit_id":"547c991e7e3215a40ba0745a9348fa59c949e848"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"7b87d562d0f87d6cebb937a396f8226adf0b6314","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    - domain_id or project_id (depending on the token scope)"},{"line_number":128,"context_line":"    - list of roles held for the given token scope"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":".. note:: Some of resources which are exposed by API don\u0027t support policy"},{"line_number":131,"context_line":"enforcement by user_id, only support policy enforcement by project_id. Also"},{"line_number":132,"context_line":"have some of resources are global resources, they don\u0027t support policy"},{"line_number":133,"context_line":"enforcement by both user_id and project_id."}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_b66f6c91","line":130,"range":{"start_line":130,"start_character":10,"end_line":130,"end_character":27},"in_reply_to":"7aa08908_2420adf6","updated":"2016-06-22 05:37:39.000000000","message":"@jichenjc, good point, i  think i can write something in devref\n\n@Eric, thanks, will update","commit_id":"547c991e7e3215a40ba0745a9348fa59c949e848"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"5eb1ad943036ef973eeda4735d763893ce0287f6","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    - domain_id or project_id (depending on the token scope)"},{"line_number":128,"context_line":"    - list of roles held for the given token scope"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":".. note:: Some of resources which are exposed by API don\u0027t support policy"},{"line_number":131,"context_line":"enforcement by user_id, only support policy enforcement by project_id. Also"},{"line_number":132,"context_line":"have some of resources are global resources, they don\u0027t support policy"},{"line_number":133,"context_line":"enforcement by both user_id and project_id."}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_44f1846a","line":130,"range":{"start_line":130,"start_character":10,"end_line":130,"end_character":14},"in_reply_to":"7aa08908_2d24a6ad","updated":"2016-06-08 15:03:25.000000000","message":"do you mean we shouldn\u0027t add note at here? I guess this is a notice for developer to aware that some of resources isn\u0027t ready for user_id based enforcement.","commit_id":"547c991e7e3215a40ba0745a9348fa59c949e848"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"807c7bae9d3c0c6bf52c4c5294053acd5b7d8c64","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    - domain_id or project_id (depending on the token scope)"},{"line_number":128,"context_line":"    - list of roles held for the given token scope"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":".. note:: Some of resources which are exposed by API don\u0027t support policy"},{"line_number":131,"context_line":"enforcement by user_id, only support policy enforcement by project_id. Also"},{"line_number":132,"context_line":"have some of resources are global resources, they don\u0027t support policy"},{"line_number":133,"context_line":"enforcement by both user_id and project_id."}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_8d0eefe2","line":130,"range":{"start_line":130,"start_character":10,"end_line":130,"end_character":14},"in_reply_to":"7aa08908_44f1846a","updated":"2016-06-08 15:25:01.000000000","message":"no, I mean do we have a doc currently in nova says we won\u0027t support it ? I know we will have a spec for it ..","commit_id":"547c991e7e3215a40ba0745a9348fa59c949e848"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"243581251c54363e62b9d238d466432f960c0dee","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":".. note:: Some of resources which are exposed by API don\u0027t support policy"},{"line_number":131,"context_line":"enforcement by user_id, only support policy enforcement by project_id. Also"},{"line_number":132,"context_line":"have some of resources are global resources, they don\u0027t support policy"},{"line_number":133,"context_line":"enforcement by both user_id and project_id."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"For example, a check on the user_id would be defined as::"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_8d14ba44","line":132,"range":{"start_line":132,"start_character":0,"end_line":132,"end_character":4},"updated":"2016-06-06 18:43:54.000000000","message":"remove this \u0027have\u0027","commit_id":"547c991e7e3215a40ba0745a9348fa59c949e848"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"5eb1ad943036ef973eeda4735d763893ce0287f6","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":".. note:: Some of resources which are exposed by API don\u0027t support policy"},{"line_number":131,"context_line":"enforcement by user_id, only support policy enforcement by project_id. Also"},{"line_number":132,"context_line":"have some of resources are global resources, they don\u0027t support policy"},{"line_number":133,"context_line":"enforcement by both user_id and project_id."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"For example, a check on the user_id would be defined as::"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_24f43859","line":132,"range":{"start_line":132,"start_character":0,"end_line":132,"end_character":4},"in_reply_to":"7aa08908_8d14ba44","updated":"2016-06-08 15:03:25.000000000","message":"Done","commit_id":"547c991e7e3215a40ba0745a9348fa59c949e848"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"77f1c3441e5ba45eda8b935c086449986cedc141","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":".. note:: Some resources which are exposed by the API do not support policy"},{"line_number":131,"context_line":"enforcement by user_id, and only support policy enforcement by project_id."},{"line_number":132,"context_line":"Also some resources are global and do not support policy enforcement by both"},{"line_number":133,"context_line":"user_id and project_id"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"For example, a check on the user_id would be defined as::"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_2d7dcd6e","line":133,"range":{"start_line":132,"start_character":0,"end_line":133,"end_character":22},"updated":"2016-06-22 15:18:42.000000000","message":"This is a little confusing. Are you saying that they support enforcement by either project_id or user_id, but not both? If so, this might be clearer:\n\n\"Some global resources support policy enforcement by either user_id or project_id, but not both.\"","commit_id":"64f3d6aa244025e8c36865760b3e8ce566e8e538"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"8cb47d3dac01ac12a2e9934e359dce3d7ff548d9","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":".. note:: Some resources which are exposed by the API do not support policy"},{"line_number":131,"context_line":"enforcement by user_id, and only support policy enforcement by project_id."},{"line_number":132,"context_line":"Also some resources are global and do not support policy enforcement by both"},{"line_number":133,"context_line":"user_id and project_id"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"For example, a check on the user_id would be defined as::"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_23761dd7","line":133,"range":{"start_line":132,"start_character":0,"end_line":133,"end_character":22},"in_reply_to":"1aa78d24_2c2d2bfe","updated":"2016-07-20 20:08:29.000000000","message":"Done","commit_id":"64f3d6aa244025e8c36865760b3e8ce566e8e538"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"cec987b4550f0cab33d605b1d89a08eefd6df117","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":".. note:: Some resources which are exposed by the API do not support policy"},{"line_number":131,"context_line":"enforcement by user_id, and only support policy enforcement by project_id."},{"line_number":132,"context_line":"Also some resources are global and do not support policy enforcement by both"},{"line_number":133,"context_line":"user_id and project_id"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"For example, a check on the user_id would be defined as::"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3aaa91ec_cd726249","line":133,"range":{"start_line":132,"start_character":0,"end_line":133,"end_character":22},"in_reply_to":"3aaa91ec_2d7dcd6e","updated":"2016-06-28 02:35:46.000000000","message":"Emm....I want to say: for some global resource, all of those: user_id,  project_id, user_id\u0026project_id, we didn\u0027t support.","commit_id":"64f3d6aa244025e8c36865760b3e8ce566e8e538"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"fdd6f7b9abf58a074f84d6a1363649072162e76d","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":".. note:: Some resources which are exposed by the API do not support policy"},{"line_number":131,"context_line":"enforcement by user_id, and only support policy enforcement by project_id."},{"line_number":132,"context_line":"Also some resources are global and do not support policy enforcement by both"},{"line_number":133,"context_line":"user_id and project_id"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"For example, a check on the user_id would be defined as::"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_2c2d2bfe","line":133,"range":{"start_line":132,"start_character":0,"end_line":133,"end_character":22},"in_reply_to":"3aaa91ec_cd726249","updated":"2016-07-13 10:56:56.000000000","message":"Let\u0027s make it clear, what about\n\"Some global resources do not support policy enforcement by combination of user_id and project_id\"","commit_id":"64f3d6aa244025e8c36865760b3e8ce566e8e538"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"5485defdd648f6acec9499f660c3924c3c17750a","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    - list of roles held for the given token scope"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":".. note:: Some resources which are exposed by the API do not support policy"},{"line_number":131,"context_line":"enforcement by user_id, and only support policy enforcement by project_id."},{"line_number":132,"context_line":"Some global resources do not support policy enforcement by combination of"},{"line_number":133,"context_line":"user_id and project_id."},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_ecf15f96","line":131,"range":{"start_line":131,"start_character":63,"end_line":131,"end_character":73},"updated":"2016-07-21 17:02:41.000000000","message":"same","commit_id":"cce967ad091c569151254b8a2ac6d950f3fbd761"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"5485defdd648f6acec9499f660c3924c3c17750a","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    - list of roles held for the given token scope"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":".. note:: Some resources which are exposed by the API do not support policy"},{"line_number":131,"context_line":"enforcement by user_id, and only support policy enforcement by project_id."},{"line_number":132,"context_line":"Some global resources do not support policy enforcement by combination of"},{"line_number":133,"context_line":"user_id and project_id."},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_acfbe777","line":131,"range":{"start_line":131,"start_character":15,"end_line":131,"end_character":22},"updated":"2016-07-21 17:02:41.000000000","message":"should be in backticks ``user_id``","commit_id":"cce967ad091c569151254b8a2ac6d950f3fbd761"},{"author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"change_message_id":"5485defdd648f6acec9499f660c3924c3c17750a","unresolved":false,"context_lines":[{"line_number":130,"context_line":".. note:: Some resources which are exposed by the API do not support policy"},{"line_number":131,"context_line":"enforcement by user_id, and only support policy enforcement by project_id."},{"line_number":132,"context_line":"Some global resources do not support policy enforcement by combination of"},{"line_number":133,"context_line":"user_id and project_id."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"For example, a check on the user_id would be defined as::"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_0c31535a","line":133,"range":{"start_line":133,"start_character":0,"end_line":133,"end_character":22},"updated":"2016-07-21 17:02:41.000000000","message":"same","commit_id":"cce967ad091c569151254b8a2ac6d950f3fbd761"}]}
