)]}'
{"oslo_policy/generator.py":[{"author":{"_account_id":21420,"name":"Gage Hugo","email":"gagehugo@gmail.com","username":"ghugo"},"change_message_id":"456be6f97329759b64ff8a3f61b3fc6da2da3785","unresolved":false,"context_lines":[{"line_number":151,"context_line":"    output_file \u003d (open(output_file, \u0027w\u0027) if output_file"},{"line_number":152,"context_line":"                   else sys.stdout)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    if include_help:"},{"line_number":155,"context_line":"        for section in _sort_and_format_by_section(policies):"},{"line_number":156,"context_line":"            output_file.write(section)"},{"line_number":157,"context_line":"    else:"},{"line_number":158,"context_line":"        for section in _sort_and_format_by_section(policies,"},{"line_number":159,"context_line":"                                                   include_help\u003dFalse):"},{"line_number":160,"context_line":"            output_file.write(section)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"def _generate_policy(namespace, output_file\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_a4e71711","line":160,"range":{"start_line":154,"start_character":0,"end_line":160,"end_character":38},"updated":"2017-03-17 16:48:49.000000000","message":"Couldn\u0027t this just be written as:\n\nfor section in _sort_and_format_by_section(policies, include_help\u003dinclude_help):\n    output_file.write(section)","commit_id":"cb078d48cd75e2722ccb6216585b999937dca0df"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"428eda0a3d450ad1cfe74e1e70afa9b1697e2cf6","unresolved":false,"context_lines":[{"line_number":157,"context_line":"    else:"},{"line_number":158,"context_line":"        for section in _sort_and_format_by_section(policies,"},{"line_number":159,"context_line":"                                                   include_help\u003dFalse):"},{"line_number":160,"context_line":"            output_file.write(section)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"def _generate_policy(namespace, output_file\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_fa4b64ae","line":160,"in_reply_to":"1a1ced50_1fd3d239","updated":"2017-03-17 17:56:59.000000000","message":"Done","commit_id":"cb078d48cd75e2722ccb6216585b999937dca0df"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"0999c7ba0de032802c7f4bd311469f9b16dda397","unresolved":false,"context_lines":[{"line_number":157,"context_line":"    else:"},{"line_number":158,"context_line":"        for section in _sort_and_format_by_section(policies,"},{"line_number":159,"context_line":"                                                   include_help\u003dFalse):"},{"line_number":160,"context_line":"            output_file.write(section)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"def _generate_policy(namespace, output_file\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_1fd3d239","line":160,"in_reply_to":"1a1ced50_a4e71711","updated":"2017-03-17 17:17:01.000000000","message":"++","commit_id":"cb078d48cd75e2722ccb6216585b999937dca0df"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"5055953822d355b3f4c786b5af1259e6a045e88f","unresolved":false,"context_lines":[{"line_number":144,"context_line":"    :param namespaces: a list of namespaces registered under"},{"line_number":145,"context_line":"                       \u0027oslo.policy.policies\u0027. Stevedore will look here for"},{"line_number":146,"context_line":"                       policy options."},{"line_number":147,"context_line":"    :param output_file: The path of a file to output to. stdout used if None."},{"line_number":148,"context_line":"    \"\"\""},{"line_number":149,"context_line":"    policies \u003d _get_policies_dict(namespaces)"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a1ced50_758867e8","side":"PARENT","line":147,"updated":"2017-03-17 18:26:13.000000000","message":"While we\u0027re at it, we could include a doc string here for the new parameter.","commit_id":"d4ed4a09a7d3c5e1dd1399ae63935dc8b2764bc8"}],"oslo_policy/tests/test_generator.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f82d9f97579d834a53b3f5b8c51b9dea093ee10b","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        output_file \u003d self.get_config_file_fullname(\u0027policy.yaml\u0027)"},{"line_number":61,"context_line":"        with mock.patch(\u0027stevedore.named.NamedExtensionManager\u0027,"},{"line_number":62,"context_line":"                        return_value\u003dtest_mgr) as mock_ext_mgr:"},{"line_number":63,"context_line":"            generator._generate_sample([\u0027base_rules\u0027, \u0027rules\u0027], output_file,"},{"line_number":64,"context_line":"                                       include_help\u003dFalse)"},{"line_number":65,"context_line":"            mock_ext_mgr.assert_called_once_with("},{"line_number":66,"context_line":"                \u0027oslo.policy.policies\u0027, names\u003d[\u0027base_rules\u0027, \u0027rules\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_845cdb26","line":63,"updated":"2017-03-17 16:40:39.000000000","message":"The only improvement I can think of here it so provide some sort of comment. We can also do that later.","commit_id":"cb078d48cd75e2722ccb6216585b999937dca0df"},{"author":{"_account_id":20217,"name":"Anusha Unnam","email":"anusha.unnam25@gmail.com","username":"aunnam"},"change_message_id":"428eda0a3d450ad1cfe74e1e70afa9b1697e2cf6","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        output_file \u003d self.get_config_file_fullname(\u0027policy.yaml\u0027)"},{"line_number":61,"context_line":"        with mock.patch(\u0027stevedore.named.NamedExtensionManager\u0027,"},{"line_number":62,"context_line":"                        return_value\u003dtest_mgr) as mock_ext_mgr:"},{"line_number":63,"context_line":"            generator._generate_sample([\u0027base_rules\u0027, \u0027rules\u0027], output_file,"},{"line_number":64,"context_line":"                                       include_help\u003dFalse)"},{"line_number":65,"context_line":"            mock_ext_mgr.assert_called_once_with("},{"line_number":66,"context_line":"                \u0027oslo.policy.policies\u0027, names\u003d[\u0027base_rules\u0027, \u0027rules\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a1ced50_3acc1c35","line":63,"in_reply_to":"1a1ced50_845cdb26","updated":"2017-03-17 17:56:59.000000000","message":"Done","commit_id":"cb078d48cd75e2722ccb6216585b999937dca0df"}]}