)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f75d7af94d323feb3e502618cbd02a7c0ef68726","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Anthony Washington \u003canthony.washington@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-21 14:54:22 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add release note for 439070"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds the release not for the"},{"line_number":10,"context_line":"new defined policy class."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a1ced50_0fea44ac","line":7,"updated":"2017-03-22 01:19:40.000000000","message":"Instead of using the review number, you can probably just use the class name.\n\n  Add release note for DocumentedRuleDefault\n\nIs can be easier on reviewers to link to the patch using the change id, for example:\n\n  This patch adds a release note for changes made in a\n  subsequent patch (Ie9b335420394166bb39c43e3d26fcc9237ffd1a0).","commit_id":"c393d5139311f8153f34639b4fe927126194f04b"}],"releasenotes/notes/oslo-policy-descriptive-support-3ee688c5fa48d751.yaml":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f75d7af94d323feb3e502618cbd02a7c0ef68726","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added the option to define a more descriptive policy rule"},{"line_number":5,"context_line":"    by using ``policy.DocumentedRuleDefault`` class. When using"},{"line_number":6,"context_line":"    this class it is required that the description and operations"},{"line_number":7,"context_line":"    parameters are defined, unlike ``policy.RuleDefault``. The"},{"line_number":8,"context_line":"    operations parameter is a list of dictionaries that must"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1a1ced50_6fd9f821","line":5,"updated":"2017-03-22 01:19:40.000000000","message":"I think we can get away with single ` here","commit_id":"c393d5139311f8153f34639b4fe927126194f04b"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f75d7af94d323feb3e502618cbd02a7c0ef68726","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    parameters are defined, unlike ``policy.RuleDefault``. The"},{"line_number":8,"context_line":"    operations parameter is a list of dictionaries that must"},{"line_number":9,"context_line":"    contain the two keys \u0027path\u0027 and \u0027method\u0027 which represent"},{"line_number":10,"context_line":"    the API URL and the HTTP REQUEST METHOD."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1a1ced50_6f4738bc","line":10,"updated":"2017-03-22 01:19:40.000000000","message":"Another thing that be useful here is a link to any documentation that describes the feature. If we have docs we should link to them here so that operators/developer can easier find more information about what we\u0027re talking about in the release note, instead of making them go hunt for it.\n\nDo we have doc proposed that detail the usage of this? The usage document would be a good place for something like this [0]. \n\n[0] https://docs.openstack.org/developer/oslo.policy/usage.html","commit_id":"c393d5139311f8153f34639b4fe927126194f04b"},{"author":{"_account_id":22219,"name":"Anthony Washington","email":"anthony.washington@intel.com","username":"antwash"},"change_message_id":"6c950c08d793ceca3300d42f6e32bbd3e19b1d95","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    parameters are defined, unlike ``policy.RuleDefault``. The"},{"line_number":8,"context_line":"    operations parameter is a list of dictionaries that must"},{"line_number":9,"context_line":"    contain the two keys \u0027path\u0027 and \u0027method\u0027 which represent"},{"line_number":10,"context_line":"    the API URL and the HTTP REQUEST METHOD."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1a1ced50_85b45535","line":10,"in_reply_to":"1a1ced50_6f4738bc","updated":"2017-03-22 02:19:19.000000000","message":"Nice idea, I\u0027ll update the usage document.","commit_id":"c393d5139311f8153f34639b4fe927126194f04b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c9a62b2aa1e5b6982930d0c7d40a8d2fec05f86b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    parameters are defined, unlike `policy.RuleDefault`. The"},{"line_number":8,"context_line":"    operations parameter is a list of dictionaries that must"},{"line_number":9,"context_line":"    contain the two keys \u0027path\u0027 and \u0027method\u0027 which represent"},{"line_number":10,"context_line":"    the API URL and the HTTP REQUEST METHOD. Here is a link"},{"line_number":11,"context_line":"    to our policy usage documentation:"},{"line_number":12,"context_line":"    https://docs.openstack.org/developer/oslo.policy/usage.html"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1a1ced50_cf84950c","line":12,"range":{"start_line":10,"start_character":45,"end_line":12,"end_character":63},"updated":"2017-03-22 13:33:11.000000000","message":"nit: Could you could format this as a link?\n\n   More information in the `docs \u003chttps://docs.openstack.org/developer/oslo.policy/usage.html\u003e`_","commit_id":"8d656343a3a6c9d4a1811247a03e137ca359b709"},{"author":{"_account_id":22219,"name":"Anthony Washington","email":"anthony.washington@intel.com","username":"antwash"},"change_message_id":"8beeb52c52191d435e2018be83039c52d911dac4","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    contain the two keys \u0027path\u0027 and \u0027method\u0027 which represent"},{"line_number":10,"context_line":"    the API URL and the HTTP REQUEST METHOD. Here is a link"},{"line_number":11,"context_line":"    to our policy usage documentation:"},{"line_number":12,"context_line":"    https://docs.openstack.org/developer/oslo.policy/usage.html"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1a1ced50_35773803","line":12,"in_reply_to":"1a1ced50_b57b287a","updated":"2017-03-22 14:10:51.000000000","message":"Done, thanks for the feedback guys!","commit_id":"8d656343a3a6c9d4a1811247a03e137ca359b709"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"878029366078cfdd4b1dcdbc0d0d0d3c8f1396f5","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    contain the two keys \u0027path\u0027 and \u0027method\u0027 which represent"},{"line_number":10,"context_line":"    the API URL and the HTTP REQUEST METHOD. Here is a link"},{"line_number":11,"context_line":"    to our policy usage documentation:"},{"line_number":12,"context_line":"    https://docs.openstack.org/developer/oslo.policy/usage.html"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1a1ced50_b57b287a","line":12,"in_reply_to":"1a1ced50_cf84950c","updated":"2017-03-22 14:03:00.000000000","message":"++ In addition to that we might need another patch to the actual Usage docs that explain the different between the class we\u0027re adding and the existing RuleDefault class. This could also encourage folks to use the new implementation.","commit_id":"8d656343a3a6c9d4a1811247a03e137ca359b709"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bc0d7f825c8911cd808875c00bf2f74b9e2259ca","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    operations parameter is a list of dictionaries that must"},{"line_number":9,"context_line":"    contain the two keys \u0027path\u0027 and \u0027method\u0027 which represent"},{"line_number":10,"context_line":"    the API URL and the HTTP REQUEST METHOD. More information in"},{"line_number":11,"context_line":"    the `docs \u003chttps://docs.openstack.org/developer/oslo.policy/usage.html\u003e`"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1a1ced50_84635f41","line":11,"updated":"2017-03-22 14:46:59.000000000","message":"This needs a trailing underscore","commit_id":"c8d2941d3c928319409f005364dc86368c9d1bc7"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"2b2518a2058eb00c9e826a1cd4216ed2dafd8051","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    operations parameter is a list of dictionaries that must"},{"line_number":9,"context_line":"    contain the two keys \u0027path\u0027 and \u0027method\u0027 which represent"},{"line_number":10,"context_line":"    the API URL and the HTTP REQUEST METHOD. More information can be"},{"line_number":11,"context_line":"    found in the `docs \u003chttps://docs.openstack.org/developer/oslo.policy/usage.html\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1a1ced50_076cd1cc","line":11,"updated":"2017-03-22 14:55:12.000000000","message":"nit: I\u0027d keep the `policy usage documentation` as I think it is a little more formal.","commit_id":"cd41a984e24da081e1c411aff24161b328359a12"}]}