)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6239134302f9734e181743864d41edfb37d774b9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Simplify message of exception PolicyNotAuthorized"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The message is a string, and target and credentials are dicts. Not only"},{"line_number":10,"context_line":"do they make the message very ugly and hard for a human to parse, but"},{"line_number":11,"context_line":"they are giving information that is typically unnecessary and won\u0027t be"},{"line_number":12,"context_line":"understood by most users."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1673859"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ffe62b97_2bacf08a","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":25},"updated":"2017-03-24 11:00:40.000000000","message":"Could you give a before/after example?","commit_id":"273a2b2b801c3cdd5e2eb632665e05c58560f10e"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"7afa900446a3be1815b63e3374c0090561aacc3b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Simplify message of exception PolicyNotAuthorized"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The message is a string, and target and credentials are dicts. Not only"},{"line_number":10,"context_line":"do they make the message very ugly and hard for a human to parse, but"},{"line_number":11,"context_line":"they are giving information that is typically unnecessary and won\u0027t be"},{"line_number":12,"context_line":"understood by most users."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1673859"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5ff73747_742d57fc","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":25},"in_reply_to":"ffe62b97_2bacf08a","updated":"2017-05-02 09:03:05.000000000","message":"Please see usage in Neutron https://github.com/openstack/neutron/blob/master/neutron/policy.py#L338, it describes the context of each parameter.","commit_id":"273a2b2b801c3cdd5e2eb632665e05c58560f10e"}],"oslo_policy/policy.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"dd7aacf3d396a2c4d5ae2582d7c073b6d574467a","unresolved":false,"context_lines":[{"line_number":296,"context_line":"    \"\"\"Default exception raised for policy enforcement failure.\"\"\""},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    def __init__(self, rule, target, creds):"},{"line_number":299,"context_line":"        msg \u003d _(\"Policy doesn\u0027t allow %(rule)s to be \""},{"line_number":300,"context_line":"                \"performed.\") % {\u0027rule\u0027: rule}"},{"line_number":301,"context_line":"        super(PolicyNotAuthorized, self).__init__(msg)"},{"line_number":302,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_417b16f4","line":299,"updated":"2017-05-22 20:27:21.000000000","message":"I don\u0027t think we want to use a contraction in the error message. The quote will make searching for the string unnecessarily difficult in log archives.\n\nHow about going back to the construction of the original form, but leaving out some of the details:\n\n  %(rule)s is disallowed by policy","commit_id":"1d88b380de06b2010ea4a2ff4a66aafe249cb9d7"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"0464b25cc4f6c2365376e80ffff98bc365b76735","unresolved":false,"context_lines":[{"line_number":296,"context_line":"    \"\"\"Default exception raised for policy enforcement failure.\"\"\""},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    def __init__(self, rule, target, creds):"},{"line_number":299,"context_line":"        msg \u003d _(\"Policy doesn\u0027t allow %(rule)s to be \""},{"line_number":300,"context_line":"                \"performed.\") % {\u0027rule\u0027: rule}"},{"line_number":301,"context_line":"        super(PolicyNotAuthorized, self).__init__(msg)"},{"line_number":302,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ff0f0b1f_f32af929","line":299,"in_reply_to":"ff0f0b1f_417b16f4","updated":"2017-05-23 02:47:41.000000000","message":"+1","commit_id":"1d88b380de06b2010ea4a2ff4a66aafe249cb9d7"}]}
