)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"950021aa80872555ed7a35b015c4bf5cfd2d04d2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Don\u0027t deepcopy objects before mask_dict_password"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As far as I can tell, mask_dict_password does not modify the object"},{"line_number":10,"context_line":"passed in to it[0]. As such, this deepcopy only adds an unnecessary"},{"line_number":11,"context_line":"requirement on the policy objects that makes it possible for a call"},{"line_number":12,"context_line":"to fail in a different way when debug logging is enabled. Since this"},{"line_number":13,"context_line":"is pretty terrible, let\u0027s get rid of it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf51134e_1e06621d","line":10,"range":{"start_line":10,"start_character":14,"end_line":10,"end_character":18},"updated":"2020-07-09 09:18:41.000000000","message":"Looks like it simply copies the fields across...","commit_id":"184ed3b8f0e42948b4e81548da1d1e08507d2726"}],"oslo_policy/policy.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"950021aa80872555ed7a35b015c4bf5cfd2d04d2","unresolved":false,"context_lines":[{"line_number":915,"context_line":""},{"line_number":916,"context_line":"        if LOG.isEnabledFor(logging.DEBUG):"},{"line_number":917,"context_line":"            try:"},{"line_number":918,"context_line":"                creds_dict \u003d strutils.mask_dict_password(creds)"},{"line_number":919,"context_line":"                creds_msg \u003d jsonutils.dumps(creds_dict,"},{"line_number":920,"context_line":"                                            skipkeys\u003dTrue, sort_keys\u003dTrue)"},{"line_number":921,"context_line":"            except Exception as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_5e3c5ac7","line":918,"updated":"2020-07-09 09:18:41.000000000","message":"...and neither of these are used (and therefore possibly modified) after being used to generate the messages","commit_id":"184ed3b8f0e42948b4e81548da1d1e08507d2726"}]}