)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"daf0553493ca52abeca2ac16f067e080192acf08","unresolved":false,"context_lines":[{"line_number":10,"context_line":"defaults then operators do not need to keep these"},{"line_number":11,"context_line":"redundant rules in files. \u0027oslopolicy-list-redundant\u0027 tool"},{"line_number":12,"context_line":"is to detects such rule but we can log warnings also for"},{"line_number":13,"context_line":"such rule to communicate it to deployerin strong way."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Partial implement blueprint policy-json-to-yaml"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_036fc827","line":13,"range":{"start_line":13,"start_character":31,"end_line":13,"end_character":41},"updated":"2020-08-27 08:36:35.000000000","message":"the deployer in","commit_id":"3606023c62fd1a82867032977e64283afa229159"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"422ebb9444cdf9200f9537746d6834dfcc588549","unresolved":false,"context_lines":[{"line_number":10,"context_line":"defaults then operators do not need to keep these"},{"line_number":11,"context_line":"redundant rules in files. \u0027oslopolicy-list-redundant\u0027 tool"},{"line_number":12,"context_line":"is to detects such rule but we can log warnings also for"},{"line_number":13,"context_line":"such rule to communicate it to deployerin strong way."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Partial implement blueprint policy-json-to-yaml"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_1c9f1eb4","line":13,"range":{"start_line":13,"start_character":31,"end_line":13,"end_character":41},"in_reply_to":"9f560f44_036fc827","updated":"2020-08-27 15:00:59.000000000","message":"Done","commit_id":"3606023c62fd1a82867032977e64283afa229159"}],"oslo_policy/policy.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"daf0553493ca52abeca2ac16f067e080192acf08","unresolved":false,"context_lines":[{"line_number":843,"context_line":"        if redundant_file_rules:"},{"line_number":844,"context_line":"            # NOTE(gmann): Log warning for redundant file rules which"},{"line_number":845,"context_line":"            # can be detected via \u0027oslopolicy-list-redundant\u0027 tool too."},{"line_number":846,"context_line":"            LOG.warning(\"Policy Rules %(names)s specified in policy files \""},{"line_number":847,"context_line":"                        \"are the same as the defaults provided by the \""},{"line_number":848,"context_line":"                        \"service. You can remove these rules from policy \""},{"line_number":849,"context_line":"                        \"files which will make maintenance easier. You can \""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_23fbec46","line":846,"range":{"start_line":846,"start_character":12,"end_line":846,"end_character":24},"updated":"2020-08-27 08:36:35.000000000","message":"Is warning a bit much? My understanding of warning was that it\u0027s something that can set off a pager for an operator. Would \u0027info\u0027 be more appropriate?\n\nAlso, any chance of dragging the content down a line and recovering some indentation?\n\n  LOG.info(\n      \"Policy Rules %(names)s specified in policy files \"\n      ...)","commit_id":"3606023c62fd1a82867032977e64283afa229159"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"422ebb9444cdf9200f9537746d6834dfcc588549","unresolved":false,"context_lines":[{"line_number":843,"context_line":"        if redundant_file_rules:"},{"line_number":844,"context_line":"            # NOTE(gmann): Log warning for redundant file rules which"},{"line_number":845,"context_line":"            # can be detected via \u0027oslopolicy-list-redundant\u0027 tool too."},{"line_number":846,"context_line":"            LOG.warning(\"Policy Rules %(names)s specified in policy files \""},{"line_number":847,"context_line":"                        \"are the same as the defaults provided by the \""},{"line_number":848,"context_line":"                        \"service. You can remove these rules from policy \""},{"line_number":849,"context_line":"                        \"files which will make maintenance easier. You can \""}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_3cd30262","line":846,"range":{"start_line":846,"start_character":12,"end_line":846,"end_character":24},"in_reply_to":"9f560f44_23fbec46","updated":"2020-08-27 15:00:59.000000000","message":"I am not sure info are being read in actionable way. I thought of doing it as warning to get more attention and a strong recommendation of not keeping defaults rule in file which is what our policy-in-code concept was. This can help to avoid any issues like we faced during scope implementation.","commit_id":"3606023c62fd1a82867032977e64283afa229159"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"daf0553493ca52abeca2ac16f067e080192acf08","unresolved":false,"context_lines":[{"line_number":848,"context_line":"                        \"service. You can remove these rules from policy \""},{"line_number":849,"context_line":"                        \"files which will make maintenance easier. You can \""},{"line_number":850,"context_line":"                        \"detect these redundant rules by \""},{"line_number":851,"context_line":"                        \"``oslopolicy-list-redundant`` tool also: \""},{"line_number":852,"context_line":"                        \"https://docs.openstack.org/oslo.policy/\""},{"line_number":853,"context_line":"                        \"latest/cli/oslopolicy-list-redundant.html.\","},{"line_number":854,"context_line":"                        {\u0027names\u0027: redundant_file_rules})"},{"line_number":855,"context_line":""},{"line_number":856,"context_line":"    def _load_policy_file(self, path, force_reload, overwrite\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_23900ced","line":853,"range":{"start_line":851,"start_character":64,"end_line":853,"end_character":68},"updated":"2020-08-27 08:36:35.000000000","message":"I think this is unnecessary. They can find these docs simply by googling the tool name. The tool should also be available from the command line and has help text.","commit_id":"3606023c62fd1a82867032977e64283afa229159"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"422ebb9444cdf9200f9537746d6834dfcc588549","unresolved":false,"context_lines":[{"line_number":848,"context_line":"                        \"service. You can remove these rules from policy \""},{"line_number":849,"context_line":"                        \"files which will make maintenance easier. You can \""},{"line_number":850,"context_line":"                        \"detect these redundant rules by \""},{"line_number":851,"context_line":"                        \"``oslopolicy-list-redundant`` tool also: \""},{"line_number":852,"context_line":"                        \"https://docs.openstack.org/oslo.policy/\""},{"line_number":853,"context_line":"                        \"latest/cli/oslopolicy-list-redundant.html.\","},{"line_number":854,"context_line":"                        {\u0027names\u0027: redundant_file_rules})"},{"line_number":855,"context_line":""},{"line_number":856,"context_line":"    def _load_policy_file(self, path, force_reload, overwrite\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_5ca51602","line":853,"range":{"start_line":851,"start_character":64,"end_line":853,"end_character":68},"in_reply_to":"9f560f44_23900ced","updated":"2020-08-27 15:00:59.000000000","message":"ok, done","commit_id":"3606023c62fd1a82867032977e64283afa229159"}]}