)]}'
{"lower-constraints.txt":[{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"7a09db8529385cf14dd912c7e89adb0d2500f90f","unresolved":false,"context_lines":[{"line_number":21,"context_line":"netaddr\u003d\u003d0.7.18"},{"line_number":22,"context_line":"netifaces\u003d\u003d0.10.4"},{"line_number":23,"context_line":"os-client-config\u003d\u003d1.28.0"},{"line_number":24,"context_line":"oslo.config\u003d\u003d6.0.0"},{"line_number":25,"context_line":"oslo.context\u003d\u003d2.22.0"},{"line_number":26,"context_line":"oslo.i18n\u003d\u003d3.15.3"},{"line_number":27,"context_line":"oslo.serialization\u003d\u003d2.18.0"}],"source_content_type":"text/plain","patch_set":2,"id":"fffc6b78_be0ebe2f","line":24,"updated":"2020-11-19 16:20:43.000000000","message":"Any reason to include the version change on this commit, or can it be separate?","commit_id":"d69c8421a7949e428d207c51896c12a06d735ce7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"18aa26c928652394c076f3d39afbfc0d17325e74","unresolved":false,"context_lines":[{"line_number":21,"context_line":"netaddr\u003d\u003d0.7.18"},{"line_number":22,"context_line":"netifaces\u003d\u003d0.10.4"},{"line_number":23,"context_line":"os-client-config\u003d\u003d1.28.0"},{"line_number":24,"context_line":"oslo.config\u003d\u003d6.0.0"},{"line_number":25,"context_line":"oslo.context\u003d\u003d2.22.0"},{"line_number":26,"context_line":"oslo.i18n\u003d\u003d3.15.3"},{"line_number":27,"context_line":"oslo.serialization\u003d\u003d2.18.0"}],"source_content_type":"text/plain","patch_set":2,"id":"fffc6b78_de3f42b3","line":24,"in_reply_to":"fffc6b78_be0ebe2f","updated":"2020-11-19 16:26:13.000000000","message":"that is needed for cfg.get_location function used in this code which is there from 6.0.0. onwards","commit_id":"d69c8421a7949e428d207c51896c12a06d735ce7"}],"oslo_policy/policy.py":[{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"7920304ab3d841328eb5f60e06fd75b6655d96de","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        super(InvalidContextObject, self).__init__(msg)"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"def pick_default_policy_file(conf, fallback_to_json_file\u003dTrue):"},{"line_number":364,"context_line":"    # TODO(gmann): If service changed the default value of"},{"line_number":365,"context_line":"    # CONF.oslo_policy.policy_file option to \u0027policy.yaml\u0027 then to avoid"},{"line_number":366,"context_line":"    # breaking any deployment relying on default value, we need to add"}],"source_content_type":"text/x-python","patch_set":3,"id":"fffc6b78_b62c1748","line":363,"updated":"2020-11-20 14:50:23.000000000","message":"Concerned that the logic here is going to mess people up.  I think that the oslo.conf logic does not distinguish between the default value and an explicit value.  If there is an explicit value for the new file, but the old (json) file is still in place, I think it will silently grab the old file.  \n\nI think there needs to be logging when it is overriding the default behavior prominent in the log.\n\nIt might be better to just break at this point then to fail in the wrong way.","commit_id":"5180e9674f30a44a530deeabbc02804bec66351d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7395874419adda3680b766cdfea882708d2c464e","unresolved":false,"context_lines":[{"line_number":360,"context_line":"        super(InvalidContextObject, self).__init__(msg)"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"def pick_default_policy_file(conf, fallback_to_json_file\u003dTrue):"},{"line_number":364,"context_line":"    # TODO(gmann): If service changed the default value of"},{"line_number":365,"context_line":"    # CONF.oslo_policy.policy_file option to \u0027policy.yaml\u0027 then to avoid"},{"line_number":366,"context_line":"    # breaking any deployment relying on default value, we need to add"}],"source_content_type":"text/x-python","patch_set":3,"id":"a21b261b_a9e0ad57","line":363,"in_reply_to":"fffc6b78_b62c1748","updated":"2020-11-22 23:53:07.000000000","message":"No, old json file would not be picked. That is taken care by if condition at L373 and L376. Also verified by test - https://review.opendev.org/c/openstack/oslo.policy/+/763261/3/oslo_policy/tests/test_policy.py#1969\n\nIf conf.oslo_policy.policy_file is overridden with\n-  any value other than \u0027policy.yaml\u0027 then this logic does not do anything and it return the overridden value from L383.\n- \u0027policy.yaml\u0027 itself then L376 check the file existence and return the overridden yaml file.\n\nIn both cases, json file is not picked. json file will only be picked if 1. service change the default of  conf.oslo_policy.policy_file from \u0027policy.json\u0027 to \u0027policy.yaml\u0027 and deployment still rely on old policy.json then we do not break those deployment and pick old json file for them.","commit_id":"5180e9674f30a44a530deeabbc02804bec66351d"}]}