)]}'
{"oslo_policy/policy.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"637f2abe812967cae7d69983e3b1495b166871b5","unresolved":true,"context_lines":[{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    new_default_policy_file \u003d \u0027policy.yaml\u0027"},{"line_number":372,"context_line":"    old_default_policy_file \u003d \u0027policy.json\u0027"},{"line_number":373,"context_line":"    pick_policy_file \u003d conf.oslo_policy.policy_file"},{"line_number":374,"context_line":"    if ((conf.oslo_policy.policy_file \u003d\u003d new_default_policy_file) and"},{"line_number":375,"context_line":"            fallback_to_json_file):"},{"line_number":376,"context_line":"        location \u003d conf.get_location(\u0027policy_file\u0027, \u0027oslo_policy\u0027).location"}],"source_content_type":"text/x-python","patch_set":1,"id":"22566888_d0b0267f","line":373,"range":{"start_line":373,"start_character":4,"end_line":373,"end_character":20},"updated":"2021-01-28 16:32:11.000000000","message":"maybe just \u0027policy_file\u0027?","commit_id":"dcc5488631922eac02fbbdd5888b91af47f04fad"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"637f2abe812967cae7d69983e3b1495b166871b5","unresolved":true,"context_lines":[{"line_number":379,"context_line":"        elif location in [cfg.Locations.opt_default,"},{"line_number":380,"context_line":"                          cfg.Locations.set_default]:"},{"line_number":381,"context_line":"                        LOG.debug(\u0027Picking policy file: %s\u0027,"},{"line_number":382,"context_line":"                      conf.oslo_policy.policy_file)"},{"line_number":383,"context_line":"            if conf.find_file(old_default_policy_file):"},{"line_number":384,"context_line":"                pick_policy_file \u003d old_default_policy_file"},{"line_number":385,"context_line":"        LOG.debug(\u0027Picking policy file: %s. Config location: %s\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"43fcf49a_c153d242","line":382,"updated":"2021-01-28 16:32:11.000000000","message":"This is incorrectly indented and not needed anyway, right?","commit_id":"dcc5488631922eac02fbbdd5888b91af47f04fad"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"22dff840dc9ccb6af3e6f653f7742c9af0c41399","unresolved":true,"context_lines":[{"line_number":379,"context_line":"        elif location in [cfg.Locations.opt_default,"},{"line_number":380,"context_line":"                          cfg.Locations.set_default]:"},{"line_number":381,"context_line":"                        LOG.debug(\u0027Picking policy file: %s\u0027,"},{"line_number":382,"context_line":"                      conf.oslo_policy.policy_file)"},{"line_number":383,"context_line":"            if conf.find_file(old_default_policy_file):"},{"line_number":384,"context_line":"                pick_policy_file \u003d old_default_policy_file"},{"line_number":385,"context_line":"        LOG.debug(\u0027Picking policy file: %s. Config location: %s\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7b032f40_682a88b0","line":382,"in_reply_to":"43fcf49a_c153d242","updated":"2021-01-28 16:53:16.000000000","message":"oh i meant to remove it after i move log @L385","commit_id":"dcc5488631922eac02fbbdd5888b91af47f04fad"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"637f2abe812967cae7d69983e3b1495b166871b5","unresolved":true,"context_lines":[{"line_number":382,"context_line":"                      conf.oslo_policy.policy_file)"},{"line_number":383,"context_line":"            if conf.find_file(old_default_policy_file):"},{"line_number":384,"context_line":"                pick_policy_file \u003d old_default_policy_file"},{"line_number":385,"context_line":"        LOG.debug(\u0027Picking policy file: %s. Config location: %s\u0027,"},{"line_number":386,"context_line":"                  pick_policy_file, location)"},{"line_number":387,"context_line":"    # Return overridden policy file"},{"line_number":388,"context_line":"    return pick_policy_file"}],"source_content_type":"text/x-python","patch_set":1,"id":"927fd23a_9882ee5b","line":385,"range":{"start_line":385,"start_character":18,"end_line":385,"end_character":19},"updated":"2021-01-28 16:32:11.000000000","message":"Can we avoid the huge hanging indent here and above?\n\n  LOG.debug(\n      \u0027Picking policy file: %s, config location: %s\u0027,\n      pick_policy_file, location)]\n\nAlso, shouldn\u0027t think be dedented to log for all cases, including when we don\u0027t enter the main if-block? Alternatively, we might want a separate log saying we\u0027re using the default?","commit_id":"dcc5488631922eac02fbbdd5888b91af47f04fad"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"22dff840dc9ccb6af3e6f653f7742c9af0c41399","unresolved":true,"context_lines":[{"line_number":382,"context_line":"                      conf.oslo_policy.policy_file)"},{"line_number":383,"context_line":"            if conf.find_file(old_default_policy_file):"},{"line_number":384,"context_line":"                pick_policy_file \u003d old_default_policy_file"},{"line_number":385,"context_line":"        LOG.debug(\u0027Picking policy file: %s. Config location: %s\u0027,"},{"line_number":386,"context_line":"                  pick_policy_file, location)"},{"line_number":387,"context_line":"    # Return overridden policy file"},{"line_number":388,"context_line":"    return pick_policy_file"}],"source_content_type":"text/x-python","patch_set":1,"id":"2520976f_a0e08cf0","line":385,"range":{"start_line":385,"start_character":18,"end_line":385,"end_character":19},"in_reply_to":"927fd23a_9882ee5b","updated":"2021-01-28 16:53:16.000000000","message":"sure. we can add that for default case also.","commit_id":"dcc5488631922eac02fbbdd5888b91af47f04fad"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"570d52680a16c99bfaeb02fd83e45619893dcbcf","unresolved":true,"context_lines":[{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    new_default_policy_file \u003d \u0027policy.yaml\u0027"},{"line_number":372,"context_line":"    old_default_policy_file \u003d \u0027policy.json\u0027"},{"line_number":373,"context_line":"    policy_file \u003d None"},{"line_number":374,"context_line":"    if ((conf.oslo_policy.policy_file \u003d\u003d new_default_policy_file) and"},{"line_number":375,"context_line":"            fallback_to_json_file):"},{"line_number":376,"context_line":"        location \u003d conf.get_location(\u0027policy_file\u0027, \u0027oslo_policy\u0027).location"}],"source_content_type":"text/x-python","patch_set":4,"id":"4a25d7af_024a24fd","line":373,"updated":"2021-01-29 14:53:07.000000000","message":"nit: this could inside the first if since it\u0027s not used outside that scope","commit_id":"b7489eb75a9bde1c1fd36e5e1e547bf60b7bc189"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"570d52680a16c99bfaeb02fd83e45619893dcbcf","unresolved":true,"context_lines":[{"line_number":388,"context_line":"            return policy_file"},{"line_number":389,"context_line":"    LOG.debug("},{"line_number":390,"context_line":"        \u0027No default policy file present, picking the configured \u0027"},{"line_number":391,"context_line":"        \u0027one: %s.\u0027, conf.oslo_policy.policy_file)"},{"line_number":392,"context_line":"    # Return overridden policy file"},{"line_number":393,"context_line":"    return conf.oslo_policy.policy_file"},{"line_number":394,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3af11897_2451c213","line":391,"updated":"2021-01-29 14:53:07.000000000","message":"nit: The entire string would fit on the above line","commit_id":"b7489eb75a9bde1c1fd36e5e1e547bf60b7bc189"}]}