)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0e5c62f07dbf31615ab7f7f6dc4c72990915469e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bd2b0370_de2684e0","updated":"2021-10-12 14:17:13.000000000","message":"This looks like a clean backport, however, it wasn\u0027t cherry-picked from the stable/xena change. Can you update this, including the cherry picked from line, to ensure this is applied to all branches in the correct order","commit_id":"07ac80eff1fc6b62d3fa6a01ee42881f383bfb64"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"96cfb0de655da4470be6c9ffa6873dbdba42df1c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c4136a43_8b62941b","updated":"2022-01-11 15:42:51.000000000","message":"Bah, reading comprehension fail. There are multiple places in the review that show this is a backport. :-)","commit_id":"639b47198b3334c33f4675a9210c31922c50be52"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"0815861928cecd1aa98642069e8b1fde369b9566","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0a7d8d82_fbc912ed","updated":"2022-01-07 18:04:28.000000000","message":"Bumping this as it\u0027s blocking a designate fix.","commit_id":"639b47198b3334c33f4675a9210c31922c50be52"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"5d1758e0e38a7c3944c24b4e1a7eed3249091914","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"96f1c3ef_7a06d1f0","updated":"2022-01-10 15:18:44.000000000","message":"Good to merge for me.","commit_id":"639b47198b3334c33f4675a9210c31922c50be52"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"af042c1479dc20d80c78349758c2fad98281da7e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bdde672c_2f259572","updated":"2022-01-11 10:02:40.000000000","message":"Like explained Michael it\u0027s a backport and it\u0027s already merged. I think we can merge it too.","commit_id":"639b47198b3334c33f4675a9210c31922c50be52"}],"oslo_policy/tests/test_policy.py":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"bc2eeb40c64ca0bec612e341a1fbf1316c3c15b5","unresolved":true,"context_lines":[{"line_number":882,"context_line":"            self.assertEqual(expected_creds[k], creds[k])"},{"line_number":883,"context_line":""},{"line_number":884,"context_line":"    @mock.patch(\u0027warnings.warn\u0027, new\u003dmock.Mock())"},{"line_number":885,"context_line":"    def test_map_context_attributes_populated_system(self):"},{"line_number":886,"context_line":"        request_context \u003d context.RequestContext(system_scope\u003d\u0027all\u0027)"},{"line_number":887,"context_line":"        expected_creds \u003d request_context.to_policy_values()"},{"line_number":888,"context_line":"        expected_creds[\u0027system\u0027] \u003d \u0027all\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"32515153_0ae92fe1","side":"PARENT","line":885,"updated":"2022-01-10 15:49:45.000000000","message":"Do we still have a test somewhere that verifies this works correctly with a RequestContext? It looks like this got replaced with one that only passes a dict.","commit_id":"4fe282b727d69b9ea3e668e7ab17fe330555c710"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c79dca99afecbeb38710dc38d67d1c479ad460eb","unresolved":true,"context_lines":[{"line_number":882,"context_line":"            self.assertEqual(expected_creds[k], creds[k])"},{"line_number":883,"context_line":""},{"line_number":884,"context_line":"    @mock.patch(\u0027warnings.warn\u0027, new\u003dmock.Mock())"},{"line_number":885,"context_line":"    def test_map_context_attributes_populated_system(self):"},{"line_number":886,"context_line":"        request_context \u003d context.RequestContext(system_scope\u003d\u0027all\u0027)"},{"line_number":887,"context_line":"        expected_creds \u003d request_context.to_policy_values()"},{"line_number":888,"context_line":"        expected_creds[\u0027system\u0027] \u003d \u0027all\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"2ede8353_918b4931","side":"PARENT","line":885,"in_reply_to":"32515153_0ae92fe1","updated":"2022-01-10 18:58:00.000000000","message":"FYI, this is a backport patch of an already merged patch. Any changes would have to be follow up patches.\n\nYes, all of the other tests here use a RequestContext.\nThis test was removed as system is not converted in the _map_context_attribute_into_creds method any longer, it now runs outside of that method such that it will apply to both the dict and RequestContext forms.\nThe new test now covers that combined path.","commit_id":"4fe282b727d69b9ea3e668e7ab17fe330555c710"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"bc2eeb40c64ca0bec612e341a1fbf1316c3c15b5","unresolved":true,"context_lines":[{"line_number":913,"context_line":"        creds[\u0027system_scope\u0027] \u003d \u0027all\u0027"},{"line_number":914,"context_line":""},{"line_number":915,"context_line":"        target_dict \u003d {}"},{"line_number":916,"context_line":"        self.enforcer.enforce(\u0027fake_rule\u0027, target_dict, creds)"},{"line_number":917,"context_line":""},{"line_number":918,"context_line":"    def test_enforcer_raises_invalid_scope_with_system_scope_type(self):"},{"line_number":919,"context_line":"        self.conf.set_override(\u0027enforce_scope\u0027, True, group\u003d\u0027oslo_policy\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"63bfd30e_5277cb15","line":916,"updated":"2022-01-10 15:49:45.000000000","message":"Should we be asserting that the creds were modified correctly after this? Or will enforce fail if that doesn\u0027t happen?","commit_id":"639b47198b3334c33f4675a9210c31922c50be52"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c79dca99afecbeb38710dc38d67d1c479ad460eb","unresolved":true,"context_lines":[{"line_number":913,"context_line":"        creds[\u0027system_scope\u0027] \u003d \u0027all\u0027"},{"line_number":914,"context_line":""},{"line_number":915,"context_line":"        target_dict \u003d {}"},{"line_number":916,"context_line":"        self.enforcer.enforce(\u0027fake_rule\u0027, target_dict, creds)"},{"line_number":917,"context_line":""},{"line_number":918,"context_line":"    def test_enforcer_raises_invalid_scope_with_system_scope_type(self):"},{"line_number":919,"context_line":"        self.conf.set_override(\u0027enforce_scope\u0027, True, group\u003d\u0027oslo_policy\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ace01b55_a351bb29","line":916,"in_reply_to":"63bfd30e_5277cb15","updated":"2022-01-10 18:58:00.000000000","message":"Enforce will fail as the rule on line 907 requires a system scope.","commit_id":"639b47198b3334c33f4675a9210c31922c50be52"}]}