)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5c86d34b72649dc5d8f4ab2ad791f38549a7c2db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e25cec9c_4d673513","updated":"2022-02-22 19:26:22.000000000","message":"Greetings! I am adding reviewers on this patch which is the result of discussing a confusing topic, rendered example policy output, with Arne. The net result of it is that the policy generation output was clearly wrong and confusing such that we both felt it needed to be fixed and clarified.\n\nI realize this likely should have been two patches, but this is an intertwined issue and I doubt we will ever attempt to backport this sort of change. Even then, it is relatively non-invasive, except for the default behavior change of creating a working alias, which can cause havoc with operators attempting to generate policy files to override the operational defaults.","commit_id":"b67e3c71a042719a6814621dd1c00c2e1818d2b1"},{"author":{"_account_id":11292,"name":"Arne Wiebalck","email":"Arne.Wiebalck@cern.ch","username":"wiebalck"},"change_message_id":"eb5afa15b06a540dd26a0655bb2da489f54a4fee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b3253b62_f3aa5f4a","updated":"2022-02-23 07:37:31.000000000","message":"I did some tests with the patch:\n- it comments the deprecated rules (therefore addresses Thomas\u0027 bug)\n- leaves a clearer message for deprecated rules\n- suppresses deprecated rules in the sample file when requested\n\nLGTM!","commit_id":"b67e3c71a042719a6814621dd1c00c2e1818d2b1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d9a13822634e0ef51fb4ea0eed281876e0a711f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6ccc5692_2666a2df","updated":"2022-03-22 12:26:35.000000000","message":"Nice work here","commit_id":"b67e3c71a042719a6814621dd1c00c2e1818d2b1"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c84de1f43056d5b8963e8aba83612ee5664ef1ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bbaf3be4_b0aab956","updated":"2022-04-28 09:27:28.000000000","message":"Thanks Herve for looking into this. See my reply inline.","commit_id":"b67e3c71a042719a6814621dd1c00c2e1818d2b1"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b34421a2775929dfafd52420485182f107d6b7cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"97c197e8_937cec8d","updated":"2022-04-28 07:05:27.000000000","message":"This is failing glance docs job due to the new config option \"exclude-deprecated\" being a bool\n\n2022-04-28 05:17:00.860334 | ubuntu-focal | Handler \u003cfunction generate_sample at 0x7f27a0aedb80\u003e for event \u0027builder-inited\u0027 threw an exception (exception: \u0027bool\u0027 object has no attribute \u0027startswith\u0027)\n","commit_id":"b67e3c71a042719a6814621dd1c00c2e1818d2b1"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c84de1f43056d5b8963e8aba83612ee5664ef1ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cea33c8b_f7608854","in_reply_to":"3debfb4f_dff1fc5b","updated":"2022-04-28 09:27:28.000000000","message":"The problem faced in oslo.config is while parsing the arguments i.e. [... ,\"--exclude-deprecated\", False] where False is boolean and it isn\u0027t handled in oslo.config as well as in argparse. I\u0027ve proposed a possible fix for this issue if you would like to take a look. I\u0027ve also explained in the commit mesage, the problem faced at oslo.config end.\n\nhttps://review.opendev.org/c/openstack/oslo.policy/+/839711","commit_id":"b67e3c71a042719a6814621dd1c00c2e1818d2b1"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"ec9f8c6efea8c94a1524826fd36b77962d473ab8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3debfb4f_dff1fc5b","in_reply_to":"97c197e8_937cec8d","updated":"2022-04-28 09:17:09.000000000","message":"After investigating a bit this error seems on the oslo.config side and indeed triggered by this new option.\nIn glance you see this error because the oslo.policy.sphinxpolicygen is loaded in your doc config [1]. From this point your doc building process will try to generate a sample config by calling the oslo.policy.generator.generate_sample method [2] where it will fail to build the config [3] with this new option. I\u0027m now at this point and the execution seems to fail on the oslo.config side.\n\nI don\u0027t know yet why this new option is a problem for oslo.config.\n\n[1] https://opendev.org/openstack/glance/src/branch/master/doc/source/conf.py#L36\n[2] https://opendev.org/openstack/oslo.policy/src/branch/master/oslo_policy/generator.py#L539\n[3] https://opendev.org/openstack/oslo.policy/src/branch/master/oslo_policy/generator.py#L546","commit_id":"b67e3c71a042719a6814621dd1c00c2e1818d2b1"}],"releasenotes/notes/fix-deprecated-rule-handling-c6fe321fce6293a9.yaml":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f0132602becd6b637b022ba8568426e3a56f7ac5","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    attempting to evaluate the output to determine if customized rules were"},{"line_number":8,"context_line":"    required, as the aliases were always added as active rules. A warning"},{"line_number":9,"context_line":"    is now also added to the generated output."},{"line_number":10,"context_line":"    For more information, please see `launchpad bug #1945336 \u003chttps://bugs.launchpad.net/oslo.policy/+bug/1945336\u003e`_."},{"line_number":11,"context_line":"features:"},{"line_number":12,"context_line":"  - Adds the ability to exclude deprecated policies from generated samples by"},{"line_number":13,"context_line":"    utilizing the ``--exclude-deprecated`` setting when generating YAML"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1b2d408d_f11081a7","line":10,"updated":"2022-02-24 17:03:08.000000000","message":"Related context\n\nhttps://bugs.launchpad.net/oslo.policy/+bug/1742569","commit_id":"b67e3c71a042719a6814621dd1c00c2e1818d2b1"}]}