)]}'
{"id":"openstack%2Foslo.privsep~471521","triplet_id":"openstack%2Foslo.privsep~master~If7d076a6f1f4e79846619e21cc9cda61c319d5e5","project":"openstack/oslo.privsep","branch":"master","topic":"assertEqual","hashtags":[],"change_id":"If7d076a6f1f4e79846619e21cc9cda61c319d5e5","subject":"Use assertIsNone instead of assertEqual(None, ***)","status":"ABANDONED","created":"2017-06-07 00:50:54.000000000","updated":"2019-12-20 08:50:46.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"cd17f37dac0e7c02595b93e6647aac1e8139437c","_number":471521,"virtual_id_number":471521,"owner":{"_account_id":25073,"name":"Lingyong Xu","email":"lyxu@fiberhome.com","username":"lyxu"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"date":"2019-12-19 17:40:20.000000000","_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":25720,"name":"Ngo Quoc Cuong","email":"cuongngo.ict@gmail.com","username":"cuongnq"},{"date":"2019-12-20 08:46:15.000000000","_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"tag":"autogenerated:zuul:check","value":1,"date":"2019-12-18 13:33:34.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2019-12-18 11:41:44.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":1,"date":"2019-12-18 11:41:40.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":25720,"name":"Ngo Quoc Cuong","email":"cuongngo.ict@gmail.com","username":"cuongnq"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2019-12-18 11:41:40.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":25720,"name":"Ngo Quoc Cuong","email":"cuongngo.ict@gmail.com","username":"cuongnq"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":25720,"name":"Ngo Quoc Cuong","email":"cuongngo.ict@gmail.com","username":"cuongnq"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":25720,"name":"Ngo Quoc Cuong","email":"cuongngo.ict@gmail.com","username":"cuongnq"},{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-06-07 02:14:04.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-07-04 10:22:31.000000000","updated_by":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"reviewer":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"state":"REVIEWER"},{"updated":"2017-07-19 04:04:48.000000000","updated_by":{"_account_id":25720,"name":"Ngo Quoc Cuong","email":"cuongngo.ict@gmail.com","username":"cuongnq"},"reviewer":{"_account_id":25720,"name":"Ngo Quoc Cuong","email":"cuongngo.ict@gmail.com","username":"cuongnq"},"state":"REVIEWER"},{"updated":"2019-12-18 11:41:44.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2019-12-18 13:33:34.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-12-19 17:40:20.000000000","updated_by":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"reviewer":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"state":"REVIEWER"},{"updated":"2019-12-20 08:46:15.000000000","updated_by":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"reviewer":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"state":"REVIEWER"}],"messages":[{"id":"7d5dc53881a164cb6be03d62bbc3d755d26ed65d","author":{"_account_id":25073,"name":"Lingyong Xu","email":"lyxu@fiberhome.com","username":"lyxu"},"date":"2017-06-07 00:50:54.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3b766d3dd313e01fbf72bc1589a23abf0503abc7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-07 02:14:04.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-oslo.privsep-docs-ubuntu-xenial http://docs-draft.openstack.org/21/471521/1/check/gate-oslo.privsep-docs-ubuntu-xenial/b526e9a//doc/build/html/ : SUCCESS in 2m 04s\n- gate-oslo.privsep-pep8-ubuntu-xenial http://logs.openstack.org/21/471521/1/check/gate-oslo.privsep-pep8-ubuntu-xenial/1fe0a44/ : SUCCESS in 1m 55s\n- gate-oslo.privsep-python27-ubuntu-xenial http://logs.openstack.org/21/471521/1/check/gate-oslo.privsep-python27-ubuntu-xenial/bd94de7/ : SUCCESS in 3m 33s\n- gate-oslo.privsep-python35 http://logs.openstack.org/21/471521/1/check/gate-oslo.privsep-python35/275d4e7/ : SUCCESS in 2m 46s\n- gate-tempest-dsvm-neutron-src-oslo.privsep-ubuntu-xenial http://logs.openstack.org/21/471521/1/check/gate-tempest-dsvm-neutron-src-oslo.privsep-ubuntu-xenial/b0c9e91/ : SUCCESS in 1h 19m 48s","accounts_in_message":[],"_revision_number":1},{"id":"1b012bf84e38e613a26f68f0709a7bb1aec43c32","author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"date":"2017-07-04 10:22:31.000000000","message":"Patch Set 1: Code-Review-1\n\nCould you please add this to hacking?","accounts_in_message":[],"_revision_number":1},{"id":"cd8437ac3c6016a1262e171837863ea96f7f65d8","author":{"_account_id":25720,"name":"Ngo Quoc Cuong","email":"cuongngo.ict@gmail.com","username":"cuongnq"},"date":"2017-07-19 04:03:26.000000000","message":"Patch Set 1: Code-Review-1\n\nI have a simpler solution than Tuan\u0027s suggestion, that is enable H203\n\nhttps://github.com/openstack/kiloeyes/blob/master/tox.ini#L43\n\nSee:\nhttps://review.openstack.org/#/c/481698/3/tox.ini","accounts_in_message":[],"_revision_number":1},{"id":"19aac88162fb7f599bb45f8f120900f8265b43be","author":{"_account_id":25720,"name":"Ngo Quoc Cuong","email":"cuongngo.ict@gmail.com","username":"cuongnq"},"date":"2017-07-19 04:04:48.000000000","message":"Patch Set 1: Code-Review+1\n\nI\u0027m sorry, H203 is already enabled\n\nhttps://github.com/openstack/oslo.privsep/blob/master/tox.ini#L37","accounts_in_message":[],"_revision_number":1},{"id":"3ed08ce742ce60a633886169fdd18e7619cd180b","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-12-18 11:41:40.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"a548b958651fb7791546e2c6384b6759b022cb3b","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2019-12-18 11:41:44.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"6f3bd0570760f8cc3b9c8b5926aa8f314273aa68","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-12-18 13:33:34.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full https://zuul.opendev.org/t/openstack/build/d6f315c6ad864a2c8f4968ae8f4ef192 : SUCCESS in 1h 40m 38s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/2cbcb318dc00430ba38daff3fdb12854 : SUCCESS in 1h 34m 37s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/62809d06e4814de8b61be159b941216e : SUCCESS in 4m 36s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/41adefcd4c854182b8d66d5bbad53095 : SUCCESS in 4m 09s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/96535a1aea814f6fa466d81b4fc00c9d : SUCCESS in 3m 32s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/536e4db3b7d344169f69b93b7d63e508 : SUCCESS in 3m 19s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/e5204b9f0f3f40eba01886f895cf8309 : SUCCESS in 5m 43s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0564782a4f0c4306b8199eb11122ad53 : SUCCESS in 4m 00s","accounts_in_message":[],"_revision_number":2},{"id":"e5b60643316068bb066c9411011c5bd6bac5004a","author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"date":"2019-12-19 17:40:20.000000000","message":"Patch Set 2:\n\nI\u0027m seeing no changes except the commit message here. Maybe this already merged elsewhere?","accounts_in_message":[],"_revision_number":2},{"id":"4e24a77d85eb730d16c1c6360f719c08e577585c","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2019-12-20 08:46:15.000000000","message":"Patch Set 2:\n\n\u003e I\u0027m seeing no changes except the commit message here. Maybe this\n \u003e already merged elsewhere?\n\nHum weird me too...\n\nLooks like related to https://github.com/openstack/oslo.privsep/commit/0cc0f2cd991d17f4d9e79d96226398394ae5854a\n\nBut this was merged almost 2 years ago...","accounts_in_message":[],"_revision_number":2},{"id":"53bbf6baf9b664ffc95d2f9dfa7f39fb981bfb82","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2019-12-20 08:50:46.000000000","message":"Abandoned\n\nThis patch doesn\u0027t contains any changes, it seems related to:\n- https://review.opendev.org/#/c/470792/\n- https://github.com/openstack/oslo.privsep/commit/0cc0f2cd991d17f4d9e79d96226398394ae5854a\n\nI abandon these changes feel free to reopen this review if needed.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"554bbb59e4bce24aa7db4f4ed6548fb78e089c33","revisions":{"a5d0609d1ba29c8d3d8396b656c8031e692c00e7":{"kind":"REWORK","_number":1,"created":"2017-06-07 00:50:54.000000000","uploader":{"_account_id":25073,"name":"Lingyong Xu","email":"lyxu@fiberhome.com","username":"lyxu"},"ref":"refs/changes/21/471521/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.privsep","ref":"refs/changes/21/471521/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.privsep refs/changes/21/471521/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.privsep refs/changes/21/471521/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.privsep refs/changes/21/471521/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.privsep refs/changes/21/471521/1"}}},"commit":{"parents":[{"commit":"05c16b228a5ff3d9af6c4bbf93a2e870c477eb94","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.privsep/commit/05c16b228a5ff3d9af6c4bbf93a2e870c477eb94"}]}],"author":{"name":"lingyongxu","email":"lyxu@fiberhome.com","date":"2017-06-07 00:50:19.000000000","tz":480},"committer":{"name":"lingyongxu","email":"lyxu@fiberhome.com","date":"2017-06-07 00:50:58.000000000","tz":480},"subject":"Use assertIsNone instead of assertEqual(None, ***)","message":"Use assertIsNone instead of assertEqual(None, ***)\n\nFollowing OpenStack Style Guidelines: [1]\nUnit test assertions tend to give better messages for more\nspecific assertions. As a result, assertIsNone(xxx) is\npreferred over assertEqual(None, xxx) and assertIs(xxx, None)\n\n[1] http://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises\n\nChange-Id: If7d076a6f1f4e79846619e21cc9cda61c319d5e5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.privsep/commit/a5d0609d1ba29c8d3d8396b656c8031e692c00e7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.privsep/commit/a5d0609d1ba29c8d3d8396b656c8031e692c00e7"}]},"branch":"refs/heads/master"},"554bbb59e4bce24aa7db4f4ed6548fb78e089c33":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2019-12-18 11:41:40.000000000","uploader":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"ref":"refs/changes/21/471521/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.privsep","ref":"refs/changes/21/471521/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.privsep refs/changes/21/471521/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.privsep refs/changes/21/471521/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.privsep refs/changes/21/471521/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.privsep refs/changes/21/471521/2"}}},"commit":{"parents":[{"commit":"795dcbe4bf23249f8552e1b94aa49e98c60db90a","subject":"Merge \"Switch to Ussuri jobs\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.privsep/commit/795dcbe4bf23249f8552e1b94aa49e98c60db90a"}]}],"author":{"name":"lingyongxu","email":"lyxu@fiberhome.com","date":"2017-06-07 00:50:19.000000000","tz":480},"committer":{"name":"Stephen Finucane","email":"stephenfin@redhat.com","date":"2019-12-18 11:41:40.000000000","tz":0},"subject":"Use assertIsNone instead of assertEqual(None, ***)","message":"Use assertIsNone instead of assertEqual(None, ***)\n\nFollowing OpenStack Style Guidelines: [1]\nUnit test assertions tend to give better messages for more\nspecific assertions. As a result, assertIsNone(xxx) is\npreferred over assertEqual(None, xxx) and assertIs(xxx, None)\n\n[1] http://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises\n\nChange-Id: If7d076a6f1f4e79846619e21cc9cda61c319d5e5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.privsep/commit/554bbb59e4bce24aa7db4f4ed6548fb78e089c33"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.privsep/commit/554bbb59e4bce24aa7db4f4ed6548fb78e089c33"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}