)]}'
{"oslo_privsep/tests/test_daemon.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"79b250baac24aa3a92fc77e33bb9d859eee095b8","unresolved":false,"context_lines":[{"line_number":234,"context_line":""},{"line_number":235,"context_line":"            for name, green_mod in func_modules():"},{"line_number":236,"context_line":"                orig_mod \u003d eventlet.patcher.original(name)"},{"line_number":237,"context_line":"                patched_mod \u003d sys.modules.get(name)"},{"line_number":238,"context_line":"                for attr_name in green_mod.__patched__:"},{"line_number":239,"context_line":"                    un_monkey_patched_attr \u003d getattr(patched_mod, attr_name,"},{"line_number":240,"context_line":"                                                     None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_ee50e234","line":237,"updated":"2020-08-25 13:13:31.000000000","message":"pep8: F821 undefined name \u0027sys\u0027","commit_id":"8818218c502e64fa06f186ea862567f893fe234a"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"540b5513c40af3680dd359c9aeb3aab587c09f3e","unresolved":false,"context_lines":[{"line_number":240,"context_line":"                    un_monkey_patched_attr \u003d getattr(patched_mod, attr_name,"},{"line_number":241,"context_line":"                                                     None)"},{"line_number":242,"context_line":"                    original_attr \u003d getattr(orig_mod, attr_name, None)"},{"line_number":243,"context_line":"                    self.assertEqual(un_monkey_patched_attr, original_attr)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_3f25860b","line":243,"range":{"start_line":243,"start_character":20,"end_line":243,"end_character":75},"updated":"2020-08-31 14:37:51.000000000","message":"We have an issue with py27 here, with py38 the module socket.ssl return None for the original and for the un_monkey_patched attr so we don\u0027t fail here as None is equal to None, but with py27 we retrieved different method signatures for the ssl attr so this test fail.\n\nContexts examples:\n\nWith py38 `original_attr` is equal to `None` and `un_monkey_patched_attr` is equal to `None`. \n\nWith py27 `original_attr` is equal to `\u003cfunction ssl at 0x7f14cf3a96d0\u003e` and `un_monkey_patched_attr` is equal to `\u003cfunction ssl at 0x7f14ce2b2e50\u003e`. in py27 ssl exist within the socket module [1] and not within py38 [2].\n\nEither our unpatching doesn\u0027t work as expected with ssl and py27 or may we need to ignore some specific attributes with py27 in this test.\n\nAlways with the socket module, socketpair [3] and fromfd [4] are builtins with py27 and they are methods with py38.\n\nI suppose the ssl issue is due to the fact that eventlet is based on PyOpenSSL [5][6] to manage SSL.\n\nSSL is not our goal with this patch and we just want to unpatch things so I think we can ignore this module (exclude it from our tests), what do you think about this topic? \n\nLet\u0027s open a debate about this.\n\n[1] https://github.com/python/cpython/blob/2.7/Lib/socket.py#L52,L84\n[2] https://github.com/python/cpython/blob/3.8/Lib/socket.py\n[3] https://docs.python.org/2.7/library/socket.html#socket.socketpair\n[4] https://docs.python.org/2.7/library/socket.html#socket.fromfd\n[5] https://github.com/eventlet/eventlet/blob/af407c77f208ceefe5a35e39aed0cf3fdfc07cb9/eventlet/green/OpenSSL/SSL.py#L1,L2\n[6] https://eventlet.net/doc/ssl.html#pyopenssl","commit_id":"a9c26d55baa7163a2ce98f2abd7ba5cf5beff361"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5c281cfb58dfeb4091fed63b04d628a4f3aa8a3b","unresolved":false,"context_lines":[{"line_number":240,"context_line":"                    un_monkey_patched_attr \u003d getattr(patched_mod, attr_name,"},{"line_number":241,"context_line":"                                                     None)"},{"line_number":242,"context_line":"                    original_attr \u003d getattr(orig_mod, attr_name, None)"},{"line_number":243,"context_line":"                    self.assertEqual(un_monkey_patched_attr, original_attr)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_76e4c5a8","line":243,"range":{"start_line":243,"start_character":20,"end_line":243,"end_character":75},"in_reply_to":"9f560f44_3f25860b","updated":"2020-09-23 13:49:06.000000000","message":"As commented in IRC, I think we can maybe skip some library checks or create a list, per python version, of the libraries patched. That will truly check we are doing well here for py27.","commit_id":"a9c26d55baa7163a2ce98f2abd7ba5cf5beff361"}],"requirements.txt":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"fb047cfea8c9eb777c8ecd38688dacfb304f141b","unresolved":false,"context_lines":[{"line_number":8,"context_line":"oslo.utils\u003e\u003d3.33.0 # Apache-2.0"},{"line_number":9,"context_line":"enum34\u003e\u003d1.0.4;python_version\u003d\u003d\u00272.7\u0027 or python_version\u003d\u003d\u00272.6\u0027 or python_version\u003d\u003d\u00273.3\u0027 # BSD"},{"line_number":10,"context_line":"cffi\u003e\u003d1.7.0 # MIT"},{"line_number":11,"context_line":"eventlet\u003e\u003d0.21.0 # MIT"},{"line_number":12,"context_line":"greenlet\u003e\u003d0.4.14 # MIT"},{"line_number":13,"context_line":"msgpack\u003e\u003d0.6.0 # Apache-2.0"},{"line_number":14,"context_line":"futures\u003e\u003d3.1.1;python_version\u003d\u003d\u00272.7\u0027 or python_version\u003d\u003d\u00272.6\u0027 # PSF"}],"source_content_type":"text/plain","patch_set":4,"id":"9f560f44_1250795e","line":11,"updated":"2020-10-01 17:08:53.000000000","message":"I don\u0027t think we can bump minimum requirements on a stable branch. We probably need to discuss this with the stable and/or release teams.","commit_id":"a9c26d55baa7163a2ce98f2abd7ba5cf5beff361"}]}