)]}'
{"oslo_privsep/daemon.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f5d4a5fb60fdb68f8381a2f667d7efd61613e93a","unresolved":true,"context_lines":[{"line_number":204,"context_line":"            reply \u003d self.send_recv((Message.PING.value,))"},{"line_number":205,"context_line":"            success \u003d reply[0] \u003d\u003d Message.PONG"},{"line_number":206,"context_line":"        except Exception as e:"},{"line_number":207,"context_line":"            LOG.exception(\u0027Error while sending initial PING to privsep: %s\u0027, e)"},{"line_number":208,"context_line":"            success \u003d False"},{"line_number":209,"context_line":"        if not success:"},{"line_number":210,"context_line":"            msg \u003d _(\u0027Privsep daemon failed to start\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1c6ca611_d5eb345d","line":207,"updated":"2021-04-21 15:47:31.000000000","message":"Any reason none of these use the service-specific logger?","commit_id":"7ec4ec018a1d4ffda18b67f0377ad68d0de3fe07"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"d79af6484af496248d95a6d571e2b7c6a388d486","unresolved":true,"context_lines":[{"line_number":204,"context_line":"            reply \u003d self.send_recv((Message.PING.value,))"},{"line_number":205,"context_line":"            success \u003d reply[0] \u003d\u003d Message.PONG"},{"line_number":206,"context_line":"        except Exception as e:"},{"line_number":207,"context_line":"            LOG.exception(\u0027Error while sending initial PING to privsep: %s\u0027, e)"},{"line_number":208,"context_line":"            success \u003d False"},{"line_number":209,"context_line":"        if not success:"},{"line_number":210,"context_line":"            msg \u003d _(\u0027Privsep daemon failed to start\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"4d28d4ba_bdbb6196","line":207,"in_reply_to":"1c6ca611_d5eb345d","updated":"2021-05-11 10:20:25.000000000","message":"My reasoning at the time of writing the patch was to consider 2 type of logs:\n\n- Privsep operational logs\n- Logs from the code that the server has executed and have been sent as OOB messages\n\nAnd make the privsep logs use LOG and the server executed code use the specific logger.\n\nIn retrospective that seems like a crazy idea, so I\u0027ll change it.","commit_id":"7ec4ec018a1d4ffda18b67f0377ad68d0de3fe07"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"a6a6cdf69d14668f8403a3f872e6d7320aac0bdd","unresolved":true,"context_lines":[{"line_number":204,"context_line":"            reply \u003d self.send_recv((Message.PING.value,))"},{"line_number":205,"context_line":"            success \u003d reply[0] \u003d\u003d Message.PONG"},{"line_number":206,"context_line":"        except Exception as e:"},{"line_number":207,"context_line":"            LOG.exception(\u0027Error while sending initial PING to privsep: %s\u0027, e)"},{"line_number":208,"context_line":"            success \u003d False"},{"line_number":209,"context_line":"        if not success:"},{"line_number":210,"context_line":"            msg \u003d _(\u0027Privsep daemon failed to start\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"6d97fda7_6c9becf2","line":207,"in_reply_to":"4d28d4ba_bdbb6196","updated":"2021-06-09 12:48:01.000000000","message":"\u003e In retrospective that seems like a crazy idea, so I\u0027ll change it.\n\nCan we move this patch as WIP?","commit_id":"7ec4ec018a1d4ffda18b67f0377ad68d0de3fe07"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"80eb41737fe4a08804028f234046a5e14ed2c4bc","unresolved":true,"context_lines":[{"line_number":204,"context_line":"            reply \u003d self.send_recv((Message.PING.value,))"},{"line_number":205,"context_line":"            success \u003d reply[0] \u003d\u003d Message.PONG"},{"line_number":206,"context_line":"        except Exception as e:"},{"line_number":207,"context_line":"            LOG.exception(\u0027Error while sending initial PING to privsep: %s\u0027, e)"},{"line_number":208,"context_line":"            success \u003d False"},{"line_number":209,"context_line":"        if not success:"},{"line_number":210,"context_line":"            msg \u003d _(\u0027Privsep daemon failed to start\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"f7ac89d3_779bb10c","line":207,"in_reply_to":"6d97fda7_6c9becf2","updated":"2021-06-09 15:44:43.000000000","message":"Why? Patchset #5 implemented the service-specific logger, which seems like the reasonable approach.","commit_id":"7ec4ec018a1d4ffda18b67f0377ad68d0de3fe07"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"97016831355aae1cb0af7e2b120390f89603d0f2","unresolved":true,"context_lines":[{"line_number":204,"context_line":"            reply \u003d self.send_recv((Message.PING.value,))"},{"line_number":205,"context_line":"            success \u003d reply[0] \u003d\u003d Message.PONG"},{"line_number":206,"context_line":"        except Exception as e:"},{"line_number":207,"context_line":"            LOG.exception(\u0027Error while sending initial PING to privsep: %s\u0027, e)"},{"line_number":208,"context_line":"            success \u003d False"},{"line_number":209,"context_line":"        if not success:"},{"line_number":210,"context_line":"            msg \u003d _(\u0027Privsep daemon failed to start\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"aa9ea097_69c5ad31","line":207,"in_reply_to":"f7ac89d3_779bb10c","updated":"2021-06-21 15:25:37.000000000","message":"Ah yes sorry I missed that this comment was related to the PS4.","commit_id":"7ec4ec018a1d4ffda18b67f0377ad68d0de3fe07"}]}