)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"b06c732609e6642d084c1aae228ce79df459cfbb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"402b78c7_20150c94","updated":"2021-12-01 09:28:28.000000000","message":"I just bumped the limit to 100MiB which matches upstream in 1.0.0 (which is not included in the upper constraints for older releases of OpenStack that are still supported).","commit_id":"c223dbced7d5a8d1920fe764cbce42cf844538e1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"53b067a0185ee2ca72d84b9c926ad47369d20dd2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dcbf1302_9ea9b8b1","updated":"2022-03-22 12:33:26.000000000","message":"I posted a follow-up at [1]\n\n[1] https://review.opendev.org/c/openstack/oslo.privsep/+/834674","commit_id":"c223dbced7d5a8d1920fe764cbce42cf844538e1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3fc03dd2daf9c8513702bdf853911e2a254a31d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f7b49701_5a402fac","updated":"2021-12-21 11:10:16.000000000","message":"I\u0027d like a small note indicating why we do this, but I\u0027m okay doing that in a follow-up. Holding off on +W to make sure you see this 😊","commit_id":"c223dbced7d5a8d1920fe764cbce42cf844538e1"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"15fc267931a8e65159a3d3b1e9a4371799048591","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e2548034_dd90e5fa","updated":"2021-12-02 11:01:41.000000000","message":"Thanks for digging into this,  I have just some arguments against hardcoding a max_buff_size to oslo.privsep","commit_id":"c223dbced7d5a8d1920fe764cbce42cf844538e1"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"5a953daed7c82fc6e2eb69fe76b97c0e547cba1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b91b316f_6fa1097b","updated":"2021-12-02 15:44:44.000000000","message":"Thoughts inline, but overall lgtm.","commit_id":"c223dbced7d5a8d1920fe764cbce42cf844538e1"}],"oslo_privsep/comm.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4909508d38525138a662fb3aa4499c997f1474d8","unresolved":true,"context_lines":[{"line_number":73,"context_line":"        self.unpacker \u003d msgpack.Unpacker(use_list\u003dFalse, raw\u003dFalse,"},{"line_number":74,"context_line":"                                         strict_map_key\u003dFalse,"},{"line_number":75,"context_line":"                                         unicode_errors\u003d\u0027surrogateescape\u0027,"},{"line_number":76,"context_line":"                                         max_buffer_size\u003d1024 * 1024 * 8)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def __iter__(self):"},{"line_number":79,"context_line":"        return self"}],"source_content_type":"text/x-python","patch_set":1,"id":"225337c4_e290d71c","line":76,"range":{"start_line":76,"start_character":41,"end_line":76,"end_character":56},"updated":"2021-12-01 08:48:48.000000000","message":"default value [1] is 100M, you are reducing it to 8M (12.5 times less). Is that what you want?\n\n[1]https://github.com/msgpack/msgpack-python/blob/bdf0511e29b02427437b03e7d8454bd5076e837f/msgpack/fallback.py#L291","commit_id":"e79bdbc97ac1d3cce5c7c366798d0aee2321abf8"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"a9f0d66ffe57dd20ea1603c0b215df42fd93fcf0","unresolved":true,"context_lines":[{"line_number":73,"context_line":"        self.unpacker \u003d msgpack.Unpacker(use_list\u003dFalse, raw\u003dFalse,"},{"line_number":74,"context_line":"                                         strict_map_key\u003dFalse,"},{"line_number":75,"context_line":"                                         unicode_errors\u003d\u0027surrogateescape\u0027,"},{"line_number":76,"context_line":"                                         max_buffer_size\u003d1024 * 1024 * 8)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def __iter__(self):"},{"line_number":79,"context_line":"        return self"}],"source_content_type":"text/x-python","patch_set":1,"id":"46844e9e_dedfbb49","line":76,"range":{"start_line":76,"start_character":41,"end_line":76,"end_character":56},"in_reply_to":"225337c4_e290d71c","updated":"2021-12-01 09:17:41.000000000","message":"Good catch, I did some more checking.  In this case, the `msgpack` version inside upper-constraints.txt for Ussuri is:\n\nhttps://github.com/openstack/requirements/blob/stable/ussuri/upper-constraints.txt#L685\n\nThis does not include the increase of the limits which happened in 1.0.0\n\nhttps://github.com/msgpack/msgpack-python/blob/main/ChangeLog.rst#100\n\nThis was only bumped inside Victoria:\n\nhttps://github.com/openstack/requirements/blob/stable/victoria/upper-constraints.txt#L381\n\nShould we bump upper-constraints to 1.0.0 or should be bump this to 100 to account for previous versions?  I\u0027d like to hear your thoughts on this.","commit_id":"e79bdbc97ac1d3cce5c7c366798d0aee2321abf8"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3fc03dd2daf9c8513702bdf853911e2a254a31d6","unresolved":true,"context_lines":[{"line_number":73,"context_line":"        self.unpacker \u003d msgpack.Unpacker(use_list\u003dFalse, raw\u003dFalse,"},{"line_number":74,"context_line":"                                         strict_map_key\u003dFalse,"},{"line_number":75,"context_line":"                                         unicode_errors\u003d\u0027surrogateescape\u0027,"},{"line_number":76,"context_line":"                                         max_buffer_size\u003d100 * 1024 * 1024)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def __iter__(self):"},{"line_number":79,"context_line":"        return self"}],"source_content_type":"text/x-python","patch_set":2,"id":"a9e6ef88_7acfc6ca","line":76,"updated":"2021-12-21 11:10:16.000000000","message":"Can we get a small note here indicating why we configure things this way? It\u0027s possible that we\u0027ll want to drop it again in the future (where e.g. only msgpack \u003e\u003d 1.x is supported, or they change their default again)","commit_id":"c223dbced7d5a8d1920fe764cbce42cf844538e1"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"7b2a93188b402a3d2350a81eb05eaa1ae835f5c9","unresolved":true,"context_lines":[{"line_number":73,"context_line":"        self.unpacker \u003d msgpack.Unpacker(use_list\u003dFalse, raw\u003dFalse,"},{"line_number":74,"context_line":"                                         strict_map_key\u003dFalse,"},{"line_number":75,"context_line":"                                         unicode_errors\u003d\u0027surrogateescape\u0027,"},{"line_number":76,"context_line":"                                         max_buffer_size\u003d100 * 1024 * 1024)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def __iter__(self):"},{"line_number":79,"context_line":"        return self"}],"source_content_type":"text/x-python","patch_set":2,"id":"8e1c409e_91a80eeb","line":76,"range":{"start_line":76,"start_character":41,"end_line":76,"end_character":56},"updated":"2021-12-01 11:32:25.000000000","message":"This is already the default value [1]. Does the solution is not simply to pin msgpack to 1.0.0 [2] by default?\n\n1.0.3 is already supported by upper-constraints [3].\n\n[1] https://msgpack-python.readthedocs.io/en/latest/api.html#msgpack.Unpacker\n[2] https://opendev.org/openstack/oslo.privsep/src/branch/master/requirements.txt#L12\n[3] https://opendev.org/openstack/requirements/src/branch/master/upper-constraints.txt#L407","commit_id":"c223dbced7d5a8d1920fe764cbce42cf844538e1"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"5a953daed7c82fc6e2eb69fe76b97c0e547cba1e","unresolved":true,"context_lines":[{"line_number":73,"context_line":"        self.unpacker \u003d msgpack.Unpacker(use_list\u003dFalse, raw\u003dFalse,"},{"line_number":74,"context_line":"                                         strict_map_key\u003dFalse,"},{"line_number":75,"context_line":"                                         unicode_errors\u003d\u0027surrogateescape\u0027,"},{"line_number":76,"context_line":"                                         max_buffer_size\u003d100 * 1024 * 1024)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def __iter__(self):"},{"line_number":79,"context_line":"        return self"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f4b216a_6a3d093b","line":76,"range":{"start_line":76,"start_character":41,"end_line":76,"end_character":56},"in_reply_to":"1c522a12_d439532f","updated":"2021-12-02 15:44:44.000000000","message":"Unless there\u0027s a significant performance penalty for the larger buffer size (which seems unlikely since this is now the default in upstream msgpack), I think we should set this to a sufficiently large value and forget it. This is an implementation detail of privsep and should not be exposed to users, whether that\u0027s consuming projects or admins. It\u0027s a much better user experience if it Just Works(tm).\n\nJust bumping the minimum requirement to 1.0.0 would also work, but this has the advantage of being backportable.","commit_id":"c223dbced7d5a8d1920fe764cbce42cf844538e1"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"f15a16b3e6ebf7d73a4bda7a4424194a538918ef","unresolved":true,"context_lines":[{"line_number":73,"context_line":"        self.unpacker \u003d msgpack.Unpacker(use_list\u003dFalse, raw\u003dFalse,"},{"line_number":74,"context_line":"                                         strict_map_key\u003dFalse,"},{"line_number":75,"context_line":"                                         unicode_errors\u003d\u0027surrogateescape\u0027,"},{"line_number":76,"context_line":"                                         max_buffer_size\u003d100 * 1024 * 1024)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def __iter__(self):"},{"line_number":79,"context_line":"        return self"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a0f846f_adc90ff2","line":76,"range":{"start_line":76,"start_character":41,"end_line":76,"end_character":56},"in_reply_to":"1f4b216a_6a3d093b","updated":"2021-12-03 13:31:24.000000000","message":"ok, I accept it","commit_id":"c223dbced7d5a8d1920fe764cbce42cf844538e1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3fc03dd2daf9c8513702bdf853911e2a254a31d6","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        self.unpacker \u003d msgpack.Unpacker(use_list\u003dFalse, raw\u003dFalse,"},{"line_number":74,"context_line":"                                         strict_map_key\u003dFalse,"},{"line_number":75,"context_line":"                                         unicode_errors\u003d\u0027surrogateescape\u0027,"},{"line_number":76,"context_line":"                                         max_buffer_size\u003d100 * 1024 * 1024)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def __iter__(self):"},{"line_number":79,"context_line":"        return self"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba30c3eb_2bd96150","line":76,"range":{"start_line":76,"start_character":41,"end_line":76,"end_character":56},"in_reply_to":"5a0f846f_adc90ff2","updated":"2021-12-21 11:10:16.000000000","message":"\u003e Unless there\u0027s a significant performance penalty for the larger buffer size (which seems unlikely since this is now the default in upstream msgpack), I think we should set this to a sufficiently large value and forget it. \n\nAgreed","commit_id":"c223dbced7d5a8d1920fe764cbce42cf844538e1"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"15fc267931a8e65159a3d3b1e9a4371799048591","unresolved":true,"context_lines":[{"line_number":73,"context_line":"        self.unpacker \u003d msgpack.Unpacker(use_list\u003dFalse, raw\u003dFalse,"},{"line_number":74,"context_line":"                                         strict_map_key\u003dFalse,"},{"line_number":75,"context_line":"                                         unicode_errors\u003d\u0027surrogateescape\u0027,"},{"line_number":76,"context_line":"                                         max_buffer_size\u003d100 * 1024 * 1024)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def __iter__(self):"},{"line_number":79,"context_line":"        return self"}],"source_content_type":"text/x-python","patch_set":2,"id":"1c522a12_d439532f","line":76,"range":{"start_line":76,"start_character":41,"end_line":76,"end_character":56},"in_reply_to":"8e1c409e_91a80eeb","updated":"2021-12-02 11:01:41.000000000","message":"can\u0027t we have a config option for this? Thus giving the flexibility to the admin and keeping the size limited? Or isn\u0027t it possible to make buff_size a param for PrivContext, thus we can decide in the caller code to use the default buff_size or use a higher for linuxbridge for example?","commit_id":"c223dbced7d5a8d1920fe764cbce42cf844538e1"}]}