)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"a78cb180d9966ea2130cc959927c7a928c5d96f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2986592e_53cd4b61","updated":"2023-05-29 07:04:36.000000000","message":"soft -1 to highlight my comments. \nthanks","commit_id":"065dc2b98d438f6c66936926c2d1b19e3efdf749"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"4824dedbd6bbdac912ecef8290e96c1ec5923a67","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"53c1aec1_2a757306","updated":"2023-05-30 14:22:33.000000000","message":"I don\u0027t think fixing this issue requires a privsep change.\n\nMy idea was to create a new privsep context in os_brick with a different log level set, which can be done just from os_brick w/o changing privsep.","commit_id":"e9954f323969220da39a33fe45c2a8fabdad848e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"92556d24a5d680e35e6ff7b2f1d57d9da59ac591","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"37113f2c_19d789ef","updated":"2023-10-17 05:42:10.000000000","message":"I\u0027ll abandon this based on the latest discussions in this review. Please contact us in #openstack-oslo in case this needs to be restored.","commit_id":"e9954f323969220da39a33fe45c2a8fabdad848e"},{"author":{"_account_id":35063,"name":"Tony Saad","email":"tony.saad@dell.com","username":"tony-saad"},"change_message_id":"371c0a45cd6a5edc3ab41c2e4380837a2482c40a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b573b910_51d43ead","updated":"2023-06-15 18:38:08.000000000","message":"Pushed a new patch which is a WIP, but it is the os-brick only fix. New patch is still getting error\nhttps://review.opendev.org/c/openstack/os-brick/+/885979","commit_id":"e9954f323969220da39a33fe45c2a8fabdad848e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1db590ae98c7365308af53b991b51273ff4e7c29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"246c94fd_446fc992","updated":"2023-09-28 05:38:21.000000000","message":"Should this patch be abandoned in favor of https://review.opendev.org/c/openstack/os-brick/+/885979 ?","commit_id":"e9954f323969220da39a33fe45c2a8fabdad848e"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"c5a5145b971e9d8042914eeb73888846d43cc137","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"58125f9c_8d1d9d59","updated":"2023-09-15 14:35:09.000000000","message":"https://review.opendev.org/c/openstack/os-brick/+/885979 should cover this issue","commit_id":"e9954f323969220da39a33fe45c2a8fabdad848e"},{"author":{"_account_id":35063,"name":"Tony Saad","email":"tony.saad@dell.com","username":"tony-saad"},"change_message_id":"c0fe16940be967f7fc69c45d932237ca01f696a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5048d3e9_cc86848e","in_reply_to":"1d9b56b2_95431ecc","updated":"2023-06-01 18:49:03.000000000","message":"Where would I make a new logger w/ getLogger and set its level to ERROR instead of DEBUG if it is just a os_brick change?\n\nin other words where should this line be place in os_brick \"LOG_PRIVATE \u003d logging.getLogger(\u0027LOG_PRIVATE\u0027)\"","commit_id":"e9954f323969220da39a33fe45c2a8fabdad848e"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"99b2305392521f7db54305c9c902e32c4770d8cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"27718a21_84df6228","in_reply_to":"246c94fd_446fc992","updated":"2023-09-28 05:55:06.000000000","message":"Absolutely? Problem is that Tony left the company, how can we abondon it then?","commit_id":"e9954f323969220da39a33fe45c2a8fabdad848e"},{"author":{"_account_id":35063,"name":"Tony Saad","email":"tony.saad@dell.com","username":"tony-saad"},"change_message_id":"00d68a77644063f2cc95effd60581d7312aa979a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1d9b56b2_95431ecc","in_reply_to":"53c1aec1_2a757306","updated":"2023-05-30 17:14:21.000000000","message":"I did try that with changing the decorator on get_connector_password() here  https://opendev.org/openstack/os-brick/src/commit/ccda511ed531c872cb23b5cdc07067ea2e6cb32a/os_brick/privileged/scaleio.py#L78\n\nBut the password was still getting leaked. This patch was the only way I was able to hide the password (Unless I did not properly create a privsep context)","commit_id":"e9954f323969220da39a33fe45c2a8fabdad848e"}],"oslo_privsep/daemon.py":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"a78cb180d9966ea2130cc959927c7a928c5d96f4","unresolved":true,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":76,"context_line":"LOG_PRIVATE \u003d logging.getLogger(\u0027LOG_PRIVATE\u0027)"},{"line_number":77,"context_line":"LOG_PRIVATE.setLevel(logging.ERROR)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"EVENTLET_MODULES \u003d (\u0027os\u0027, \u0027select\u0027, \u0027socket\u0027, \u0027thread\u0027, \u0027time\u0027, \u0027MySQLdb\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1e7bc446_217c7aa7","line":77,"updated":"2023-05-29 07:04:36.000000000","message":"The bug report says - password is displayed every time the driver tries to attach or detach a volume.\n\n(only to hide password) why ERROR only, if originally it\u0027s logged on every attach and detach operation ?","commit_id":"065dc2b98d438f6c66936926c2d1b19e3efdf749"},{"author":{"_account_id":35063,"name":"Tony Saad","email":"tony.saad@dell.com","username":"tony-saad"},"change_message_id":"23d61bcf58c0ffb62635c0f374b8ab0711632a5c","unresolved":true,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":76,"context_line":"LOG_PRIVATE \u003d logging.getLogger(\u0027LOG_PRIVATE\u0027)"},{"line_number":77,"context_line":"LOG_PRIVATE.setLevel(logging.ERROR)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"EVENTLET_MODULES \u003d (\u0027os\u0027, \u0027select\u0027, \u0027socket\u0027, \u0027thread\u0027, \u0027time\u0027, \u0027MySQLdb\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"0384cfd6_8770ffed","line":77,"in_reply_to":"1e7bc446_217c7aa7","updated":"2023-05-30 14:02:36.000000000","message":"That is what Eric suggested in launchpad. To my understanding this is more of a security workaround. We set to Error so that the password does not appear in the logs","commit_id":"065dc2b98d438f6c66936926c2d1b19e3efdf749"}],"releasenotes/notes/bug-2003179-f88922a47abcf07a.yaml":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"a78cb180d9966ea2130cc959927c7a928c5d96f4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e0b0a0ca_82f41bb0","line":7,"updated":"2023-05-29 07:04:36.000000000","message":"can we please add more detail, like what really is \u0027reply\u0027 object, \n- why its okay to move log to error only.\n- even in the error level, can we mask the password.","commit_id":"065dc2b98d438f6c66936926c2d1b19e3efdf749"},{"author":{"_account_id":35063,"name":"Tony Saad","email":"tony.saad@dell.com","username":"tony-saad"},"change_message_id":"23d61bcf58c0ffb62635c0f374b8ab0711632a5c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"391809d0_34ea020a","line":7,"in_reply_to":"e0b0a0ca_82f41bb0","updated":"2023-05-30 14:02:36.000000000","message":"Reply object is not always a password so masking would not useful.","commit_id":"065dc2b98d438f6c66936926c2d1b19e3efdf749"}]}