)]}'
{"oslo_reports/guru_meditation_report.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"afecc46106efd571ba628ea9972439af3d58a667","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        :param conf: Configuration object, managed by the caller."},{"line_number":129,"context_line":"        \"\"\""},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        if not signum and hasattr(signal, \u0027SIGUSR2\u0027):"},{"line_number":132,"context_line":"            # SIGUSR2 is not supported on all platforms"},{"line_number":133,"context_line":"            signum \u003d signal.SIGUSR2"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_55193478","line":131,"updated":"2015-09-15 12:11:28.000000000","message":"We should probably start the deprecation process to remove this default entirely, and require applications to tell the library what signal to use. The library has no idea what signals might already have handlers, or what conflicts might happen but the application has a better chance of knowing -- especially if it is setting up other signal handlers.\n\nRather than changing the default here and breaking backwards compatibility for everything, we should have applications pass a value in the signum argument. That has the bonus of ensuring that the release note associated with the behavior change is visible in the docs for the app being deployed.","commit_id":"45b1c02d113051d147e54ef921ce8e94135542d8"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"2ed5370ad96c236c9e464a0f4b35ee23e3eb0b36","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        :param conf: Configuration object, managed by the caller."},{"line_number":129,"context_line":"        \"\"\""},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        if not signum and hasattr(signal, \u0027SIGUSR2\u0027):"},{"line_number":132,"context_line":"            # SIGUSR2 is not supported on all platforms"},{"line_number":133,"context_line":"            signum \u003d signal.SIGUSR2"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_3804b7be","line":131,"in_reply_to":"ba15a1d1_55193478","updated":"2015-09-15 12:39:24.000000000","message":"I don\u0027t think that the Guru Mediation is a critical feature, so I don\u0027t think that we need a long process of deprecation, upgrading slowly applications, etc.\n\n\"It turns out[*] that SIGUSR1 is used by Apache \u0027mod_wsgi\u0027.\"\n\nWell, it\u0027s hard to find a signal number which is available on all cases. The nice thing is that this method already has a signum parameter to configure the signa number. If the application knows well how it is deployed, it can pick a different signal number that the default signal number (SIGSUR1 before, SIGUSR2 after).\n\n\"Rather than changing the default here and breaking backwards compatibility for everything, we should have applications pass a value in the signum argument. \"\n\nWhy not registering the signal handler for SIGUSR1 *and* SIGUSR2 when signum is not set? So both signals can be used. If SIGUSR1 doesn\u0027t work (ex: because mod_wsgi overrides it), SIGUSR2 can still be used.","commit_id":"45b1c02d113051d147e54ef921ce8e94135542d8"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"818a86af64fa7664eeee0544f0e9418f02923a14","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        :param conf: Configuration object, managed by the caller."},{"line_number":129,"context_line":"        \"\"\""},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        if not signum and hasattr(signal, \u0027SIGUSR2\u0027):"},{"line_number":132,"context_line":"            # SIGUSR2 is not supported on all platforms"},{"line_number":133,"context_line":"            signum \u003d signal.SIGUSR2"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_d8b9fb7a","line":131,"in_reply_to":"ba15a1d1_55193478","updated":"2015-09-15 12:54:04.000000000","message":"I\u0027d really be strongly against having applications pass in the required signal, because I think it is important that we have a consistent signal used across all openstack projects. If we have different signals in different projects, then you increase the complexity for admins by making them remember different signals for each process. This in turn *will* lead to admin mistakes where they send the wrong signal, which will lead to the app taking the wrong action.","commit_id":"45b1c02d113051d147e54ef921ce8e94135542d8"}]}
