)]}'
{"oslo_rootwrap/client.py":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"31e1decace91e8b4735cb880b5b7d71cddbd2909","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                                       stdout\u003dsubprocess.PIPE,"},{"line_number":74,"context_line":"                                       stderr\u003dsubprocess.PIPE)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        self._process \u003d process_obj"},{"line_number":77,"context_line":"        socket_path \u003d process_obj.stdout.readline()[:-1]"},{"line_number":78,"context_line":"        # For Python 3 we need to convert bytes to str here"},{"line_number":79,"context_line":"        if not isinstance(socket_path, str):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_f4946b37","line":76,"updated":"2015-06-19 04:12:54.000000000","message":"So there\u0027s a chunk of code here that could fail and raise and there would be no sign that we\u0027d reach this (barring logging of an exception IFF it raised all the way up).\n\nPerhaps we should keep a LOG.debug() here saying that we\u0027ve called Popen?\n\nOR\n\nput the code from here through to the point where we know in a try/except/finally block?","commit_id":"987381f12039bedbbe67a172249c46a01e455c4e"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"c89d4c4c59c2edb0909c64d3aa1f3df8b5d93bcf","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                                       stdout\u003dsubprocess.PIPE,"},{"line_number":74,"context_line":"                                       stderr\u003dsubprocess.PIPE)"},{"line_number":75,"context_line":"        LOG.debug(\"Popen for %s command has been instantiated\","},{"line_number":76,"context_line":"                  self._start_command)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        self._process \u003d process_obj"},{"line_number":79,"context_line":"        socket_path \u003d process_obj.stdout.readline()[:-1]"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_5bce6d5b","line":76,"updated":"2015-06-21 22:46:33.000000000","message":"Do we need to mask passwords? Do we have rootwrap commands that have passwords in them?","commit_id":"29f46a4a153733e0a15b35161d77444806b1a30b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"cc0ea0e431eda27e0c889f0c9f1505d1cd9f128d","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                                       stdout\u003dsubprocess.PIPE,"},{"line_number":74,"context_line":"                                       stderr\u003dsubprocess.PIPE)"},{"line_number":75,"context_line":"        LOG.debug(\"Popen for %s command has been instantiated\","},{"line_number":76,"context_line":"                  self._start_command)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        self._process \u003d process_obj"},{"line_number":79,"context_line":"        socket_path \u003d process_obj.stdout.readline()[:-1]"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_2226d116","line":76,"in_reply_to":"fa32b979_5bce6d5b","updated":"2015-06-22 08:56:55.000000000","message":"IIUC it will be something like \"sudo rootwrap-daemon /etc/rootwrap/rootwrap.conf\" - so no password on cmdline.","commit_id":"29f46a4a153733e0a15b35161d77444806b1a30b"}]}