)]}'
{"oslo_rootwrap/filters.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"40106f6e62295114225eefe5d577553d88263c0c","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        if not os.path.isfile(command):"},{"line_number":193,"context_line":"            try:"},{"line_number":194,"context_line":"                cmdline \u003d open(\"/proc/%d/cmdline\" % int(pid))"},{"line_number":195,"context_line":"                cmdline \u003d cmdline.read().partition(\u0027\\0\u0027)[0]"},{"line_number":196,"context_line":"                cmdline \u003d self._program_path(cmdline)"},{"line_number":197,"context_line":"                if os.path.isfile(cmdline):"},{"line_number":198,"context_line":"                    command \u003d cmdline"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_91e4003c","line":195,"updated":"2015-08-17 16:49:03.000000000","message":"Reusing the same variable name for different purposes like this can lead to confusion. The file is also not being closed. Something like\n\n  with open(...) as pfile:\n    cmdline \u003d pfile.read().partition(\u0027\\0\u0027)[0]\n\nwould be easier to follow.","commit_id":"e79186e6a4675e6a796f5904ab8cfea3c73a3108"}]}
