)]}'
{"oslo_rootwrap/client.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"cfb05e4ff36669bf3971751b402b57de76e3e0f4","unresolved":false,"context_lines":[{"line_number":21,"context_line":"import threading"},{"line_number":22,"context_line":"import weakref"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from oslo_rootwrap import daemon"},{"line_number":25,"context_line":"from oslo_rootwrap import jsonrpc"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffb9cba7_9dfab040","line":24,"updated":"2019-04-30 13:12:14.000000000","message":"If you choose to delaying the eventlet import to the client part you need to take care about the daemon part.\n\nWe import oslo_rootwrap.daemon before any eventlet check etc... and in your changes you have remove the dameon the eventlet patched subprocess so you also need to patch subprocess if needed in the daemon module.","commit_id":"902e18c65da565de5d06dd053f149ffb1aa9ce3f"}],"oslo_rootwrap/daemon.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"cfb05e4ff36669bf3971751b402b57de76e3e0f4","unresolved":false,"context_lines":[{"line_number":23,"context_line":"import signal"},{"line_number":24,"context_line":"import six"},{"line_number":25,"context_line":"import stat"},{"line_number":26,"context_line":"import subprocess"},{"line_number":27,"context_line":"import sys"},{"line_number":28,"context_line":"import tempfile"},{"line_number":29,"context_line":"import threading"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffb9cba7_dd8908ca","line":26,"updated":"2019-04-30 13:12:14.000000000","message":"I guess you also need to do some check like tests in the client module to patch or not to patch subprocess with eventlet else you risk to reintroduce the issue fixed by Victor in https://github.com/openstack/oslo.rootwrap/commit/31cfdbd4076bb6556cf9612171ba43fa44475d71","commit_id":"902e18c65da565de5d06dd053f149ffb1aa9ce3f"}],"oslo_rootwrap/tests/run_daemon.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"cfb05e4ff36669bf3971751b402b57de76e3e0f4","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import logging"},{"line_number":17,"context_line":"import subprocess"},{"line_number":18,"context_line":"import sys"},{"line_number":19,"context_line":"import threading"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ffb9cba7_3dbaa46d","line":17,"updated":"2019-04-30 13:12:14.000000000","message":"You need to find a way to test it with a possible patched subprocess module","commit_id":"902e18c65da565de5d06dd053f149ffb1aa9ce3f"}],"oslo_rootwrap/tests/test_rootwrap.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"cfb05e4ff36669bf3971751b402b57de76e3e0f4","unresolved":false,"context_lines":[{"line_number":21,"context_line":"import fixtures"},{"line_number":22,"context_line":"import mock"},{"line_number":23,"context_line":"from six import moves"},{"line_number":24,"context_line":"import subprocess"},{"line_number":25,"context_line":"import testtools"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from oslo_rootwrap import cmd"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffb9cba7_3d6f04fd","line":24,"updated":"2019-04-30 13:12:14.000000000","message":"Same thing you need to do some checks about subprocess and eventlet","commit_id":"902e18c65da565de5d06dd053f149ffb1aa9ce3f"}],"oslo_rootwrap/wrapper.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"cfb05e4ff36669bf3971751b402b57de76e3e0f4","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import logging.handlers"},{"line_number":18,"context_line":"import os"},{"line_number":19,"context_line":"import signal"},{"line_number":20,"context_line":"import subprocess"},{"line_number":21,"context_line":"import sys"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"import six"}],"source_content_type":"text/x-python","patch_set":4,"id":"ffb9cba7_7d69fcf6","line":20,"updated":"2019-04-30 13:12:14.000000000","message":"Wrapper is in use in the daemon module  so you also need to do some tests to know if you need to patch subprocess with eventlet else you risk to reintroduce the python 3 issue fixed by Victor [2].\n\n[1] https://github.com/openstack/oslo.rootwrap/blob/master/oslo_rootwrap/daemon.py#L34\n[2] https://github.com/openstack/oslo.rootwrap/commit/31cfdbd4076bb6556cf9612171ba43fa44475d71","commit_id":"902e18c65da565de5d06dd053f149ffb1aa9ce3f"}]}