)]}'
{"id":"openstack%2Foslo.rootwrap~687554","triplet_id":"openstack%2Foslo.rootwrap~master~I8e80b8995883151741c8f0e448c7881852a69f85","project":"openstack/oslo.rootwrap","branch":"master","topic":"bug/1643457","hashtags":[],"change_id":"I8e80b8995883151741c8f0e448c7881852a69f85","subject":"Catch \"ValueError\" exception in RpcJSONEncoder","status":"ABANDONED","created":"2019-10-09 13:23:58.000000000","updated":"2019-11-21 09:08:59.000000000","total_comment_count":11,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d6dcef22ce0f642bbe9fe5b7578d4bad0933e5f6","_number":687554,"virtual_id_number":687554,"owner":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"date":"2019-10-16 14:55:35.000000000","_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"date":"2019-10-09 18:14:09.000000000","_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},{"date":"2019-10-23 14:06:01.000000000","_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"tag":"autogenerated:zuul:check","value":1,"date":"2019-10-09 15:09:22.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"value":0,"date":"2019-10-18 14:58:51.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},{"date":"2019-10-11 09:22:45.000000000","_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-10-09 15:09:22.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-10-09 18:14:09.000000000","updated_by":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"reviewer":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"state":"REVIEWER"},{"updated":"2019-10-11 09:22:45.000000000","updated_by":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"reviewer":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"state":"REVIEWER"},{"updated":"2019-10-18 14:58:51.000000000","updated_by":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"reviewer":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"state":"REVIEWER"},{"updated":"2019-10-23 14:06:01.000000000","updated_by":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"reviewer":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"state":"REVIEWER"}],"messages":[{"id":"99dec8186a066db8a8820e218163cfb0485ee729","author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"date":"2019-10-09 13:23:58.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f3e315b00fc1a3767381cddb295edc0b7b8e5d2c","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2019-10-09 14:19:25.000000000","message":"Patch Set 1:\n\nHello\n\nThanks for this patch, can you explain to me how to reproduce this issue?","accounts_in_message":[],"_revision_number":1},{"id":"c5b4f9b28045f88d92a81343f8f20777e67f9f80","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2019-10-09 14:30:43.000000000","message":"Patch Set 1:\n\n(2 comments)\n\nSome commennts inline:","accounts_in_message":[],"_revision_number":1},{"id":"1347cc4e380d034aa0e1d05fdeb2fc36190fc673","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-09 15:09:22.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full https://zuul.opendev.org/t/openstack/build/9f059abed75d4879b2505df63c8197b1 : SUCCESS in 1h 43m 21s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/59a7299bbd7a4743985c4543627fc782 : SUCCESS in 1h 31m 10s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/5405f940facf4e26a8f0afc3b73f0ade : SUCCESS in 6m 27s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d38d9c78983e4235b4c9f8338c544f4d : SUCCESS in 4m 52s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/7919fcc32f4a48f58ae49fa34786d7d7 : SUCCESS in 4m 34s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/9199be8064d6452d86dcd487d6d28171 : SUCCESS in 4m 36s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/3530a27d2b104101a28f33ce5e72b1f5 : SUCCESS in 5m 19s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8fe90287207d4868b4e2034ab7eb1d2d : SUCCESS in 4m 56s","accounts_in_message":[],"_revision_number":1},{"id":"9fdda171d707273b672544e24d164ac5acd503e5","author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"date":"2019-10-09 17:58:08.000000000","message":"Patch Set 1:\n\n(2 comments)\n\nHi Hervé. Please check http://paste.openstack.org/show/782460/. You need to install neutron (from source if you want, or package).","accounts_in_message":[],"_revision_number":1},{"id":"acde6b2118329288362bf216b52a74df3e4e5f25","author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"date":"2019-10-09 18:14:09.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"dfb52799936b3047d2bb2dd2a1cf45420752043e","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2019-10-09 18:31:30.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"8fc4339c93d20873ba940a07348e3b9bcddfa6b1","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2019-10-09 18:33:53.000000000","message":"Patch Set 1:\n\nThanks Rodolfo for the given example, I\u0027ll try to use it to make me a better opinion. Be back soon.","accounts_in_message":[],"_revision_number":1},{"id":"73a50536ef19961c787948bc9dfa06e8e33cc7b5","author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"date":"2019-10-10 09:47:15.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"560a50bb246a4232ffff4a139c67b02e8d80697e","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2019-10-11 13:12:07.000000000","message":"Patch Set 1:\n\nTo give you a quick feedback I facing some difficulties to test through your given script.\n\nFor the moment I can\u0027t use it locally against my laptop or in any virtualenv and also against a fully deployed environment.\n\nI facing lot of different issues not related with the problem described here, I guess to reproduce this it necessite specific conditions that I can\u0027t reach on my side with my envs.","accounts_in_message":[],"_revision_number":1},{"id":"c2ee87ecb65c23c920e1a9b3bf855ee3fe3d8f73","author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"date":"2019-10-14 15:54:32.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nI would be more comfortable modifying this (sensitive) code if we had a pretty good idea of why that error is thrown. I wonder if the \"raise EOFError\" in the same file and the whole eventlet workaround mentioned there do not have corner cases with recent versions of Python...","accounts_in_message":[],"_revision_number":1},{"id":"83f0da000636ee1cfda16f768baf476d099f3fce","author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"date":"2019-10-16 14:50:31.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"6703f921c1c8c739a0da3a33c1ac2667845912cb","author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"date":"2019-10-16 14:55:35.000000000","message":"Patch Set 1:\n\n\u003e To give you a quick feedback I facing some difficulties to test\n \u003e through your given script.\n \u003e \n \u003e For the moment I can\u0027t use it locally against my laptop or in any\n \u003e virtualenv and also against a fully deployed environment.\n \u003e \n \u003e I facing lot of different issues not related with the problem\n \u003e described here, I guess to reproduce this it necessite specific\n \u003e conditions that I can\u0027t reach on my side with my envs.\n\nDoes it mean you don\u0027t see this error when executing a command not allowed? Do you see the expected error? You can run this on a VM with neutron installed.\n\nThis is the rootwrap.conf file I have (default one): http://paste.openstack.org/show/784106/\n\nAnd an example of filter file, debug.filters (in /etc/neutron/rootwrap.d): http://paste.openstack.org/show/784107/","accounts_in_message":[],"_revision_number":1},{"id":"59082e7a8c8adb36ed39b3429586f957d02a3d6c","author":{"_account_id":308,"name":"Thierry Carrez","email":"thierry@openstack.org","username":"ttx"},"date":"2019-10-18 14:58:51.000000000","message":"Patch Set 1:\n\nIt\u0027s probably a corner case, as it should be caught in testing by https://opendev.org/openstack/oslo.rootwrap/src/branch/master/oslo_rootwrap/tests/test_functional.py#L202 (daemon mode trying to execute executable that does not exist, before creating it and trying again)... So I\u0027m not sure how to reproduce it.\n\nI would not be against blindly fixing it by catching that exception (filtering for a specific message), but the problem is we don\u0027t even know if we should raise FilterMatchNotExecutable or NoFilterMatched. If we just pick one we would still produce an invalid error message in some cases.... so not a real improvement. Also I\u0027m not sure how much Python promises those exception messages not to change over time.\n\nFor all those reasons I\u0027d be much more comfortable fixing the root cause rather than working around it at the consumer layer.","accounts_in_message":[],"_revision_number":1},{"id":"7c1145e95cfd3dae75986d902b11110f38e6a445","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2019-10-23 14:06:01.000000000","message":"Patch Set 1:\n\n\u003e \u003e To give you a quick feedback I facing some difficulties to test\n \u003e \u003e through your given script.\n \u003e \u003e\n \u003e \u003e For the moment I can\u0027t use it locally against my laptop or in any\n \u003e \u003e virtualenv and also against a fully deployed environment.\n \u003e \u003e\n \u003e \u003e I facing lot of different issues not related with the problem\n \u003e \u003e described here, I guess to reproduce this it necessite specific\n \u003e \u003e conditions that I can\u0027t reach on my side with my envs.\n \u003e \n \u003e Does it mean you don\u0027t see this error when executing a command not\n \u003e allowed? Do you see the expected error? You can run this on a VM\n \u003e with neutron installed.\n \u003e \n\nYep that mean that I couldn\u0027t reproduced your scenario and I can\u0027t seen the expected error. I\u0027ve tried to reproduce it against a fully deployed env so with neutron installed etc... with yours previous given instructions.\n\n \u003e This is the rootwrap.conf file I have (default one):\n \u003e http://paste.openstack.org/show/784106/\n \u003e \n \u003e And an example of filter file, debug.filters (in /etc/neutron/rootwrap.d):\n \u003e http://paste.openstack.org/show/784107/\n\nAlso I agreed with the Thierry comments:\n- I\u0027m not confortable too with this solution and to raising exceptions that we are not sure that it\u0027s the right ones. \n- It\u0027s more worth to try to fix the root cause instead of hide this through an exception.","accounts_in_message":[],"_revision_number":1},{"id":"7b495a0dcadb91a548c0a88ba431659161c7b1d9","author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"date":"2019-11-21 09:08:59.000000000","message":"Abandoned\n\nAs commented by Herve and Thierry, I need to review rootwrap code before proposing this patch. Let\u0027s go for it.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"16d1503d2bc93c2c652f44ba85e36762241d050c","revisions":{"16d1503d2bc93c2c652f44ba85e36762241d050c":{"kind":"REWORK","_number":1,"created":"2019-10-09 13:23:58.000000000","uploader":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"ref":"refs/changes/54/687554/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.rootwrap","ref":"refs/changes/54/687554/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.rootwrap refs/changes/54/687554/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.rootwrap refs/changes/54/687554/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.rootwrap refs/changes/54/687554/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.rootwrap refs/changes/54/687554/1"}}},"commit":{"parents":[{"commit":"a27c2b708307599a9a9ac18dfb243da6ad9d847b","subject":"Update the constraints url","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.rootwrap/commit/a27c2b708307599a9a9ac18dfb243da6ad9d847b"}]}],"author":{"name":"Rodolfo Alonso Hernandez","email":"ralonsoh@redhat.com","date":"2019-10-09 13:05:00.000000000","tz":0},"committer":{"name":"Rodolfo Alonso Hernandez","email":"ralonsoh@redhat.com","date":"2019-10-09 13:23:27.000000000","tz":0},"subject":"Catch \"ValueError\" exception in RpcJSONEncoder","message":"Catch \"ValueError\" exception in RpcJSONEncoder\n\nWhen command to be executed is not present in the filter files, a\n\"wrapper.NoFilterMatched\" should be thrown.\n\nCurrently, maybe due to an error in \"json\" library, when a non\nauthorized command is evaluated in daemon mode, the following\nexception is raised:\n  ValueError(\"I/O operation on closed file\")\n\nIn other to present a more understandable message to the user, this\nexception is catched and \"wrapper.NoFilterMatched\" is passed instead.\n\nChange-Id: I8e80b8995883151741c8f0e448c7881852a69f85\nCloses-Bug: #1643457\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.rootwrap/commit/16d1503d2bc93c2c652f44ba85e36762241d050c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.rootwrap/commit/16d1503d2bc93c2c652f44ba85e36762241d050c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}