)]}'
{"oslo_rootwrap/client.py":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"0fd6bb77d4ae9f477ac0077f13cba5ec7bba55fb","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                    break  # assume it is dead already"},{"line_number":119,"context_line":"                except RuntimeError:"},{"line_number":120,"context_line":"                    time.sleep(0.2)"},{"line_number":121,"context_line":"            # We might want to wait for process to exit or kill it, but we"},{"line_number":122,"context_line":"            # can\u0027t provide sane timeout on 2.x and we most likely don\u0027t have"},{"line_number":123,"context_line":"            # permisions to do so"},{"line_number":124,"context_line":"        # Invalidate manager\u0027s state so that proxy won\u0027t try to do decref"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_dfd541e7","line":121,"updated":"2020-05-13 16:23:48.000000000","message":"This refers to a Python 2 limitation, I wonder if we could do something better here now that we\u0027re 3 only.","commit_id":"ee39ce31af7357d335e5e1f8d9eefa3e2f5fe76d"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"9e60b7acaaef26d063d8050d29bab76731d0b147","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                    break  # assume it is dead already"},{"line_number":119,"context_line":"                except RuntimeError:"},{"line_number":120,"context_line":"                    time.sleep(0.2)"},{"line_number":121,"context_line":"            # We might want to wait for process to exit or kill it, but we"},{"line_number":122,"context_line":"            # can\u0027t provide sane timeout on 2.x and we most likely don\u0027t have"},{"line_number":123,"context_line":"            # permisions to do so"},{"line_number":124,"context_line":"        # Invalidate manager\u0027s state so that proxy won\u0027t try to do decref"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_f59be8c5","line":121,"in_reply_to":"ff570b3c_0a08152a","updated":"2020-05-14 19:09:36.000000000","message":"I don\u0027t have a specific suggestion, I\u0027m just assuming based on the comment that whoever wrote this thought there was a better way to handle it in Python 3. It would require more research to determine what that might be.","commit_id":"ee39ce31af7357d335e5e1f8d9eefa3e2f5fe76d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9ae894ce317cc3f39729d22f7d083aa79f45901a","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                    break  # assume it is dead already"},{"line_number":119,"context_line":"                except RuntimeError:"},{"line_number":120,"context_line":"                    time.sleep(0.2)"},{"line_number":121,"context_line":"            # We might want to wait for process to exit or kill it, but we"},{"line_number":122,"context_line":"            # can\u0027t provide sane timeout on 2.x and we most likely don\u0027t have"},{"line_number":123,"context_line":"            # permisions to do so"},{"line_number":124,"context_line":"        # Invalidate manager\u0027s state so that proxy won\u0027t try to do decref"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_0a08152a","line":121,"in_reply_to":"ff570b3c_dfd541e7","updated":"2020-05-13 17:06:42.000000000","message":"Do you mean to wait for the daemon process? Could be done, but the only contact point is the socket, not the PID. How can we wait for it?? Just asking, I\u0027m not skilled in this code.\n\nI think the problem we are seeing in the related bug is something different, but you are right: eventually we need to check that the daemon is completely stopped.","commit_id":"ee39ce31af7357d335e5e1f8d9eefa3e2f5fe76d"}]}