)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"c71aea7b5114f74b7ab0772d2c7b00b6b45c5c26","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Rather than assume people will be at the right level or figure it out,"},{"line_number":22,"context_line":"let\u0027s be smarter and just check if the kwarg is available in the version"},{"line_number":23,"context_line":"of simplejson we\u0027re using."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"This can be removed in Kilo when python 2.6 support is dropped so this"},{"line_number":26,"context_line":"should be short-term workaround that saves some headaches once Juno is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1abeadc6_186ac080","line":23,"updated":"2014-08-29 18:51:51.000000000","message":"why was the kwarg added? What breaks if it\u0027s not there? I didn\u0027t see an explanation in either of the bug reports.\n\nSeems like it would be safer to revert ad248f6 and not use the kwarg. Otherwise someone\u0027s going to wonder why whatever it is doesn\u0027t work on their system and it\u0027s because they\u0027ve got a downlevel version of the package, which is masked by this workaround.","commit_id":"8c86b4d21b0333ca5d7ce69d3db836b2b8a1e432"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"b9ae2575489c40923d983f8e9ed3ff209b48403b","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Rather than assume people will be at the right level or figure it out,"},{"line_number":22,"context_line":"let\u0027s be smarter and just check if the kwarg is available in the version"},{"line_number":23,"context_line":"of simplejson we\u0027re using."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"This can be removed in Kilo when python 2.6 support is dropped so this"},{"line_number":26,"context_line":"should be short-term workaround that saves some headaches once Juno is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1abeadc6_4716154a","line":23,"in_reply_to":"1abeadc6_186ac080","updated":"2014-08-29 21:37:14.000000000","message":"Yeah that\u0027s a valid concern, I\u0027ll let Yamamoto comment on the original change.\n\nThe problem with the revert is it\u0027s gotta be in oslo.serializer and then oslo-incubator and then sync\u0027ed to the projects that already sync\u0027ed that change in, so it\u0027s also messy.","commit_id":"8c86b4d21b0333ca5d7ce69d3db836b2b8a1e432"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"316e85b9c4c1358055ef4e4bf8bdc5a90bdec020","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Rather than assume people will be at the right level or figure it out,"},{"line_number":22,"context_line":"let\u0027s be smarter and just check if the kwarg is available in the version"},{"line_number":23,"context_line":"of simplejson we\u0027re using."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"This can be removed in Kilo when python 2.6 support is dropped so this"},{"line_number":26,"context_line":"should be short-term workaround that saves some headaches once Juno is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa98f980_d67269ac","line":23,"in_reply_to":"1abeadc6_4716154a","updated":"2014-09-02 02:53:12.000000000","message":"thank you for working on this.\n\nthe motivation of the original change was this:\nhttps://review.openstack.org/#/c/112178/\n\nshortly, we want compatible on-wire representation of named tuples\nregardless of underlying json library in-use.\nso, unfortunately, this change seems to contradict the purpose of\nthe original change.","commit_id":"8c86b4d21b0333ca5d7ce69d3db836b2b8a1e432"}],"oslo/serialization/jsonutils.py":[{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"c71aea7b5114f74b7ab0772d2c7b00b6b45c5c26","unresolved":false,"context_lines":[{"line_number":38,"context_line":"import itertools"},{"line_number":39,"context_line":"import sys"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"namedtuple_as_object_supported \u003d False"},{"line_number":42,"context_line":"if sys.version_info \u003c (2, 7):"},{"line_number":43,"context_line":"    # On Python \u003c\u003d 2.6, json module is not C boosted, so try to use"},{"line_number":44,"context_line":"    # simplejson module if available"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_58bc38dc","line":41,"updated":"2014-08-29 18:51:51.000000000","message":"(suggestion) could do something like:\n\n _dump_kwargs \u003d {}\n\nthen set _dump_kwargs[\u0027namedtuple_as_object\u0027] \u003d True where namedtuple_as_object_supported \u003d True,\n\nthen always do kwargs.update(_dump_kwargs) in dumps and dump.","commit_id":"8c86b4d21b0333ca5d7ce69d3db836b2b8a1e432"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"316e85b9c4c1358055ef4e4bf8bdc5a90bdec020","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        # to support the namedobject_as_tuple argument. This can be removed"},{"line_number":49,"context_line":"        # in the Kilo release when python 2.6 support is dropped."},{"line_number":50,"context_line":"        if \u0027namedtuple_as_object\u0027 in inspect.getargspec(json.dumps).args:"},{"line_number":51,"context_line":"            namedtuple_as_object_supported \u003d True"},{"line_number":52,"context_line":"    except ImportError:"},{"line_number":53,"context_line":"        import json"},{"line_number":54,"context_line":"else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_16cdd15d","line":51,"updated":"2014-09-02 02:53:12.000000000","message":"how about falling back to json if simplejson is old?","commit_id":"8c86b4d21b0333ca5d7ce69d3db836b2b8a1e432"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"5bf1f7919537038c50347eed923c0371c274ae62","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        # to support the namedobject_as_tuple argument. This can be removed"},{"line_number":49,"context_line":"        # in the Kilo release when python 2.6 support is dropped."},{"line_number":50,"context_line":"        if \u0027namedtuple_as_object\u0027 in inspect.getargspec(json.dumps).args:"},{"line_number":51,"context_line":"            namedtuple_as_object_supported \u003d True"},{"line_number":52,"context_line":"    except ImportError:"},{"line_number":53,"context_line":"        import json"},{"line_number":54,"context_line":"else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_035ad5f2","line":51,"in_reply_to":"fa98f980_16cdd15d","updated":"2014-09-02 13:37:40.000000000","message":"I like this. Seems safer to me.","commit_id":"8c86b4d21b0333ca5d7ce69d3db836b2b8a1e432"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"590c201d7bbe0739fd6e6331d7fa5ae038f40bca","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        # to support the namedobject_as_tuple argument. This can be removed"},{"line_number":49,"context_line":"        # in the Kilo release when python 2.6 support is dropped."},{"line_number":50,"context_line":"        if \u0027namedtuple_as_object\u0027 in inspect.getargspec(json.dumps).args:"},{"line_number":51,"context_line":"            namedtuple_as_object_supported \u003d True"},{"line_number":52,"context_line":"    except ImportError:"},{"line_number":53,"context_line":"        import json"},{"line_number":54,"context_line":"else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_c8db4c7a","line":51,"in_reply_to":"fa98f980_16cdd15d","updated":"2014-09-03 20:14:19.000000000","message":"I\u0027ll try that out since as you say this change regresses back to the original bug you were trying to fix.","commit_id":"8c86b4d21b0333ca5d7ce69d3db836b2b8a1e432"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bc5003b2a7d7aa7b0c955f8979d0a55d3fd52b08","unresolved":false,"context_lines":[{"line_number":38,"context_line":"import itertools"},{"line_number":39,"context_line":"import sys"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"namedtuple_as_object_supported \u003d False"},{"line_number":42,"context_line":"if sys.version_info \u003c (2, 7):"},{"line_number":43,"context_line":"    # On Python \u003c\u003d 2.6, json module is not C boosted, so try to use"},{"line_number":44,"context_line":"    # simplejson module if available"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_68fc2073","line":41,"updated":"2014-09-03 20:26:49.000000000","message":"This is never set to True so I should just change this back to the is_simplejson var.","commit_id":"4c1f852e3b906911879300b0300c916cd37721c2"},{"author":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"change_message_id":"b81cd0a8fe3b6b19b92c292e98f8c298b152a4c2","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        # NOTE(mriedem): Make sure we have a new enough version of simplejson"},{"line_number":48,"context_line":"        # to support the namedobject_as_tuple argument. This can be removed"},{"line_number":49,"context_line":"        # in the Kilo release when python 2.6 support is dropped."},{"line_number":50,"context_line":"        if \u0027namedtuple_as_object\u0027 in inspect.getargspec(json.dumps).args:"},{"line_number":51,"context_line":"            import json"},{"line_number":52,"context_line":"        else:"},{"line_number":53,"context_line":"            is_simplejson \u003d True"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_5bc808a8","line":50,"updated":"2014-09-03 20:34:29.000000000","message":"this should be the other way around...\n\n if \u0027namedtuple_as_object\u0027 in inspect.getargspec(json.dumps).args:\n    is_simplejson \u003d True\n else\n    import json\n\n or could do...\n\n is_simplejson \u003d \u0027namedtuple_as_object\u0027 in inspect.getargspec(json.dumps).args\n if not is_simplejson:\n    import json","commit_id":"402d1eb97011652631c3f82d7014265c4ea2aefb"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a60863dd2d14769ac6027ec7dc20a67693c14870","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        # NOTE(mriedem): Make sure we have a new enough version of simplejson"},{"line_number":48,"context_line":"        # to support the namedobject_as_tuple argument. This can be removed"},{"line_number":49,"context_line":"        # in the Kilo release when python 2.6 support is dropped."},{"line_number":50,"context_line":"        if \u0027namedtuple_as_object\u0027 in inspect.getargspec(json.dumps).args:"},{"line_number":51,"context_line":"            import json"},{"line_number":52,"context_line":"        else:"},{"line_number":53,"context_line":"            is_simplejson \u003d True"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_5b0d68e7","line":50,"in_reply_to":"fa98f980_5bc808a8","updated":"2014-09-03 20:37:27.000000000","message":"Ha, well I\u0027ve only screwed this up already like 3 times today.  Pushing another change.","commit_id":"402d1eb97011652631c3f82d7014265c4ea2aefb"}]}