)]}'
{"oslo_serialization/jsonutils.py":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"8c273e2916f416b350cf54eac72716878f8d85b3","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            return dict((recursive(k), recursive(v))"},{"line_number":153,"context_line":"                        for k, v in six.iteritems(value))"},{"line_number":154,"context_line":"        elif hasattr(value, \u0027items\u0027) or hasattr(value, \u0027iteritems\u0027):"},{"line_number":155,"context_line":"            return recursive(dict(value.iteritems()), level\u003dlevel + 1)"},{"line_number":156,"context_line":"        elif hasattr(value, \u0027__iter__\u0027):"},{"line_number":157,"context_line":"            return list(map(recursive, value))"},{"line_number":158,"context_line":"        elif convert_instances and hasattr(value, \u0027__dict__\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_eecd10b8","line":155,"updated":"2015-09-28 07:43:39.000000000","message":"Sorry, I don\u0027t understand the rationale. If value has an *items* method, why do you call a *iteritems* method which may not exist? Instead you should add something like:\n\nelif hasattr(value, \u0027items\u0027):\n  return recursive(dict(value.items()), level\u003dlevel + 1)\n\nIt must be added *after* the iteritems check, to keep the fast path (iteritems) on Python 2.","commit_id":"1f6930d7f54a94bc0ab0e10079b8b59b20f6bd54"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"bee6235032997b77d23e5960a5f718f8869ecb4b","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            return dict((recursive(k), recursive(v))"},{"line_number":153,"context_line":"                        for k, v in six.iteritems(value))"},{"line_number":154,"context_line":"        elif hasattr(value, \u0027items\u0027) or hasattr(value, \u0027iteritems\u0027):"},{"line_number":155,"context_line":"            return recursive(dict(value.iteritems()), level\u003dlevel + 1)"},{"line_number":156,"context_line":"        elif hasattr(value, \u0027__iter__\u0027):"},{"line_number":157,"context_line":"            return list(map(recursive, value))"},{"line_number":158,"context_line":"        elif convert_instances and hasattr(value, \u0027__dict__\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_afbaad6c","line":155,"in_reply_to":"9a1a9d01_244ec996","updated":"2015-09-28 11:09:33.000000000","message":":) I\u0027ve added a test now.","commit_id":"1f6930d7f54a94bc0ab0e10079b8b59b20f6bd54"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"0dd0ce9772b9e6b79a9515df091f92bfb386690e","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            return dict((recursive(k), recursive(v))"},{"line_number":153,"context_line":"                        for k, v in six.iteritems(value))"},{"line_number":154,"context_line":"        elif hasattr(value, \u0027items\u0027) or hasattr(value, \u0027iteritems\u0027):"},{"line_number":155,"context_line":"            return recursive(dict(value.iteritems()), level\u003dlevel + 1)"},{"line_number":156,"context_line":"        elif hasattr(value, \u0027__iter__\u0027):"},{"line_number":157,"context_line":"            return list(map(recursive, value))"},{"line_number":158,"context_line":"        elif convert_instances and hasattr(value, \u0027__dict__\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_244ec996","line":155,"in_reply_to":"9a1a9d01_eecd10b8","updated":"2015-09-28 09:01:58.000000000","message":"And then you wonder why I ask for tests…","commit_id":"1f6930d7f54a94bc0ab0e10079b8b59b20f6bd54"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"27359c9c9f74b177b0d569de8ae3894df61141fd","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            return dict((recursive(k), recursive(v))"},{"line_number":153,"context_line":"                        for k, v in six.iteritems(value))"},{"line_number":154,"context_line":"        elif hasattr(value, \u0027items\u0027) or hasattr(value, \u0027iteritems\u0027):"},{"line_number":155,"context_line":"            return recursive(dict(value.iteritems()), level\u003dlevel + 1)"},{"line_number":156,"context_line":"        elif hasattr(value, \u0027__iter__\u0027):"},{"line_number":157,"context_line":"            return list(map(recursive, value))"},{"line_number":158,"context_line":"        elif convert_instances and hasattr(value, \u0027__dict__\u0027):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_4e943ce1","line":155,"in_reply_to":"9a1a9d01_eecd10b8","updated":"2015-09-28 08:06:04.000000000","message":"Sorry, yeah. I realised this later when testing. It should be `items` instead. I\u0027ll rectify this in the latest patchset and add a test case. Thanks.","commit_id":"1f6930d7f54a94bc0ab0e10079b8b59b20f6bd54"}],"oslo_serialization/tests/test_jsonutils.py":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"14a646aa4a690cd8690bb98227794d29a253ab17","unresolved":false,"context_lines":[{"line_number":189,"context_line":"                return self.data[val]"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"            def __iter__(self):"},{"line_number":192,"context_line":"                return iter(self.data)"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"            def __len__(self):"},{"line_number":195,"context_line":"                return len(self.data)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_7da3e64f","line":192,"updated":"2015-09-28 13:43:00.000000000","message":"Hum, I guess that the unit test pass without the change. You should use a class with an tems() method but no iteritems() method. I don\u0027t know which methods are inherited by collections.Mapping, probably too many :-)","commit_id":"0583c88017ddb432f3ef56fd054a29651bda3712"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"43b87f7219f934073cfc46be5819036e3ef6d656","unresolved":false,"context_lines":[{"line_number":189,"context_line":"                return self.data[val]"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"            def __iter__(self):"},{"line_number":192,"context_line":"                return iter(self.data)"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"            def __len__(self):"},{"line_number":195,"context_line":"                return len(self.data)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_bab72039","line":192,"in_reply_to":"9a1a9d01_7da3e64f","updated":"2015-09-29 07:15:14.000000000","message":"Sure, I\u0027ll add a separate test case for that if you like. Although, this is the particular case where Heat fails to serialize objects sometimes. Where an __iter__ exists and without this change to to_primitive, a list is returned rather than a dict in python3.","commit_id":"0583c88017ddb432f3ef56fd054a29651bda3712"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"1b6fbbefac623247766680f717c56e1d2398fbff","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        # an exception due to excessive recursion depth."},{"line_number":199,"context_line":"        jsonutils.to_primitive(x)"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    def test_items(self):"},{"line_number":202,"context_line":"        class IterItemsClass(object):"},{"line_number":203,"context_line":"            def __init__(self):"},{"line_number":204,"context_line":"                self.data \u003d dict(a\u003d1, b\u003d2, c\u003d3).items()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_f9728510","line":201,"updated":"2015-09-29 08:13:43.000000000","message":"Can you please add a short comment saying that this test checks that to_primitive() uses .items() when available? Just to make it obvious.","commit_id":"d4b7c82dc319b67c126ab0bffadd2430c8292fa6"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"cf629b6c00e96824b317eb5e1028e8c3f8bfcbef","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        # an exception due to excessive recursion depth."},{"line_number":199,"context_line":"        jsonutils.to_primitive(x)"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    def test_items(self):"},{"line_number":202,"context_line":"        class IterItemsClass(object):"},{"line_number":203,"context_line":"            def __init__(self):"},{"line_number":204,"context_line":"                self.data \u003d dict(a\u003d1, b\u003d2, c\u003d3).items()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_5559c48c","line":201,"in_reply_to":"9a1a9d01_f9728510","updated":"2015-09-30 07:08:12.000000000","message":"Done","commit_id":"d4b7c82dc319b67c126ab0bffadd2430c8292fa6"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"1b6fbbefac623247766680f717c56e1d2398fbff","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        jsonutils.to_primitive(x)"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    def test_items(self):"},{"line_number":202,"context_line":"        class IterItemsClass(object):"},{"line_number":203,"context_line":"            def __init__(self):"},{"line_number":204,"context_line":"                self.data \u003d dict(a\u003d1, b\u003d2, c\u003d3).items()"},{"line_number":205,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_598131c2","line":202,"updated":"2015-09-29 08:13:43.000000000","message":"Why is it call \"IterItems\"? The purpose of this class it to test items() no?","commit_id":"d4b7c82dc319b67c126ab0bffadd2430c8292fa6"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"cf629b6c00e96824b317eb5e1028e8c3f8bfcbef","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        jsonutils.to_primitive(x)"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    def test_items(self):"},{"line_number":202,"context_line":"        class IterItemsClass(object):"},{"line_number":203,"context_line":"            def __init__(self):"},{"line_number":204,"context_line":"                self.data \u003d dict(a\u003d1, b\u003d2, c\u003d3).items()"},{"line_number":205,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_755c087d","line":202,"in_reply_to":"9a1a9d01_598131c2","updated":"2015-09-30 07:08:12.000000000","message":"Done","commit_id":"d4b7c82dc319b67c126ab0bffadd2430c8292fa6"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"1b6fbbefac623247766680f717c56e1d2398fbff","unresolved":false,"context_lines":[{"line_number":204,"context_line":"                self.data \u003d dict(a\u003d1, b\u003d2, c\u003d3).items()"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"            def items(self):"},{"line_number":207,"context_line":"                return self.data"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        x \u003d IterItemsClass()"},{"line_number":210,"context_line":"        p \u003d jsonutils.to_primitive(x)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_3926bd15","line":207,"updated":"2015-09-29 08:13:43.000000000","message":"I would prefer to see the call to .items() here.","commit_id":"d4b7c82dc319b67c126ab0bffadd2430c8292fa6"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"cf629b6c00e96824b317eb5e1028e8c3f8bfcbef","unresolved":false,"context_lines":[{"line_number":204,"context_line":"                self.data \u003d dict(a\u003d1, b\u003d2, c\u003d3).items()"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"            def items(self):"},{"line_number":207,"context_line":"                return self.data"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        x \u003d IterItemsClass()"},{"line_number":210,"context_line":"        p \u003d jsonutils.to_primitive(x)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_15582c87","line":207,"in_reply_to":"9a1a9d01_3926bd15","updated":"2015-09-30 07:08:12.000000000","message":"Done","commit_id":"d4b7c82dc319b67c126ab0bffadd2430c8292fa6"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"1b6fbbefac623247766680f717c56e1d2398fbff","unresolved":false,"context_lines":[{"line_number":210,"context_line":"        p \u003d jsonutils.to_primitive(x)"},{"line_number":211,"context_line":"        self.assertEqual(p, {\u0027a\u0027: 1, \u0027b\u0027: 2, \u0027c\u0027: 3})"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    def test_items_iter(self):"},{"line_number":214,"context_line":"        class ItemsClass(collections.Mapping):"},{"line_number":215,"context_line":"            def __init__(self):"},{"line_number":216,"context_line":"                self.data \u003d dict(a\u003d1, b\u003d2, c\u003d3)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_99f02969","line":213,"updated":"2015-09-29 08:13:43.000000000","message":"Are you testing a specific path in to_primitive()? Do you expect that .__iter__() will always be called? Or always .items()? If yes, the two methods should return a different result. If not, you should rename the test to \"test_mapping\".\n\nPlease add a comment to explain that you check that to_primitive() accepts an implementation of the collections.Mapping interface.","commit_id":"d4b7c82dc319b67c126ab0bffadd2430c8292fa6"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"cf629b6c00e96824b317eb5e1028e8c3f8bfcbef","unresolved":false,"context_lines":[{"line_number":210,"context_line":"        p \u003d jsonutils.to_primitive(x)"},{"line_number":211,"context_line":"        self.assertEqual(p, {\u0027a\u0027: 1, \u0027b\u0027: 2, \u0027c\u0027: 3})"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    def test_items_iter(self):"},{"line_number":214,"context_line":"        class ItemsClass(collections.Mapping):"},{"line_number":215,"context_line":"            def __init__(self):"},{"line_number":216,"context_line":"                self.data \u003d dict(a\u003d1, b\u003d2, c\u003d3)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_356770ea","line":213,"in_reply_to":"9a1a9d01_99f02969","updated":"2015-09-30 07:08:12.000000000","message":"Yes, it\u0027s misleading. I\u0027ll rename to test_mapping.","commit_id":"d4b7c82dc319b67c126ab0bffadd2430c8292fa6"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"1b6fbbefac623247766680f717c56e1d2398fbff","unresolved":false,"context_lines":[{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        x \u003d ItemsClass()"},{"line_number":228,"context_line":"        p \u003d jsonutils.to_primitive(x)"},{"line_number":229,"context_line":"        self.assertEqual(p, {\u0027a\u0027: 1, \u0027b\u0027: 2, \u0027c\u0027: 3})"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    def test_instance(self):"},{"line_number":232,"context_line":"        class MysteryClass(object):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_b99c0d10","line":229,"updated":"2015-09-29 08:13:43.000000000","message":"You _might_ add a test to ensure that to_primitive() prefers iteritems() when iteritems() and items() are available. Or maybe modify your second test to return different values for iteritems() and items(), to check which one was called? (It would make the test different, iteritems() is not part of collections.Mapping interface on Python 3.)","commit_id":"d4b7c82dc319b67c126ab0bffadd2430c8292fa6"},{"author":{"_account_id":6899,"name":"Sirushti Murugesan","email":"sirushtim@gmail.com","username":"sirushtim"},"change_message_id":"cf629b6c00e96824b317eb5e1028e8c3f8bfcbef","unresolved":false,"context_lines":[{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        x \u003d ItemsClass()"},{"line_number":228,"context_line":"        p \u003d jsonutils.to_primitive(x)"},{"line_number":229,"context_line":"        self.assertEqual(p, {\u0027a\u0027: 1, \u0027b\u0027: 2, \u0027c\u0027: 3})"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    def test_instance(self):"},{"line_number":232,"context_line":"        class MysteryClass(object):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_b2507633","line":229,"in_reply_to":"9a1a9d01_b99c0d10","updated":"2015-09-30 07:08:12.000000000","message":"This test is only checking for precedence of items/iteritems() over __iter__ that returns a list instead of a dict. I\u0027ll add another test case anyway.","commit_id":"d4b7c82dc319b67c126ab0bffadd2430c8292fa6"}]}
