)]}'
{"oslo_serialization/jsonutils.py":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"2ebf5d6e64540e2c390a3b85ed8f4b1f7d209f67","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        # __iter__ defined but it isn\u0027t callable as list()."},{"line_number":162,"context_line":"        return six.text_type(value)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    raise ValueError(\"Cannot convert %s to primitive\" % six.text_type(value))"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"JSONEncoder \u003d json.JSONEncoder"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_0127a612","line":164,"updated":"2016-06-17 16:14:46.000000000","message":"Other idea here, instead of trying to use \u0027six.text_type\u0027 how about using the following:\n\n  raise ValueError(\"Cannot convert %r to primitive\" % value)\n\nI\u0027m thinking that might be better, and a little more informative to the user than trying to convert there value to unicode.\n\n%r uses repr() btw.","commit_id":"69e6c5e01d7f239533a95454f93076f151ca2a18"},{"author":{"_account_id":20864,"name":"Gevorg Davoian","email":"gdavoian@gmail.com","username":"gdavoian"},"change_message_id":"02c5f4d162760eefe1d0ff076cd8884978cd4ba3","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        # __iter__ defined but it isn\u0027t callable as list()."},{"line_number":162,"context_line":"        return six.text_type(value)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    raise ValueError(\"Cannot convert %s to primitive\" % six.text_type(value))"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"JSONEncoder \u003d json.JSONEncoder"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_538d05d2","line":164,"in_reply_to":"7aa08908_0127a612","updated":"2016-06-17 16:49:42.000000000","message":"Done","commit_id":"69e6c5e01d7f239533a95454f93076f151ca2a18"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"c96ccca53ac566a6a1842f034abf6a49d1df78fd","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        # __iter__ defined but it isn\u0027t callable as list()."},{"line_number":162,"context_line":"        return six.text_type(value)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    raise ValueError(\"Cannot convert %r to primitive\" % value)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"JSONEncoder \u003d json.JSONEncoder"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a9d85d2_2ed5da42","line":164,"updated":"2016-06-20 16:39:27.000000000","message":"If value is an iterable container where one element can\u0027t be converted by the recursive block above, this could result in an error trying to format the message itself. Either of these forms is safer:\n\n  return ValueError(\"Cannot convert %r to primitive\" % (value,))\n\nor\n\n  return ValueError(\"Cannot convert {!r} to primitive\".format(value))","commit_id":"155a4a7882ebacdf03979db6d38f021c73d5804c"}]}