)]}'
{"id":"openstack%2Foslo.serialization~475052","triplet_id":"openstack%2Foslo.serialization~master~I6aecd2d057d282a655ff9e4918c164253142b188","project":"openstack/oslo.serialization","branch":"master","topic":"bug/1698355","hashtags":[],"change_id":"I6aecd2d057d282a655ff9e4918c164253142b188","subject":"Don\u0027t iterate through addresses in netaddr.IPNetwork","status":"MERGED","created":"2017-06-16 18:46:38.000000000","updated":"2017-09-05 11:58:25.000000000","submitted":"2017-06-26 16:15:32.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"e0e13b78ce13434e21f74ea61183b1237cb9cfb0","_number":475052,"virtual_id_number":475052,"owner":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"value":2,"date":"2017-06-26 16:15:32.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"recommended":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"all":[{"value":1,"date":"2017-06-17 15:49:05.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":2,"date":"2017-06-26 14:54:25.000000000","_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":2,"date":"2017-06-26 14:15:16.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"all":[{"value":0,"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":1,"date":"2017-06-26 14:54:25.000000000","_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},{"value":0,"date":"2017-06-16 20:18:17.000000000","_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},{"value":0,"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"value":0,"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-06-16 20:18:17.000000000","updated_by":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"reviewer":{"_account_id":6486,"name":"Brant Knudson","email":"blk@acm.org","username":"blk-u"},"state":"REVIEWER"},{"updated":"2017-06-17 15:49:05.000000000","updated_by":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"reviewer":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"state":"REVIEWER"},{"updated":"2017-06-26 14:15:16.000000000","updated_by":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"reviewer":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"state":"REVIEWER"},{"updated":"2017-06-26 14:54:25.000000000","updated_by":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"reviewer":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"state":"REVIEWER"},{"updated":"2017-06-26 16:15:32.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"133bde8ecd8a96a11a1b390e04cb3fbbe5ca150a","author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"date":"2017-06-16 18:46:38.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d6c13c2cbee2f22402011be34b4334b1f7156256","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-16 20:05:35.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-oslo.serialization-docs-ubuntu-xenial http://docs-draft.openstack.org/52/475052/1/check/gate-oslo.serialization-docs-ubuntu-xenial/e9df06c//doc/build/html/ : SUCCESS in 2m 29s\n- gate-oslo.serialization-pep8-ubuntu-xenial http://logs.openstack.org/52/475052/1/check/gate-oslo.serialization-pep8-ubuntu-xenial/3cc23c0/ : SUCCESS in 2m 23s\n- gate-oslo.serialization-python27-ubuntu-xenial http://logs.openstack.org/52/475052/1/check/gate-oslo.serialization-python27-ubuntu-xenial/8979341/ : SUCCESS in 2m 19s\n- gate-oslo.serialization-python35 http://logs.openstack.org/52/475052/1/check/gate-oslo.serialization-python35/cee911e/ : SUCCESS in 3m 15s\n- gate-tempest-dsvm-neutron-src-oslo.serialization-ubuntu-xenial http://logs.openstack.org/52/475052/1/check/gate-tempest-dsvm-neutron-src-oslo.serialization-ubuntu-xenial/334deb3/ : SUCCESS in 1h 16m 32s","accounts_in_message":[],"_revision_number":1},{"id":"1dfc8213ed276fcf3b0216d1abba68fdedea19a8","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2017-06-17 15:49:05.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"875526b3f151ad9fc7bb1f95b05f1ae592d980f1","author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"date":"2017-06-26 14:15:16.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"ac452216188b6c5a575400ae3c28eeb1f5316c69","author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"date":"2017-06-26 14:54:25.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"6b26ea18e7a088c905e86a11cd3c5327371fb2de","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-26 14:54:46.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"224a2138745ec91d36e2867da2232124882b7592","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-26 16:15:32.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-oslo.serialization-docs-ubuntu-xenial http://docs-draft.openstack.org/52/475052/1/gate/gate-oslo.serialization-docs-ubuntu-xenial/f22c8e8//doc/build/html/ : SUCCESS in 3m 43s\n- gate-oslo.serialization-pep8-ubuntu-xenial http://logs.openstack.org/52/475052/1/gate/gate-oslo.serialization-pep8-ubuntu-xenial/6cb2ebb/ : SUCCESS in 4m 20s\n- gate-oslo.serialization-python27-ubuntu-xenial http://logs.openstack.org/52/475052/1/gate/gate-oslo.serialization-python27-ubuntu-xenial/19d78b5/ : SUCCESS in 3m 43s\n- gate-oslo.serialization-python35 http://logs.openstack.org/52/475052/1/gate/gate-oslo.serialization-python35/99f4772/ : SUCCESS in 5m 47s\n- gate-tempest-dsvm-neutron-src-oslo.serialization-ubuntu-xenial http://logs.openstack.org/52/475052/1/gate/gate-tempest-dsvm-neutron-src-oslo.serialization-ubuntu-xenial/7718f74/ : SUCCESS in 1h 20m 07s","accounts_in_message":[],"_revision_number":1},{"id":"5f82478f2a4d7f5dbe022e7d2a9be4d0e69eab74","date":"2017-06-26 16:15:33.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"2902129d5d7e62372e7c97e00ceb6ba37a1df7c0","author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"date":"2017-09-05 11:58:25.000000000","message":"Patch Set 1: Cherry Picked\n\nThis patchset was cherry picked to branch stable/ocata as commit be828c35d84f8f10b07f11aa8bbf195a44e730f8","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"38ac21b523f23f802557d94b527821bc84deaa16","revisions":{"38ac21b523f23f802557d94b527821bc84deaa16":{"kind":"REWORK","_number":1,"created":"2017-06-16 18:46:38.000000000","uploader":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"ref":"refs/changes/52/475052/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.serialization","ref":"refs/changes/52/475052/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.serialization refs/changes/52/475052/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.serialization refs/changes/52/475052/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.serialization refs/changes/52/475052/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.serialization refs/changes/52/475052/1"}}},"commit":{"parents":[{"commit":"98642b2d6960b0eb1072bf8daa75fab59c1b8f40","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.serialization/commit/98642b2d6960b0eb1072bf8daa75fab59c1b8f40"}]}],"author":{"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","date":"2017-06-16 18:43:21.000000000","tz":-420},"committer":{"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","date":"2017-06-16 18:46:36.000000000","tz":-420},"subject":"Don\u0027t iterate through addresses in netaddr.IPNetwork","message":"Don\u0027t iterate through addresses in netaddr.IPNetwork\n\nCurrently, to_primitive tries to iterate through all addresses in the\nnetwork, because the type doesn\u0027t have a special handling that would\nshort curcuit it, but also has __iter__. This may be detrimental to\nperformance, up to the point of node crash due to memory exhaustion if\nthe passed network range is too large (think of 0.0.0.0/0 or even\n2001::/64). This behavior also makes it impossible to restore the\noriginal data format (CIDR).\n\nThis patch short curcuits the iteration by handling the IPNetwork type\nas a special case, same as we do for IPAddress.\n\nChange-Id: I6aecd2d057d282a655ff9e4918c164253142b188\nCloses-Bug: #1698355\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.serialization/commit/38ac21b523f23f802557d94b527821bc84deaa16"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.serialization/commit/38ac21b523f23f802557d94b527821bc84deaa16"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"98642b2d6960b0eb1072bf8daa75fab59c1b8f40","is_merged_in_target_branch":true,"change_id":"Ic382884e9e510f2edb6aec69cf8140ee6774bfc5","change_number":470536,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}