)]}'
{"id":"openstack%2Foslo.serialization~758708","triplet_id":"openstack%2Foslo.serialization~master~Id1763e5549bca1c2340ece8bb9ad0c62baec5b6e","project":"openstack/oslo.serialization","branch":"master","hashtags":[],"change_id":"Id1763e5549bca1c2340ece8bb9ad0c62baec5b6e","subject":"Do not force bytes decoding to ASCII","status":"ABANDONED","created":"2020-10-19 07:16:55.000000000","updated":"2020-10-21 12:33:23.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b5dea048344a2c9503800d55c76be2a0666f43f8","_number":758708,"virtual_id_number":758708,"owner":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2020-10-19 08:44:02.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2020-10-19 11:28:13.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-10-19 08:44:02.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-10-19 11:28:13.000000000","updated_by":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"reviewer":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"state":"REVIEWER"}],"messages":[{"id":"c8c60583d0b4e42409b89a6728d2c0afbce202b8","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2020-10-19 07:16:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1048cbded9a442e7e9f7f5e646e6f1737ba7aec5","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-19 08:44:02.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/2654f93ec6e14e2492483f20e56230ca : SUCCESS in 1h 21m 42s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/419b0a95a7f14da68d7b64b114d12367 : SUCCESS in 5m 11s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2817592e7b274fadb75deeea44d287e9 : SUCCESS in 4m 43s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e61a58b54bb7410c9f7a930893d28a98 : SUCCESS in 5m 11s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/7840ec7ea003419cab2e348db961fb6b : SUCCESS in 4m 58s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/549523d45ce4486b9b97cf31a3b09947 : SUCCESS in 4m 27s","accounts_in_message":[],"_revision_number":1},{"id":"07322d9ed92f3bd30b10cc662bd7ad282a37c3eb","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-10-19 11:28:13.000000000","message":"Patch Set 1: Code-Review+1\n\nHello,\n\nThanks for these changes.\n\nPlease can you add a related test to ensure to catch early related things.\n\nhttps://opendev.org/openstack/oslo.serialization/src/branch/master/oslo_serialization/tests/test_base64.py#L42","accounts_in_message":[],"_revision_number":1},{"id":"b5dea048344a2c9503800d55c76be2a0666f43f8","author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"date":"2020-10-21 12:33:23.000000000","message":"Abandoned\n\nonce I started writing tests, I realized that probably issue is in service itself","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"e1a2650d93957d7335054be92bcdbecd1caa09f1","revisions":{"e1a2650d93957d7335054be92bcdbecd1caa09f1":{"kind":"REWORK","_number":1,"created":"2020-10-19 07:16:55.000000000","uploader":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"ref":"refs/changes/08/758708/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/oslo.serialization","ref":"refs/changes/08/758708/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/oslo.serialization refs/changes/08/758708/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/oslo.serialization refs/changes/08/758708/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/oslo.serialization refs/changes/08/758708/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/oslo.serialization refs/changes/08/758708/1"}}},"commit":{"parents":[{"commit":"5c01e16192735d73dda45a0f8871d143f2c16052","subject":"Merge \"Adding pre-commit\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.serialization/commit/5c01e16192735d73dda45a0f8871d143f2c16052"}]}],"author":{"name":"Dmitriy Rabotyagov","email":"dmitriy.rabotyagov@citynetwork.eu","date":"2020-10-19 07:16:37.000000000","tz":180},"committer":{"name":"Dmitriy Rabotyagov","email":"dmitriy.rabotyagov@citynetwork.eu","date":"2020-10-19 07:16:53.000000000","tz":180},"subject":"Do not force bytes decoding to ASCII","message":"Do not force bytes decoding to ASCII\n\nIn Python 3 b64decode excpects either bytes or string object [1].\nSo we shouldn\u0027t force decode bytes to ASCII and just pass bytes object.\n\nCurrent behavior makes things fail in case string is already decoded,\nbut is a bytes object, like happens in Barbican [2]\n\n[1] https://docs.python.org/3.6/library/base64.html#base64.b64decode\n[2] http://paste.openstack.org/show/798944/\n\nChange-Id: Id1763e5549bca1c2340ece8bb9ad0c62baec5b6e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.serialization/commit/e1a2650d93957d7335054be92bcdbecd1caa09f1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/oslo.serialization/commit/e1a2650d93957d7335054be92bcdbecd1caa09f1"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}