)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"2a20e1cfa3ada265927e866c59cac46ca43bffcd","unresolved":false,"context_lines":[{"line_number":10,"context_line":"interrupts in-progress request. This could cause problem when do upgrading."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Following related things were done:"},{"line_number":13,"context_line":"1. Removed signal handler for SIGINT to allow instantaneous shutdown."},{"line_number":14,"context_line":"2. Call launcher.stop() was moved from _child_wait_for_exit_or_signal method"},{"line_number":15,"context_line":"to SIGTERM signal handler and pipe_watcher method because service must not be"},{"line_number":16,"context_line":"stopped for example if SIGHUP comes."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3afb71cf_32cae21b","line":13,"updated":"2015-06-11 07:12:57.000000000","message":"I wonder why it was added in the first place. Can we track the exact commit that did that?","commit_id":"0e4e294eb2ea7fd2e9cbb03e267909d8c79334ab"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"54760672b94426a1f3db71a38a77b89456dd8dfd","unresolved":false,"context_lines":[{"line_number":10,"context_line":"interrupts in-progress request. This could cause problem when do upgrading."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Following related things were done:"},{"line_number":13,"context_line":"1. Removed signal handler for SIGINT to allow instantaneous shutdown."},{"line_number":14,"context_line":"2. Call launcher.stop() was moved from _child_wait_for_exit_or_signal method"},{"line_number":15,"context_line":"to SIGTERM signal handler and pipe_watcher method because service must not be"},{"line_number":16,"context_line":"stopped for example if SIGHUP comes."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3afb71cf_fe2e4841","line":13,"in_reply_to":"3afb71cf_32cae21b","updated":"2015-06-11 13:22:56.000000000","message":"I think that was the change that introduced it: https://github.com/openstack/nova/commit/46c1b6eaee4ca00c256c5c403c6d6bfeaf3b63f8","commit_id":"0e4e294eb2ea7fd2e9cbb03e267909d8c79334ab"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"2a20e1cfa3ada265927e866c59cac46ca43bffcd","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Following related things were done:"},{"line_number":13,"context_line":"1. Removed signal handler for SIGINT to allow instantaneous shutdown."},{"line_number":14,"context_line":"2. Call launcher.stop() was moved from _child_wait_for_exit_or_signal method"},{"line_number":15,"context_line":"to SIGTERM signal handler and pipe_watcher method because service must not be"},{"line_number":16,"context_line":"stopped for example if SIGHUP comes."},{"line_number":17,"context_line":"3. Added stop server operation before sending TERM signal to children"},{"line_number":18,"context_line":"processes to close listening socket in master process. Because if socket in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3afb71cf_8cf18097","line":15,"updated":"2015-06-11 07:12:57.000000000","message":"perhaps we should rethink this: we may need to reinitialise the wsgi app upon receiving a SIGHUP (e.g. to apply the changes made to config file like DB connection url, etc)","commit_id":"0e4e294eb2ea7fd2e9cbb03e267909d8c79334ab"}],"oslo_service/service.py":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"2a20e1cfa3ada265927e866c59cac46ca43bffcd","unresolved":false,"context_lines":[{"line_number":526,"context_line":"        self.tg.wait()"},{"line_number":527,"context_line":""},{"line_number":528,"context_line":"    def restart(self):"},{"line_number":529,"context_line":"        self.stop()"},{"line_number":530,"context_line":"        self.done \u003d event.Event()"},{"line_number":531,"context_line":"        for restart_service in self.services:"},{"line_number":532,"context_line":"            restart_service.reset()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_d26eeefe","side":"PARENT","line":529,"updated":"2015-06-11 07:12:57.000000000","message":"back to my question in the commit message: I\u0027m wondering if it will be possible to change configuration at runtime upon receiving of SIGHUP without stopping/restarting the service","commit_id":"8c56f24291504acaef93b094c73f50126a18dd7e"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"54760672b94426a1f3db71a38a77b89456dd8dfd","unresolved":false,"context_lines":[{"line_number":526,"context_line":"        self.tg.wait()"},{"line_number":527,"context_line":""},{"line_number":528,"context_line":"    def restart(self):"},{"line_number":529,"context_line":"        self.stop()"},{"line_number":530,"context_line":"        self.done \u003d event.Event()"},{"line_number":531,"context_line":"        for restart_service in self.services:"},{"line_number":532,"context_line":"            restart_service.reset()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3afb71cf_9eb194e2","side":"PARENT","line":529,"in_reply_to":"3afb71cf_d26eeefe","updated":"2015-06-11 13:22:56.000000000","message":"I wonder have anyone tried to change anything except logging options with SIGHUP?\nI know that in glance they can handle changing bind_port and bind_host for their wsgi server [1], but in any case they don\u0027t use common/service code.\n\n[1] https://github.com/openstack/glance/blob/master/glance/common/wsgi.py#L472","commit_id":"8c56f24291504acaef93b094c73f50126a18dd7e"}]}
