)]}'
{"oslo_service/loopingcall.py":[{"author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"change_message_id":"f81033f04f5f9e4308bb877ad317f1b0b96c6c3a","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    def func(*args, **kwargs):"},{"line_number":49,"context_line":"        try:"},{"line_number":50,"context_line":"            return f(*args, **kwargs)"},{"line_number":51,"context_line":"        except LoopingCallDone:"},{"line_number":52,"context_line":"            raise"},{"line_number":53,"context_line":"        except Exception:"},{"line_number":54,"context_line":"            LOG.exception(_LE(\u0027Exception in task execution\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_6e00d834","line":51,"updated":"2015-06-24 08:44:25.000000000","message":"Why do we need this except block?","commit_id":"c34f3e35b4d24f32298eec88c91faced2a544db6"},{"author":{"_account_id":5950,"name":"Ilya Shakhat","email":"shakhat@gmail.com","username":"shakhat"},"change_message_id":"4be6f4fc7af1b255c3b95d57c28ca841f22cd124","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    def func(*args, **kwargs):"},{"line_number":49,"context_line":"        try:"},{"line_number":50,"context_line":"            return f(*args, **kwargs)"},{"line_number":51,"context_line":"        except LoopingCallDone:"},{"line_number":52,"context_line":"            raise"},{"line_number":53,"context_line":"        except Exception:"},{"line_number":54,"context_line":"            LOG.exception(_LE(\u0027Exception in task execution\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_bf27ec61","line":51,"in_reply_to":"fa32b979_6e00d834","updated":"2015-06-24 09:38:33.000000000","message":"function f indicates that it wants to quit the loop by raising LoopingCallDone exception -- so the exception should not be processed here.\nhowever, I\u0027ll re-work the patch as Eugene asks to be similar to https://review.openstack.org/#/c/191530/","commit_id":"c34f3e35b4d24f32298eec88c91faced2a544db6"},{"author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"change_message_id":"f81033f04f5f9e4308bb877ad317f1b0b96c6c3a","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        except LoopingCallDone:"},{"line_number":52,"context_line":"            raise"},{"line_number":53,"context_line":"        except Exception:"},{"line_number":54,"context_line":"            LOG.exception(_LE(\u0027Exception in task execution\u0027))"},{"line_number":55,"context_line":"            return 0"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    return func"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_ee362802","line":54,"updated":"2015-06-24 08:44:25.000000000","message":"Maybe we can add information about the root cause of exception.","commit_id":"c34f3e35b4d24f32298eec88c91faced2a544db6"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"0e705917ba2af9836e2d1acaf7a477082477e49a","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        except LoopingCallDone:"},{"line_number":52,"context_line":"            raise"},{"line_number":53,"context_line":"        except Exception:"},{"line_number":54,"context_line":"            LOG.exception(_LE(\u0027Exception in task execution\u0027))"},{"line_number":55,"context_line":"            return 0"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    return func"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_a4180d1f","line":54,"in_reply_to":"fa32b979_7fcc0489","updated":"2015-06-25 07:05:26.000000000","message":"Log.exception should log a traceback","commit_id":"c34f3e35b4d24f32298eec88c91faced2a544db6"},{"author":{"_account_id":5950,"name":"Ilya Shakhat","email":"shakhat@gmail.com","username":"shakhat"},"change_message_id":"4be6f4fc7af1b255c3b95d57c28ca841f22cd124","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        except LoopingCallDone:"},{"line_number":52,"context_line":"            raise"},{"line_number":53,"context_line":"        except Exception:"},{"line_number":54,"context_line":"            LOG.exception(_LE(\u0027Exception in task execution\u0027))"},{"line_number":55,"context_line":"            return 0"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    return func"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_7fcc0489","line":54,"in_reply_to":"fa32b979_ee362802","updated":"2015-06-24 09:38:33.000000000","message":"yep, it\u0027s better to change to LOG.error with sys.exc_info() passed into","commit_id":"c34f3e35b4d24f32298eec88c91faced2a544db6"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"eb82ba3aa45ddab45f81c5da4de89a0d54fa5e87","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        self._thread \u003d None"},{"line_number":86,"context_line":"        self._running \u003d False"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def _start(self, idle_for, initial_delay\u003dNone, stop_on_exception\u003dFalse):"},{"line_number":89,"context_line":"        if self._thread is not None:"},{"line_number":90,"context_line":"            raise RuntimeError(self._RUN_ONLY_ONE_MESSAGE)"},{"line_number":91,"context_line":"        self._running \u003d True"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_957a4ff0","line":88,"updated":"2015-07-21 14:41:25.000000000","message":"Why the default stop_on_exception value here is False when everywhere else it is True?","commit_id":"e3abee895c8ffde1e4c579484986e5bd458e1e9c"},{"author":{"_account_id":5950,"name":"Ilya Shakhat","email":"shakhat@gmail.com","username":"shakhat"},"change_message_id":"77f537968d00811b3e2c559e5c313775ade05100","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        self._thread \u003d None"},{"line_number":86,"context_line":"        self._running \u003d False"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def _start(self, idle_for, initial_delay\u003dNone, stop_on_exception\u003dFalse):"},{"line_number":89,"context_line":"        if self._thread is not None:"},{"line_number":90,"context_line":"            raise RuntimeError(self._RUN_ONLY_ONE_MESSAGE)"},{"line_number":91,"context_line":"        self._running \u003d True"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_5842be11","line":88,"in_reply_to":"3a50d1a3_957a4ff0","updated":"2015-07-21 14:52:43.000000000","message":"Elena: ohh, needs to be changed to True here!\nMarian: agree, but there\u0027s already initial_delay with default value, so let\u0027s keep consistency","commit_id":"e3abee895c8ffde1e4c579484986e5bd458e1e9c"},{"author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"change_message_id":"93a897968e9ae9225425d4b7d48fcfa49b670373","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        self._thread \u003d None"},{"line_number":86,"context_line":"        self._running \u003d False"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def _start(self, idle_for, initial_delay\u003dNone, stop_on_exception\u003dFalse):"},{"line_number":89,"context_line":"        if self._thread is not None:"},{"line_number":90,"context_line":"            raise RuntimeError(self._RUN_ONLY_ONE_MESSAGE)"},{"line_number":91,"context_line":"        self._running \u003d True"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_f8b5ca30","line":88,"in_reply_to":"3a50d1a3_957a4ff0","updated":"2015-07-21 14:49:12.000000000","message":"If _run_loop is private maybe we don\u0027t need default values for arguments of _run_loop at all?","commit_id":"e3abee895c8ffde1e4c579484986e5bd458e1e9c"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"d1676015532dedcfb8e21868cb032aac6ac2d939","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        self._thread \u003d None"},{"line_number":86,"context_line":"        self._running \u003d False"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def _start(self, idle_for, initial_delay\u003dNone, stop_on_exception\u003dFalse):"},{"line_number":89,"context_line":"        if self._thread is not None:"},{"line_number":90,"context_line":"            raise RuntimeError(self._RUN_ONLY_ONE_MESSAGE)"},{"line_number":91,"context_line":"        self._running \u003d True"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_980606cd","line":88,"in_reply_to":"3a50d1a3_f8b5ca30","updated":"2015-07-21 14:51:03.000000000","message":"Good point, Marian","commit_id":"e3abee895c8ffde1e4c579484986e5bd458e1e9c"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"2491b88a925702967c24e5f45022be262617c999","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            LOG.error(_LE(\u0027%(kind)s %(func_name)r failed\u0027),"},{"line_number":57,"context_line":"                      {\u0027kind\u0027: kind, \u0027func_name\u0027: f},"},{"line_number":58,"context_line":"                      exc_info\u003dexc_info)"},{"line_number":59,"context_line":"            return 0"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    return func"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_4a0df635","line":59,"updated":"2015-07-21 19:31:11.000000000","message":"I think u can just use exc_info\u003dTrue and this will do the same, avoids any kind of reference issues due to the exc_info() call.","commit_id":"73921944eeb7c86b02c93116fc48ddd967810a80"},{"author":{"_account_id":5950,"name":"Ilya Shakhat","email":"shakhat@gmail.com","username":"shakhat"},"change_message_id":"d76bc279e54be08247c86b6593e0db39b3f6b718","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            LOG.error(_LE(\u0027%(kind)s %(func_name)r failed\u0027),"},{"line_number":57,"context_line":"                      {\u0027kind\u0027: kind, \u0027func_name\u0027: f},"},{"line_number":58,"context_line":"                      exc_info\u003dexc_info)"},{"line_number":59,"context_line":"            return 0"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    return func"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_9306bc84","line":59,"in_reply_to":"3a50d1a3_4a0df635","updated":"2015-07-22 09:26:42.000000000","message":"You\u0027re right! (https://docs.python.org/2.7/library/logging.html#logging.debug)\nLooks like the same change could be done in _run_loop","commit_id":"73921944eeb7c86b02c93116fc48ddd967810a80"}]}
