)]}'
{"oslo_service/loopingcall.py":[{"author":{"_account_id":5950,"name":"Ilya Shakhat","email":"shakhat@gmail.com","username":"shakhat"},"change_message_id":"cc418941de9113a1793e1bf4a9accb3cf9b65ce4","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def start(self, interval, initial_delay\u003dNone):"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        def _on_complete(result, elapsed):"},{"line_number":106,"context_line":"            delay \u003d elapsed - interval"},{"line_number":107,"context_line":"            if delay \u003e 0:"},{"line_number":108,"context_line":"                LOG.warning(_LW(\u0027Functor %(func_name)r run outlasted \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_ec141745","line":105,"updated":"2015-06-23 14:19:49.000000000","message":"what is this function for? could the check be a part of _idle_for?","commit_id":"1b106407d8e1509f81e2095d23fecbee5bc1b048"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"a1a1b3d59fab577f55d27c97eac79d6e6efef9a0","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def start(self, interval, initial_delay\u003dNone):"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        def _on_complete(result, elapsed):"},{"line_number":106,"context_line":"            delay \u003d elapsed - interval"},{"line_number":107,"context_line":"            if delay \u003e 0:"},{"line_number":108,"context_line":"                LOG.warning(_LW(\u0027Functor %(func_name)r run outlasted \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_b290a5ee","line":105,"in_reply_to":"fa32b979_92a1e1fa","updated":"2015-06-23 15:45:32.000000000","message":"I\u0027ll move it back :)\n\nOne of the prior revisions had it combined, but then I was thinking that the warning message here really doesn\u0027t have anything to do logically with computing the amount of time to delay for, so then I thought it belonged in a seperate function (one that has nothing to do with the idle time calculation).","commit_id":"1b106407d8e1509f81e2095d23fecbee5bc1b048"},{"author":{"_account_id":5950,"name":"Ilya Shakhat","email":"shakhat@gmail.com","username":"shakhat"},"change_message_id":"1fc0f80e6d40b25ac1ed0e94194948890b95131f","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def start(self, interval, initial_delay\u003dNone):"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        def _on_complete(result, elapsed):"},{"line_number":106,"context_line":"            delay \u003d elapsed - interval"},{"line_number":107,"context_line":"            if delay \u003e 0:"},{"line_number":108,"context_line":"                LOG.warning(_LW(\u0027Functor %(func_name)r run outlasted \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_92a1e1fa","line":105,"in_reply_to":"fa32b979_bc463ebe","updated":"2015-06-23 15:33:24.000000000","message":"no, I\u0027m just curious. \npersonally I think that the less code the better :)","commit_id":"1b106407d8e1509f81e2095d23fecbee5bc1b048"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"ff8342d668c40d37fd1a39432c1aba575cdc7064","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def start(self, interval, initial_delay\u003dNone):"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        def _on_complete(result, elapsed):"},{"line_number":106,"context_line":"            delay \u003d elapsed - interval"},{"line_number":107,"context_line":"            if delay \u003e 0:"},{"line_number":108,"context_line":"                LOG.warning(_LW(\u0027Functor %(func_name)r run outlasted \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_bc463ebe","line":105,"in_reply_to":"fa32b979_ec141745","updated":"2015-06-23 15:10:19.000000000","message":"I did make it there, but then thought it really was seperate, can put it back in _idle_for if thats what is desired.","commit_id":"1b106407d8e1509f81e2095d23fecbee5bc1b048"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"813374be060363867aae7b66fc9f4350d2af61b5","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        def _on_complete(result, elapsed):"},{"line_number":106,"context_line":"            delay \u003d elapsed - interval"},{"line_number":107,"context_line":"            if delay \u003e 0:"},{"line_number":108,"context_line":"                LOG.warning(_LW(\u0027Functor %(func_name)r run outlasted \u0027"},{"line_number":109,"context_line":"                                \u0027interval by %(delay).2f sec\u0027),"},{"line_number":110,"context_line":"                            {\u0027func_name\u0027: self.f, \u0027delay\u0027: delay})"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_d9e00599","line":108,"updated":"2015-06-23 09:51:47.000000000","message":"nit: *function","commit_id":"1b106407d8e1509f81e2095d23fecbee5bc1b048"},{"author":{"_account_id":5950,"name":"Ilya Shakhat","email":"shakhat@gmail.com","username":"shakhat"},"change_message_id":"cc418941de9113a1793e1bf4a9accb3cf9b65ce4","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def start(self, initial_delay\u003dNone, periodic_interval_max\u003dNone):"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        def _idle_for(result, elapsed):"},{"line_number":137,"context_line":"            idle \u003d result"},{"line_number":138,"context_line":"            if periodic_interval_max is not None:"},{"line_number":139,"context_line":"                idle \u003d min(idle, periodic_interval_max)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_8c646bb9","line":136,"updated":"2015-06-23 14:19:49.000000000","message":"how about renaming \u0027result\u0027 into \u0027delay\u0027 or like this?","commit_id":"1b106407d8e1509f81e2095d23fecbee5bc1b048"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"b34cbcd9286557992ab778d472bf2c60c473467c","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def start(self, initial_delay\u003dNone, periodic_interval_max\u003dNone):"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        def _idle_for(result, elapsed):"},{"line_number":137,"context_line":"            idle \u003d result"},{"line_number":138,"context_line":"            if periodic_interval_max is not None:"},{"line_number":139,"context_line":"                idle \u003d min(idle, periodic_interval_max)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_46407434","line":136,"in_reply_to":"fa32b979_8c646bb9","updated":"2015-06-23 17:46:03.000000000","message":"Ok.","commit_id":"1b106407d8e1509f81e2095d23fecbee5bc1b048"}]}
