)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"change_message_id":"d2d8e39e9af5c1dc630fb0314d09b987298a5762","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Make the loopingcall code less dependent on eventlet"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We can eliminate most of the eventlet specifics by just"},{"line_number":10,"context_line":"using the futurist codebase and using a greenthread pool"},{"line_number":11,"context_line":"executor in place of the usage of eventlet specifics. This"},{"line_number":12,"context_line":"makes it easier to switch this to something else in the future"},{"line_number":13,"context_line":"if we so desire."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba3cc151_5befc6e8","line":10,"updated":"2015-07-02 10:30:15.000000000","message":"A futuristic.Green ThreadPoolExecutor using eventlet green thread pools. So I don\u0027t understand why do we need one more eventlet wrapper and library dependency. Could you please explain?","commit_id":"92cb0381439026827316ebbdbafef5bffc2879f8"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"9dea93d0a4c29e8fb7ac36fdc6465e68cf7a9df6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Make the loopingcall code less dependent on eventlet"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We can eliminate most of the eventlet specifics by just"},{"line_number":10,"context_line":"using the futurist codebase and using a greenthread pool"},{"line_number":11,"context_line":"executor in place of the usage of eventlet specifics. This"},{"line_number":12,"context_line":"makes it easier to switch this to something else in the future"},{"line_number":13,"context_line":"if we so desire."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba3cc151_38bdfdd7","line":10,"in_reply_to":"ba3cc151_5befc6e8","updated":"2015-07-03 03:45:35.000000000","message":"The interface of using an exeuctor (even if its backed by a eventlet green pool as in the green thread pool executor implementation in this review) allows for using something not eventlet in the future; aka with the API switched to the executor API instead of eventlet it\u0027s now possible to say move to a different executor implementation (one say based on threads). So that\u0027s the (or my) reasoning.","commit_id":"92cb0381439026827316ebbdbafef5bffc2879f8"}],"oslo_service/loopingcall.py":[{"author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"change_message_id":"f9a72d2d6b1ba54aadb31e882ce2a257562069ed","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        self.f \u003d f"},{"line_number":78,"context_line":"        self._running \u003d False"},{"line_number":79,"context_line":"        self._fut \u003d None"},{"line_number":80,"context_line":"        self._executor \u003d futurist.GreenThreadPoolExecutor(max_workers\u003d1)"},{"line_number":81,"context_line":"        self.done \u003d None"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def stop(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_ecf74d57","line":80,"updated":"2015-07-07 17:57:21.000000000","message":"If we want to make LoopingCall code independent from executor implementation we need to add additional argument to __init__. It should be instance of oncurrent.futures.Executor class. And this instance should be assigned to self._executor.","commit_id":"9768fd6c5ee9f8250729484ba194f6eaeb45328c"}],"requirements.txt":[{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"30b10cf2849695961f1e7aa0fab39b5e2c93e472","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Babel\u003e\u003d1.3"},{"line_number":6,"context_line":"futurist\u003e\u003d0.1.1"},{"line_number":7,"context_line":"eventlet\u003e\u003d0.17.4"},{"line_number":8,"context_line":"monotonic\u003e\u003d0.1 # Apache-2.0"},{"line_number":9,"context_line":"oslo.utils\u003e\u003d1.6.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":3,"id":"ba3cc151_56f2d007","line":6,"updated":"2015-07-06 12:28:39.000000000","message":"This needs an Apache-2.0 comment","commit_id":"92cb0381439026827316ebbdbafef5bffc2879f8"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"e056aa65cd737c5a613d2f165edf4abfc8246bc0","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Babel\u003e\u003d1.3"},{"line_number":6,"context_line":"futurist\u003e\u003d0.1.1 # Apache-2.0"},{"line_number":7,"context_line":"eventlet\u003e\u003d0.17.4"},{"line_number":8,"context_line":"monotonic\u003e\u003d0.1 # Apache-2.0"},{"line_number":9,"context_line":"oslo.utils\u003e\u003d1.6.0 # Apache-2.0"},{"line_number":10,"context_line":"oslo.config\u003e\u003d1.11.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":4,"id":"ba3cc151_2ccd355d","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":8},"updated":"2015-07-07 17:51:32.000000000","message":"Do we still need to refer to eventlet here?","commit_id":"9768fd6c5ee9f8250729484ba194f6eaeb45328c"}]}
