)]}'
{"oslo_service/eventlet_backdoor.py":[{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"c8c985aa2a0f59619bc9aa3a263fbf867b6639f3","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        \u0027pnt\u0027: _print_nativethreads,"},{"line_number":104,"context_line":"    }"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    if conf.backdoor_port is None:"},{"line_number":107,"context_line":"        return None"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    start_port, end_port \u003d _parse_port_range(str(conf.backdoor_port))"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_f8440e75","line":106,"updated":"2015-06-30 13:43:55.000000000","message":"If conf.backdoor_port is None then we get \u0027NoneType\u0027 object is not iterable error. One way out is to return None, None here","commit_id":"a4d94c58a7bb5146c9ae7113255441e199518f24"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"c8c985aa2a0f59619bc9aa3a263fbf867b6639f3","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"def initialize_if_enabled(conf):"},{"line_number":135,"context_line":"    port, _t \u003d _initialize_if_enabled(conf)"},{"line_number":136,"context_line":"    return port"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_f56e57c8","line":135,"updated":"2015-06-30 13:43:55.000000000","message":"nit: _t could be replaced with _ as we never use this variable","commit_id":"a4d94c58a7bb5146c9ae7113255441e199518f24"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"e09363796ddde6c25f8e004911fecfc3023a89bc","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"def initialize_if_enabled(conf):"},{"line_number":135,"context_line":"    port, _t \u003d _initialize_if_enabled(conf)"},{"line_number":136,"context_line":"    return port"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_074e236f","line":135,"in_reply_to":"ba3cc151_f56e57c8","updated":"2015-06-30 17:34:17.000000000","message":"I thought that was bad practice, due to the gettext usage of \u0027_\u0027 and its dual meaning there?","commit_id":"a4d94c58a7bb5146c9ae7113255441e199518f24"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"c8c985aa2a0f59619bc9aa3a263fbf867b6639f3","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    from oslo_config import cfg"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    import logging"},{"line_number":146,"context_line":"    import sys"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    logging.basicConfig(level\u003dlogging.DEBUG)"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_f8ddee42","line":146,"updated":"2015-06-30 13:43:55.000000000","message":"These two are already imported at the module level, so no need to duplicate them","commit_id":"a4d94c58a7bb5146c9ae7113255441e199518f24"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"e09363796ddde6c25f8e004911fecfc3023a89bc","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    from oslo_config import cfg"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    import logging"},{"line_number":146,"context_line":"    import sys"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    logging.basicConfig(level\u003dlogging.DEBUG)"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_8742333d","line":146,"in_reply_to":"ba3cc151_f8ddee42","updated":"2015-06-30 17:34:17.000000000","message":"Done","commit_id":"a4d94c58a7bb5146c9ae7113255441e199518f24"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"c8c985aa2a0f59619bc9aa3a263fbf867b6639f3","unresolved":false,"context_lines":[{"line_number":151,"context_line":"    conf.register_cli_opts(_options.eventlet_backdoor_opts)"},{"line_number":152,"context_line":"    conf(sys.argv[1:])"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    _p, t \u003d _initialize_if_enabled(conf)"},{"line_number":155,"context_line":"    t.wait()"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_f57c1774","line":154,"updated":"2015-06-30 13:43:55.000000000","message":"Perhaps we have to raise if _initialize_if_enabled returns None\n\n\nnit: _p could be replaced with _ and t with \"thread\" or \"green_thread\"","commit_id":"a4d94c58a7bb5146c9ae7113255441e199518f24"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"e09363796ddde6c25f8e004911fecfc3023a89bc","unresolved":false,"context_lines":[{"line_number":151,"context_line":"    conf.register_cli_opts(_options.eventlet_backdoor_opts)"},{"line_number":152,"context_line":"    conf(sys.argv[1:])"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    _p, t \u003d _initialize_if_enabled(conf)"},{"line_number":155,"context_line":"    t.wait()"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_c76efbc8","line":154,"in_reply_to":"ba3cc151_f57c1774","updated":"2015-06-30 17:34:17.000000000","message":"Hmmm, I guess it will blowup in either way (with a different) error if it returns none, but sure, I can alter it.","commit_id":"a4d94c58a7bb5146c9ae7113255441e199518f24"}],"oslo_service/tests/test_eventlet_backdoor.py":[{"author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"change_message_id":"6ef51e57401d149cde3ebe71b06ea41e62507662","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    def common_backdoor_port_setup(self):"},{"line_number":37,"context_line":"        self.sock \u003d self.mox.CreateMockAnything()"},{"line_number":38,"context_line":"        self.mox.StubOutWithMock(eventlet, \u0027listen\u0027)"},{"line_number":39,"context_line":"        self.mox.StubOutWithMock(eventlet, \u0027spawn\u0027)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def test_backdoor_port_inuse(self):"},{"line_number":42,"context_line":"        self.config(backdoor_port\u003d2345)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_98a8f778","line":39,"updated":"2015-07-02 08:58:57.000000000","message":"mock should be used instead of mox...","commit_id":"c527448894fbecfbd149f99b99c95f414c59739f"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"37e7195914294708ce194b08ab5cdea19c96aa39","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    def common_backdoor_port_setup(self):"},{"line_number":37,"context_line":"        self.sock \u003d self.mox.CreateMockAnything()"},{"line_number":38,"context_line":"        self.mox.StubOutWithMock(eventlet, \u0027listen\u0027)"},{"line_number":39,"context_line":"        self.mox.StubOutWithMock(eventlet, \u0027spawn\u0027)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def test_backdoor_port_inuse(self):"},{"line_number":42,"context_line":"        self.config(backdoor_port\u003d2345)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_b1c01f7e","line":39,"in_reply_to":"ba3cc151_98a8f778","updated":"2015-07-05 02:59:55.000000000","message":"Likely, that\u0027d require a bigger patch to change this whole module over (note this patch didn\u0027t add new \u0027mox\u0027 usage).","commit_id":"c527448894fbecfbd149f99b99c95f414c59739f"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"859872dbac94a3ec567c047234220fbae958bb7f","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    def common_backdoor_port_setup(self):"},{"line_number":37,"context_line":"        self.sock \u003d self.mox.CreateMockAnything()"},{"line_number":38,"context_line":"        self.mox.StubOutWithMock(eventlet, \u0027listen\u0027)"},{"line_number":39,"context_line":"        self.mox.StubOutWithMock(eventlet, \u0027spawn\u0027)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def test_backdoor_port_inuse(self):"},{"line_number":42,"context_line":"        self.config(backdoor_port\u003d2345)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3cc151_6bf7f1f5","line":39,"in_reply_to":"ba3cc151_b1c01f7e","updated":"2015-07-06 12:00:54.000000000","message":"Agree with Joshua, we\u0027ll remove mox usage in another patch (https://review.openstack.org/#/c/197991/)","commit_id":"c527448894fbecfbd149f99b99c95f414c59739f"}]}
