)]}'
{"bandit.yaml":[{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"f2c6c12fc7a248ef63258ad4cbcba8833aa15992","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Generated using bandit_conf_generator"},{"line_number":2,"context_line":"profiles:"},{"line_number":3,"context_line":"  gate:"},{"line_number":4,"context_line":"    include:"},{"line_number":5,"context_line":"    - any_other_function_with_shell_equals_true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a8ffd7b_0e0a308a","line":2,"updated":"2015-11-30 10:55:49.000000000","message":"Cyril, Victor, is it OK that bandit_conf_generator creates two identical sections: here and L94?","commit_id":"ee4a76a34cb2fdd7fa0b2d6a94caafbc01035f4c"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"2403581c3b5c3d6a11ed8fbf82963cea33b6a0a8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Generated using bandit_conf_generator"},{"line_number":2,"context_line":"profiles:"},{"line_number":3,"context_line":"  gate:"},{"line_number":4,"context_line":"    include:"},{"line_number":5,"context_line":"    - any_other_function_with_shell_equals_true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a8ffd7b_c442c90e","line":2,"in_reply_to":"9a8ffd7b_0e0a308a","updated":"2015-11-30 11:20:12.000000000","message":"Certainly not, how did you call it?","commit_id":"ee4a76a34cb2fdd7fa0b2d6a94caafbc01035f4c"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"9bb32a5f8e1fba1ea6fcf76024d4505febb86eb4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Generated using bandit_conf_generator"},{"line_number":2,"context_line":"profiles:"},{"line_number":3,"context_line":"  gate:"},{"line_number":4,"context_line":"    include:"},{"line_number":5,"context_line":"    - any_other_function_with_shell_equals_true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a8ffd7b_e207bdc7","line":2,"in_reply_to":"9a8ffd7b_82491133","updated":"2015-11-30 12:00:10.000000000","message":"It seems that oslo.log has the same issue with bandit.yaml:\n\nhttps://github.com/openstack/oslo.log/blob/master/bandit.yaml","commit_id":"ee4a76a34cb2fdd7fa0b2d6a94caafbc01035f4c"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"ff64dcc7da689334d10447831fafdd67ce18ede6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Generated using bandit_conf_generator"},{"line_number":2,"context_line":"profiles:"},{"line_number":3,"context_line":"  gate:"},{"line_number":4,"context_line":"    include:"},{"line_number":5,"context_line":"    - any_other_function_with_shell_equals_true"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a8ffd7b_82491133","line":2,"in_reply_to":"9a8ffd7b_c442c90e","updated":"2015-11-30 11:59:03.000000000","message":"I used the example from https://github.com/openstack/bandit/blob/master/docs/source/config.rst#generating-a-default-configuration\n\n    $ python bandit/bandit_config_generator.py bandit/config/bandit.yaml ~/minimal.yaml --out ~/oslo.service/bandit.yaml\n\n    $ cat ~/minimal.yaml\n    profile_name: gate","commit_id":"ee4a76a34cb2fdd7fa0b2d6a94caafbc01035f4c"}],"oslo_service/periodic_task.py":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"668a8e55fea660263b10b8cd99cb091cd21298c1","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        return current_time"},{"line_number":167,"context_line":"    delta \u003d current_time - last_run"},{"line_number":168,"context_line":"    offset \u003d delta % spacing"},{"line_number":169,"context_line":"    rand \u003d random.SystemRandom()"},{"line_number":170,"context_line":"    # Add up to 5% jitter"},{"line_number":171,"context_line":"    jitter \u003d int(spacing * (rand.random() / 20))"},{"line_number":172,"context_line":"    return current_time - offset + jitter"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_7fb484d0","line":169,"updated":"2015-12-01 11:31:22.000000000","message":"I don\u0027t think that we need cryptographic random numbers here.","commit_id":"27b5d0ef43da103058bbf6d183945ced82d4ced7"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"55bf376554c8dfd09d4f4ab02a7651bcde8961c0","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        return current_time"},{"line_number":167,"context_line":"    delta \u003d current_time - last_run"},{"line_number":168,"context_line":"    offset \u003d delta % spacing"},{"line_number":169,"context_line":"    rand \u003d random.SystemRandom()"},{"line_number":170,"context_line":"    # Add up to 5% jitter"},{"line_number":171,"context_line":"    jitter \u003d int(spacing * (rand.random() / 20))"},{"line_number":172,"context_line":"    return current_time - offset + jitter"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_8a548354","line":169,"in_reply_to":"9a8ffd7b_1a7c661f","updated":"2015-12-01 13:05:17.000000000","message":"From what I understand, the random is used to delay tasks. It\u0027s not a secret. An attacker cannot use this \"secret\" to hack into the process.","commit_id":"27b5d0ef43da103058bbf6d183945ced82d4ced7"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"653fbfcee2b9c1005864c7be89e9907e8ca05e3e","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        return current_time"},{"line_number":167,"context_line":"    delta \u003d current_time - last_run"},{"line_number":168,"context_line":"    offset \u003d delta % spacing"},{"line_number":169,"context_line":"    rand \u003d random.SystemRandom()"},{"line_number":170,"context_line":"    # Add up to 5% jitter"},{"line_number":171,"context_line":"    jitter \u003d int(spacing * (rand.random() / 20))"},{"line_number":172,"context_line":"    return current_time - offset + jitter"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_cb8ff273","line":169,"in_reply_to":"9a8ffd7b_1a7c661f","updated":"2015-12-01 12:28:44.000000000","message":"I do not know oslo_service too well, but maybe the whole \"random\" thing could be removed from the config file.","commit_id":"27b5d0ef43da103058bbf6d183945ced82d4ced7"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"cf1106fac6044e5cadaabaf7836cb27ee34c09e6","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        return current_time"},{"line_number":167,"context_line":"    delta \u003d current_time - last_run"},{"line_number":168,"context_line":"    offset \u003d delta % spacing"},{"line_number":169,"context_line":"    rand \u003d random.SystemRandom()"},{"line_number":170,"context_line":"    # Add up to 5% jitter"},{"line_number":171,"context_line":"    jitter \u003d int(spacing * (rand.random() / 20))"},{"line_number":172,"context_line":"    return current_time - offset + jitter"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_1a7c661f","line":169,"in_reply_to":"9a8ffd7b_7fb484d0","updated":"2015-12-01 12:05:39.000000000","message":"Do you propose to skip the related bandit check that fails here?","commit_id":"27b5d0ef43da103058bbf6d183945ced82d4ced7"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"623b17ef2e4c0de4d1188cd41c890729d592e8f8","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        return current_time"},{"line_number":167,"context_line":"    delta \u003d current_time - last_run"},{"line_number":168,"context_line":"    offset \u003d delta % spacing"},{"line_number":169,"context_line":"    rand \u003d random.SystemRandom()"},{"line_number":170,"context_line":"    # Add up to 5% jitter"},{"line_number":171,"context_line":"    jitter \u003d int(spacing * (rand.random() / 20))"},{"line_number":172,"context_line":"    return current_time - offset + jitter"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_e7b8ea77","line":169,"in_reply_to":"9a8ffd7b_cb8ff273","updated":"2015-12-01 13:10:35.000000000","message":"Done","commit_id":"27b5d0ef43da103058bbf6d183945ced82d4ced7"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"55bf376554c8dfd09d4f4ab02a7651bcde8961c0","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        return current_time"},{"line_number":167,"context_line":"    delta \u003d current_time - last_run"},{"line_number":168,"context_line":"    offset \u003d delta % spacing"},{"line_number":169,"context_line":"    rand \u003d random.SystemRandom()"},{"line_number":170,"context_line":"    # Add up to 5% jitter"},{"line_number":171,"context_line":"    jitter \u003d int(spacing * (rand.random() / 20))"},{"line_number":172,"context_line":"    return current_time - offset + jitter"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_cad04bcc","line":169,"in_reply_to":"9a8ffd7b_cb8ff273","updated":"2015-12-01 13:05:17.000000000","message":"Security probably matters in other places, I would prefer to only turn the warn off on this specific line.","commit_id":"27b5d0ef43da103058bbf6d183945ced82d4ced7"}],"oslo_service/service.py":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"509c4d2bbb91149bb89fb82785f8369b99a2e91e","unresolved":false,"context_lines":[{"line_number":379,"context_line":"        eventlet.spawn_n(self._pipe_watcher)"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"        # Reseed random number generator"},{"line_number":382,"context_line":"        random.seed()  # nosec"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"        launcher \u003d Launcher(self.conf)"},{"line_number":385,"context_line":"        launcher.launch_service(service)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_0672bcad","line":382,"updated":"2015-07-13 13:26:34.000000000","message":"Using os.uradom() or random.SystemRandom) avoid the need of random.seed(). Well, it\u0027s just a remark. Reseeding after fork is better than nothing for applications still using random.Random (Mersenne Twister PRNG).\n\nSee also the discussion at: https://review.openstack.org/#/c/191581/","commit_id":"8f3f2c8a39e119196f06f78a533b758e9ace41e0"}],"oslo_service/sslutils.py":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"509c4d2bbb91149bb89fb82785f8369b99a2e91e","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        ssl_kwargs[\u0027ca_certs\u0027] \u003d conf.ssl.ca_file"},{"line_number":66,"context_line":"        ssl_kwargs[\u0027cert_reqs\u0027] \u003d ssl.CERT_REQUIRED"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    return ssl.wrap_socket(sock, **ssl_kwargs)  # nosec"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_0624fcac","line":68,"updated":"2015-07-13 13:26:34.000000000","message":"I would prefer to fix the warning than turning it off. Can we use TLSv1 instead of the default SSLv23 here?\n\nBy the way, Python now provides ssl.create_default_context() which uses stronger security than ssl.wrap_socket().\nhttps://docs.python.org/dev/library/ssl.html#context-creation\n\nIt is available on Python 2.7.9+ and Python 3.4+.","commit_id":"8f3f2c8a39e119196f06f78a533b758e9ace41e0"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"e6a05c71ff0a64a689c20deffcffe27c3cc0ded1","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        ssl_kwargs[\u0027ca_certs\u0027] \u003d conf.ssl.ca_file"},{"line_number":66,"context_line":"        ssl_kwargs[\u0027cert_reqs\u0027] \u003d ssl.CERT_REQUIRED"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    return ssl.wrap_socket(sock, **ssl_kwargs)  # nosec"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_ecb0d7df","line":68,"in_reply_to":"9a41bdd9_0624fcac","updated":"2015-07-13 14:03:30.000000000","message":"We can, but it requires removing TLSv1 from the list of bad ssl protocol versions in bandit.yaml - by default it considers all SSL/TLS versions that ssl module allows to be insecure.","commit_id":"8f3f2c8a39e119196f06f78a533b758e9ace41e0"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"b98595f7187202c5b2edc7520403ba75475f63b4","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        ssl_kwargs[\u0027ca_certs\u0027] \u003d conf.ssl.ca_file"},{"line_number":66,"context_line":"        ssl_kwargs[\u0027cert_reqs\u0027] \u003d ssl.CERT_REQUIRED"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    return ssl.wrap_socket(sock, **ssl_kwargs)  # nosec"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_f4cdf95d","line":68,"in_reply_to":"9a41bdd9_7403290e","updated":"2015-07-13 15:29:05.000000000","message":"As Bandit can work with ssl and OpenSSL, I guess it should allow TLSv1_1 and\nTLSv1_2 [1].\n\nI added those skips because if there will be a bandit job it would fail otherwise. Am I thinking in a wrong way?\n[1] https://github.com/pyca/pyopenssl/blob/master/OpenSSL/SSL.py#L51-L52","commit_id":"8f3f2c8a39e119196f06f78a533b758e9ace41e0"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"06602658f8c4ea8a267a4c68ea0bb3c57a5ac25a","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        ssl_kwargs[\u0027ca_certs\u0027] \u003d conf.ssl.ca_file"},{"line_number":66,"context_line":"        ssl_kwargs[\u0027cert_reqs\u0027] \u003d ssl.CERT_REQUIRED"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    return ssl.wrap_socket(sock, **ssl_kwargs)  # nosec"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a41bdd9_7403290e","line":68,"in_reply_to":"9a41bdd9_ecb0d7df","updated":"2015-07-13 15:16:18.000000000","message":"\u003e We can, but it requires removing TLSv1 from the list of bad ssl protocol versions in bandit.yaml - by default it considers all SSL/TLS versions that ssl module allows to be insecure.\n\nHum, all protocols are insecure? What does bandit expect from us in this case?\n\nMaybe it\u0027s just to ignore the warning here, but can you please at least explain why we skip the warning?","commit_id":"8f3f2c8a39e119196f06f78a533b758e9ace41e0"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"668a8e55fea660263b10b8cd99cb091cd21298c1","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        if conf.ssl.ciphers:"},{"line_number":100,"context_line":"            ssl_kwargs[\u0027ciphers\u0027] \u003d conf.ssl.ciphers"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    return ssl.wrap_socket(sock, **ssl_kwargs)  # nosec"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_9f1128b2","line":102,"updated":"2015-12-01 11:31:22.000000000","message":"Hum, can you elaborate this \"#nosec\"?\n\nI would recommand to use https://docs.python.org/2/library/ssl.html#ssl.SSLContext.wrap_socket instead of ssl.wrap_socket(), but if you do that, it\u0027s better to write a separated change.","commit_id":"27b5d0ef43da103058bbf6d183945ced82d4ced7"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"653fbfcee2b9c1005864c7be89e9907e8ca05e3e","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        if conf.ssl.ciphers:"},{"line_number":100,"context_line":"            ssl_kwargs[\u0027ciphers\u0027] \u003d conf.ssl.ciphers"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    return ssl.wrap_socket(sock, **ssl_kwargs)  # nosec"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_ebbaf609","line":102,"in_reply_to":"9a8ffd7b_5a0e6ee6","updated":"2015-12-01 12:28:44.000000000","message":"This requires a comment, indeed.","commit_id":"27b5d0ef43da103058bbf6d183945ced82d4ced7"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"cf1106fac6044e5cadaabaf7836cb27ee34c09e6","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        if conf.ssl.ciphers:"},{"line_number":100,"context_line":"            ssl_kwargs[\u0027ciphers\u0027] \u003d conf.ssl.ciphers"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    return ssl.wrap_socket(sock, **ssl_kwargs)  # nosec"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_5a0e6ee6","line":102,"in_reply_to":"9a8ffd7b_9f1128b2","updated":"2015-12-01 12:05:39.000000000","message":"For this line bandit complains that SSL/TLS protocol versions are not specified, but in fact a version is being inserted in ssl_kwargs in L94. That is why I think this can be a false positive warning.\n\nAs for using SSLContext.wrap_socket, I agree that it should be done in a separate patch.","commit_id":"27b5d0ef43da103058bbf6d183945ced82d4ced7"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"623b17ef2e4c0de4d1188cd41c890729d592e8f8","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        if conf.ssl.ciphers:"},{"line_number":100,"context_line":"            ssl_kwargs[\u0027ciphers\u0027] \u003d conf.ssl.ciphers"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    return ssl.wrap_socket(sock, **ssl_kwargs)  # nosec"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_6ab91f15","line":102,"in_reply_to":"9a8ffd7b_ebbaf609","updated":"2015-12-01 13:10:35.000000000","message":"Done","commit_id":"27b5d0ef43da103058bbf6d183945ced82d4ced7"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"55bf376554c8dfd09d4f4ab02a7651bcde8961c0","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        if conf.ssl.ciphers:"},{"line_number":100,"context_line":"            ssl_kwargs[\u0027ciphers\u0027] \u003d conf.ssl.ciphers"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    return ssl.wrap_socket(sock, **ssl_kwargs)  # nosec"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_4aaa1b1b","line":102,"in_reply_to":"9a8ffd7b_ebbaf609","updated":"2015-12-01 13:05:17.000000000","message":"Yeah, just complete the comment to explain that the SSL version is set above.","commit_id":"27b5d0ef43da103058bbf6d183945ced82d4ced7"}],"oslo_service/tests/test_periodic.py":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"653fbfcee2b9c1005864c7be89e9907e8ca05e3e","unresolved":false,"context_lines":[{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    @mock.patch(\u0027oslo_service.periodic_task.now\u0027)"},{"line_number":371,"context_line":"    @mock.patch(\u0027random.SystemRandom\u0027)"},{"line_number":372,"context_line":"    def test_nearest_boundary(self, mock_random, mock_now):"},{"line_number":373,"context_line":"        mock_now.return_value \u003d 19"},{"line_number":374,"context_line":"        mock_random.return_value.random.return_value \u003d 0"},{"line_number":375,"context_line":"        self.assertEqual(17, periodic_task._nearest_boundary(10, 7))"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_2b48fe2c","line":372,"updated":"2015-12-01 12:28:44.000000000","message":"Maybe we can just disable the \"random\" checker if we are sure we do not need a critically well-thought random module","commit_id":"27b5d0ef43da103058bbf6d183945ced82d4ced7"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"623b17ef2e4c0de4d1188cd41c890729d592e8f8","unresolved":false,"context_lines":[{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    @mock.patch(\u0027oslo_service.periodic_task.now\u0027)"},{"line_number":371,"context_line":"    @mock.patch(\u0027random.SystemRandom\u0027)"},{"line_number":372,"context_line":"    def test_nearest_boundary(self, mock_random, mock_now):"},{"line_number":373,"context_line":"        mock_now.return_value \u003d 19"},{"line_number":374,"context_line":"        mock_random.return_value.random.return_value \u003d 0"},{"line_number":375,"context_line":"        self.assertEqual(17, periodic_task._nearest_boundary(10, 7))"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_2a3a3799","line":372,"in_reply_to":"9a8ffd7b_2b48fe2c","updated":"2015-12-01 13:10:35.000000000","message":"Done","commit_id":"27b5d0ef43da103058bbf6d183945ced82d4ced7"}],"oslo_service/threadgroup.py":[{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"653fbfcee2b9c1005864c7be89e9907e8ca05e3e","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                continue"},{"line_number":110,"context_line":"            try:"},{"line_number":111,"context_line":"                action_func(x)"},{"line_number":112,"context_line":"            except eventlet.greenlet.GreenletExit:  # nosec"},{"line_number":113,"context_line":"                pass"},{"line_number":114,"context_line":"            except Exception:"},{"line_number":115,"context_line":"                on_error_func(x)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_cbc7f262","line":112,"updated":"2015-12-01 12:28:44.000000000","message":"I\u0027d love an explanation :)","commit_id":"27b5d0ef43da103058bbf6d183945ced82d4ced7"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"623b17ef2e4c0de4d1188cd41c890729d592e8f8","unresolved":false,"context_lines":[{"line_number":109,"context_line":"                continue"},{"line_number":110,"context_line":"            try:"},{"line_number":111,"context_line":"                action_func(x)"},{"line_number":112,"context_line":"            except eventlet.greenlet.GreenletExit:  # nosec"},{"line_number":113,"context_line":"                pass"},{"line_number":114,"context_line":"            except Exception:"},{"line_number":115,"context_line":"                on_error_func(x)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_edad299c","line":112,"in_reply_to":"9a8ffd7b_cbc7f262","updated":"2015-12-01 13:10:35.000000000","message":"Done","commit_id":"27b5d0ef43da103058bbf6d183945ced82d4ced7"}],"oslo_service/wsgi.py":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"668a8e55fea660263b10b8cd99cb091cd21298c1","unresolved":false,"context_lines":[{"line_number":59,"context_line":"class Server(service.ServiceBase):"},{"line_number":60,"context_line":"    \"\"\"Server class to manage a WSGI server, serving a WSGI application.\"\"\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def __init__(self, conf, name, app, host\u003d\u00270.0.0.0\u0027, port\u003d0,  # nosec"},{"line_number":63,"context_line":"                 pool_size\u003dNone, protocol\u003deventlet.wsgi.HttpProtocol,"},{"line_number":64,"context_line":"                 backlog\u003d128, use_ssl\u003dFalse, max_url_len\u003dNone,"},{"line_number":65,"context_line":"                 logger_name\u003d\u0027eventlet.wsgi.server\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_ff1cf4c2","line":62,"updated":"2015-12-01 11:31:22.000000000","message":"Hum, can you please elaborate this #nosec? Is it possible to add an explanation after \"nosec\"? Something like: \"# nosec: ...\".","commit_id":"27b5d0ef43da103058bbf6d183945ced82d4ced7"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"55bf376554c8dfd09d4f4ab02a7651bcde8961c0","unresolved":false,"context_lines":[{"line_number":59,"context_line":"class Server(service.ServiceBase):"},{"line_number":60,"context_line":"    \"\"\"Server class to manage a WSGI server, serving a WSGI application.\"\"\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def __init__(self, conf, name, app, host\u003d\u00270.0.0.0\u0027, port\u003d0,  # nosec"},{"line_number":63,"context_line":"                 pool_size\u003dNone, protocol\u003deventlet.wsgi.HttpProtocol,"},{"line_number":64,"context_line":"                 backlog\u003d128, use_ssl\u003dFalse, max_url_len\u003dNone,"},{"line_number":65,"context_line":"                 logger_name\u003d\u0027eventlet.wsgi.server\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_6d185976","line":62,"in_reply_to":"9a8ffd7b_4b25425a","updated":"2015-12-01 13:05:17.000000000","message":"Ah, the warning is for the IP address 0.0.0.0? Yeah, just explain why you need #nosec and why you don\u0027t want to change the default, in a comment.","commit_id":"27b5d0ef43da103058bbf6d183945ced82d4ced7"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"623b17ef2e4c0de4d1188cd41c890729d592e8f8","unresolved":false,"context_lines":[{"line_number":59,"context_line":"class Server(service.ServiceBase):"},{"line_number":60,"context_line":"    \"\"\"Server class to manage a WSGI server, serving a WSGI application.\"\"\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def __init__(self, conf, name, app, host\u003d\u00270.0.0.0\u0027, port\u003d0,  # nosec"},{"line_number":63,"context_line":"                 pool_size\u003dNone, protocol\u003deventlet.wsgi.HttpProtocol,"},{"line_number":64,"context_line":"                 backlog\u003d128, use_ssl\u003dFalse, max_url_len\u003dNone,"},{"line_number":65,"context_line":"                 logger_name\u003d\u0027eventlet.wsgi.server\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_2da491b7","line":62,"in_reply_to":"9a8ffd7b_abbe2ed2","updated":"2015-12-01 13:10:35.000000000","message":"Done","commit_id":"27b5d0ef43da103058bbf6d183945ced82d4ced7"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"653fbfcee2b9c1005864c7be89e9907e8ca05e3e","unresolved":false,"context_lines":[{"line_number":59,"context_line":"class Server(service.ServiceBase):"},{"line_number":60,"context_line":"    \"\"\"Server class to manage a WSGI server, serving a WSGI application.\"\"\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def __init__(self, conf, name, app, host\u003d\u00270.0.0.0\u0027, port\u003d0,  # nosec"},{"line_number":63,"context_line":"                 pool_size\u003dNone, protocol\u003deventlet.wsgi.HttpProtocol,"},{"line_number":64,"context_line":"                 backlog\u003d128, use_ssl\u003dFalse, max_url_len\u003dNone,"},{"line_number":65,"context_line":"                 logger_name\u003d\u0027eventlet.wsgi.server\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_abbe2ed2","line":62,"in_reply_to":"9a8ffd7b_ff1cf4c2","updated":"2015-12-01 12:28:44.000000000","message":"+1","commit_id":"27b5d0ef43da103058bbf6d183945ced82d4ced7"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"e143261d138f8f82ee5d72af9ce89b024d2e0fe0","unresolved":false,"context_lines":[{"line_number":59,"context_line":"class Server(service.ServiceBase):"},{"line_number":60,"context_line":"    \"\"\"Server class to manage a WSGI server, serving a WSGI application.\"\"\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def __init__(self, conf, name, app, host\u003d\u00270.0.0.0\u0027, port\u003d0,  # nosec"},{"line_number":63,"context_line":"                 pool_size\u003dNone, protocol\u003deventlet.wsgi.HttpProtocol,"},{"line_number":64,"context_line":"                 backlog\u003d128, use_ssl\u003dFalse, max_url_len\u003dNone,"},{"line_number":65,"context_line":"                 logger_name\u003d\u0027eventlet.wsgi.server\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_4b25425a","line":62,"in_reply_to":"9a8ffd7b_ff1cf4c2","updated":"2015-12-01 12:27:22.000000000","message":"Perhaps 127.0.0.1 would be better here, but I\u0027m afraid that changing the default value here may affect some consuming projects. This has to be investigated first. I\u0027ll add an explanation after \"# nosec\"","commit_id":"27b5d0ef43da103058bbf6d183945ced82d4ced7"}]}
