)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"190a719f1a2cbaaaf7a9ea2f043e001a2c849313","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Class Signal Handler is responsible for interacting with"},{"line_number":10,"context_line":"signal module: allow to have several handlers assigned"},{"line_number":11,"context_line":"to distinct signal. Added correct handling SIGINT signal."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I4bc4c98645e9afeb18635576d50a442fb7ce8425"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a50d1a3_5a454f40","line":12,"updated":"2015-07-23 15:04:02.000000000","message":"Please add\nCloses-Bug: #1477102","commit_id":"4bdc61cba320acaf93200c12037196130a23d741"},{"author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"change_message_id":"0feadf02d0cc85280b0b6cd5289d5a10c1401041","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Class Signal Handler is responsible for interacting with"},{"line_number":10,"context_line":"signal module: allow to have several handlers assigned"},{"line_number":11,"context_line":"to distinct signal. Added correct handling SIGINT signal."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I4bc4c98645e9afeb18635576d50a442fb7ce8425"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a50d1a3_b07dd96e","line":12,"in_reply_to":"3a50d1a3_5a454f40","updated":"2015-07-28 16:02:25.000000000","message":"Done","commit_id":"4bdc61cba320acaf93200c12037196130a23d741"}],"oslo_service/service.py":[{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"190a719f1a2cbaaaf7a9ea2f043e001a2c849313","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        super(SignalHandler, self).__init__(*args, **kwargs)"},{"line_number":126,"context_line":"        # Map all signal names to signal integer values and create a"},{"line_number":127,"context_line":"        # reverse mapping (for easier + quick lookup)."},{"line_number":128,"context_line":"        self._ignore_signals \u003d (\u0027SIG_DFL\u0027, \u0027SIG_IGN\u0027)"},{"line_number":129,"context_line":"        self._signals_by_name \u003d dict((name, getattr(signal, name))"},{"line_number":130,"context_line":"                                     for name in dir(signal)"},{"line_number":131,"context_line":"                                     if name.startswith(\"SIG\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_fa077bc7","line":128,"updated":"2015-07-23 15:04:02.000000000","message":"Why not move _ignore_signals, _signals_by_name, signals_to_name and is_sighup_supported at class level? You don\u0027t have to create new objects on each instance init.","commit_id":"4bdc61cba320acaf93200c12037196130a23d741"},{"author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"change_message_id":"0feadf02d0cc85280b0b6cd5289d5a10c1401041","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        super(SignalHandler, self).__init__(*args, **kwargs)"},{"line_number":126,"context_line":"        # Map all signal names to signal integer values and create a"},{"line_number":127,"context_line":"        # reverse mapping (for easier + quick lookup)."},{"line_number":128,"context_line":"        self._ignore_signals \u003d (\u0027SIG_DFL\u0027, \u0027SIG_IGN\u0027)"},{"line_number":129,"context_line":"        self._signals_by_name \u003d dict((name, getattr(signal, name))"},{"line_number":130,"context_line":"                                     for name in dir(signal)"},{"line_number":131,"context_line":"                                     if name.startswith(\"SIG\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_f065a144","line":128,"in_reply_to":"3a50d1a3_fa077bc7","updated":"2015-07-28 16:02:25.000000000","message":"There is no difference. Because of Singleton metaclass method __init__ is called once and all other SignalHandler() calls don\u0027t cause calling SignalHandler::__init__() method","commit_id":"4bdc61cba320acaf93200c12037196130a23d741"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"190a719f1a2cbaaaf7a9ea2f043e001a2c849313","unresolved":false,"context_lines":[{"line_number":330,"context_line":"        # Allow the process to be killed again and die from natural causes"},{"line_number":331,"context_line":"        self.signal_handler.clear()"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"    def _fast_exit(self, signo, frame):"},{"line_number":334,"context_line":"        LOG.info(_LI(\u0027Caught SIGINT signal, instantaneous exiting\u0027))"},{"line_number":335,"context_line":"        os._exit(1)"},{"line_number":336,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_3ac3a339","line":333,"updated":"2015-07-23 15:04:02.000000000","message":"What would happen to children if parent process receives SIGINT? Or if we send SIGINT to child directly?","commit_id":"4bdc61cba320acaf93200c12037196130a23d741"},{"author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"change_message_id":"0feadf02d0cc85280b0b6cd5289d5a10c1401041","unresolved":false,"context_lines":[{"line_number":330,"context_line":"        # Allow the process to be killed again and die from natural causes"},{"line_number":331,"context_line":"        self.signal_handler.clear()"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"    def _fast_exit(self, signo, frame):"},{"line_number":334,"context_line":"        LOG.info(_LI(\u0027Caught SIGINT signal, instantaneous exiting\u0027))"},{"line_number":335,"context_line":"        os._exit(1)"},{"line_number":336,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_0b1ee26f","line":333,"in_reply_to":"3a50d1a3_3ac3a339","updated":"2015-07-28 16:02:25.000000000","message":"I haven\u0027t added SIGINT handler for child process. So if we send SIGINT to child we will get KeyboardInt.\nBut I think SIGINT handler should be added to child too... So I\u0027ll do it in next patch.\n\nAnd if parent receives SIGINT - _fast_exit will be called(this function immediately closes process). And when parent is dead _pipe_watcher will be unblocked in child and sys.exit() will be called in child.","commit_id":"4bdc61cba320acaf93200c12037196130a23d741"}],"requirements.txt":[{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"190a719f1a2cbaaaf7a9ea2f043e001a2c849313","unresolved":false,"context_lines":[{"line_number":8,"context_line":"monotonic\u003e\u003d0.1 # Apache-2.0"},{"line_number":9,"context_line":"oslo.utils\u003e\u003d1.9.0 # Apache-2.0"},{"line_number":10,"context_line":"oslo.config\u003e\u003d1.11.0 # Apache-2.0"},{"line_number":11,"context_line":"oslo.concurrency\u003e\u003d2.1.0 # Apache-2.0"},{"line_number":12,"context_line":"six\u003e\u003d1.9.0"},{"line_number":13,"context_line":"oslo.i18n\u003e\u003d1.5.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":1,"id":"3a50d1a3_7a292be5","line":11,"updated":"2015-07-23 15:04:02.000000000","message":"nit: oslo.concurrency should go before oslo.config :)","commit_id":"4bdc61cba320acaf93200c12037196130a23d741"},{"author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"change_message_id":"0feadf02d0cc85280b0b6cd5289d5a10c1401041","unresolved":false,"context_lines":[{"line_number":8,"context_line":"monotonic\u003e\u003d0.1 # Apache-2.0"},{"line_number":9,"context_line":"oslo.utils\u003e\u003d1.9.0 # Apache-2.0"},{"line_number":10,"context_line":"oslo.config\u003e\u003d1.11.0 # Apache-2.0"},{"line_number":11,"context_line":"oslo.concurrency\u003e\u003d2.1.0 # Apache-2.0"},{"line_number":12,"context_line":"six\u003e\u003d1.9.0"},{"line_number":13,"context_line":"oslo.i18n\u003e\u003d1.5.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":1,"id":"3a50d1a3_062c9797","line":11,"in_reply_to":"3a50d1a3_7a292be5","updated":"2015-07-28 16:02:25.000000000","message":"Done :)","commit_id":"4bdc61cba320acaf93200c12037196130a23d741"}]}
