)]}'
{"oslo_service/threadgroup.py":[{"author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"change_message_id":"ef58bae7f36a7649fcd39d2a3059f9eafdde1597","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            try:"},{"line_number":122,"context_line":"                x.stop()"},{"line_number":123,"context_line":"            except Exception:"},{"line_number":124,"context_line":"                LOG.exception(_LE(\u0027Error stopping timer.\u0027))"},{"line_number":125,"context_line":"            else:"},{"line_number":126,"context_line":"                stopped_timers.append(x)"},{"line_number":127,"context_line":"        for x in stopped_timers:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_7117e1a3","line":124,"updated":"2015-10-27 23:43:59.000000000","message":"Implementation of \n\n    x.stop()\n\nis:\n\ndef stop(self):\n    self._running \u003d False\n\nIt looks too simple to raise exception...\n\nWhy do we need additional logic?\nAre there some cases where we need it in openstack?","commit_id":"3ae36f6eb9380f960815ffca51d01fa8f4cf0263"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"2e55e96e991901f354bb83f36be0787b77e3f6c9","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            try:"},{"line_number":122,"context_line":"                x.stop()"},{"line_number":123,"context_line":"            except Exception:"},{"line_number":124,"context_line":"                LOG.exception(_LE(\u0027Error stopping timer.\u0027))"},{"line_number":125,"context_line":"            else:"},{"line_number":126,"context_line":"                stopped_timers.append(x)"},{"line_number":127,"context_line":"        for x in stopped_timers:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_7470d9dc","line":124,"in_reply_to":"1a26ad4f_7117e1a3","updated":"2015-11-11 00:16:13.000000000","message":"Got me, I just retain the existing stuff, shall I remove? ;)","commit_id":"3ae36f6eb9380f960815ffca51d01fa8f4cf0263"},{"author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"change_message_id":"2567ce366ea58b264a077fc4ddbb043bd5d3892a","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            try:"},{"line_number":122,"context_line":"                x.stop()"},{"line_number":123,"context_line":"            except Exception:"},{"line_number":124,"context_line":"                LOG.exception(_LE(\u0027Error stopping timer.\u0027))"},{"line_number":125,"context_line":"            else:"},{"line_number":126,"context_line":"                stopped_timers.append(x)"},{"line_number":127,"context_line":"        for x in stopped_timers:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_71969d94","line":124,"in_reply_to":"da85f559_7470d9dc","updated":"2015-11-11 08:40:18.000000000","message":"Yes, you are right :)","commit_id":"3ae36f6eb9380f960815ffca51d01fa8f4cf0263"}]}
