)]}'
{"oslo_service/tests/test_wsgi.py":[{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"e914ab5facc92b6ca85ffa2443ec995c335d7ee3","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        server.wait()"},{"line_number":174,"context_line":"        self.assertTrue(server._server.dead)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    @testtools.skipIf(os.name \u003d\u003d \u0027nt\u0027,"},{"line_number":177,"context_line":"                      \u0027UNIX sockets not supported on Windows\u0027)"},{"line_number":178,"context_line":"    @mock.patch(\u0027os.chmod\u0027)"},{"line_number":179,"context_line":"    @mock.patch(\u0027eventlet.listen\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_2f7a0578","line":176,"updated":"2015-11-18 11:44:14.000000000","message":"change to  \"not hasattr(socket, \"AF_UNIX\")\"  ?","commit_id":"2231e339bbf01ac74979e3c992fd6b8f0084c876"}],"oslo_service/wsgi.py":[{"author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"change_message_id":"8fe7bbcec2f582294e219e11098e63ae3305aaa7","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        if backlog \u003c 1:"},{"line_number":104,"context_line":"            raise InvalidInput(reason\u003d_(\u0027The backlog must be more than 0\u0027))"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        if socket_family \u003d\u003d socket.AF_UNIX:"},{"line_number":107,"context_line":"            self.socket \u003d self._get_unix_socket(socket_file, socket_mode,"},{"line_number":108,"context_line":"                                                backlog)"},{"line_number":109,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_acafbc28","line":106,"updated":"2015-11-03 08:43:30.000000000","message":"Windows does not support Unix domain sockets. Cinder will be unhappy :). Additional platform check should be added.","commit_id":"ca8e9158c956337092de6b88b3b9ff93c8f0717e"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"249b430e842efa9717b2405264b3009a19a2471f","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        if backlog \u003c 1:"},{"line_number":104,"context_line":"            raise InvalidInput(reason\u003d_(\u0027The backlog must be more than 0\u0027))"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        if socket_family \u003d\u003d socket.AF_UNIX:"},{"line_number":107,"context_line":"            self.socket \u003d self._get_unix_socket(socket_file, socket_mode,"},{"line_number":108,"context_line":"                                                backlog)"},{"line_number":109,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa80f949_d2fe0405","line":106,"in_reply_to":"1a26ad4f_acafbc28","updated":"2015-11-03 09:35:18.000000000","message":"Thank you, Marian, that\u0027s a good point. I\u0027ll add an additional check.","commit_id":"ca8e9158c956337092de6b88b3b9ff93c8f0717e"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"e914ab5facc92b6ca85ffa2443ec995c335d7ee3","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        (self.host, self.port) \u003d self._socket.getsockname()[0:2]"},{"line_number":130,"context_line":"        LOG.info(_LI(\"%(name)s listening on %(host)s:%(port)s\"),"},{"line_number":131,"context_line":"                 {\u0027name\u0027: self.name, \u0027host\u0027: self.host, \u0027port\u0027: self.port})"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def start(self):"},{"line_number":134,"context_line":"        \"\"\"Start serving a WSGI application."}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_545b5cf6","side":"PARENT","line":131,"updated":"2015-11-18 11:44:14.000000000","message":"Hmm...   I think we need keep the LOG.info.","commit_id":"52edcd4bfbd0e829da4dcaf5371ad4b82ed24e2c"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"e60a247f671caddc274d91a735770a9e90acb378","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        (self.host, self.port) \u003d self._socket.getsockname()[0:2]"},{"line_number":130,"context_line":"        LOG.info(_LI(\"%(name)s listening on %(host)s:%(port)s\"),"},{"line_number":131,"context_line":"                 {\u0027name\u0027: self.name, \u0027host\u0027: self.host, \u0027port\u0027: self.port})"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def start(self):"},{"line_number":134,"context_line":"        \"\"\"Start serving a WSGI application."}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_47cf2d29","side":"PARENT","line":131,"in_reply_to":"ba8a016a_545b5cf6","updated":"2015-11-18 12:50:11.000000000","message":"Sure, will restore","commit_id":"52edcd4bfbd0e829da4dcaf5371ad4b82ed24e2c"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"e914ab5facc92b6ca85ffa2443ec995c335d7ee3","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                 pool_size\u003dNone, protocol\u003deventlet.wsgi.HttpProtocol,"},{"line_number":64,"context_line":"                 backlog\u003d128, use_ssl\u003dFalse, max_url_len\u003dNone,"},{"line_number":65,"context_line":"                 logger_name\u003d\u0027eventlet.wsgi.server\u0027,"},{"line_number":66,"context_line":"                 socket_family\u003dNone, socket_file\u003dNone, socket_mode\u003dNone):"},{"line_number":67,"context_line":"        \"\"\"Initialize, but do not start, a WSGI server."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        :param conf: Instance of ConfigOpts."}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_cf5d7916","line":66,"updated":"2015-11-18 11:44:14.000000000","message":"we can only handle  socket.AF_INET before, if  we add  socket_family , I would like the code path look like:\n\nif socket_family \u003d\u003d socket.AF_INET:\n   do something\nelif socke_family \u003d\u003d socket.AF_UNIX:\n\n   do something\nelse:","commit_id":"2231e339bbf01ac74979e3c992fd6b8f0084c876"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"e60a247f671caddc274d91a735770a9e90acb378","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                 pool_size\u003dNone, protocol\u003deventlet.wsgi.HttpProtocol,"},{"line_number":64,"context_line":"                 backlog\u003d128, use_ssl\u003dFalse, max_url_len\u003dNone,"},{"line_number":65,"context_line":"                 logger_name\u003d\u0027eventlet.wsgi.server\u0027,"},{"line_number":66,"context_line":"                 socket_family\u003dNone, socket_file\u003dNone, socket_mode\u003dNone):"},{"line_number":67,"context_line":"        \"\"\"Initialize, but do not start, a WSGI server."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        :param conf: Instance of ConfigOpts."}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_a767f94b","line":66,"in_reply_to":"ba8a016a_cf5d7916","updated":"2015-11-18 12:50:11.000000000","message":"We should also support AF_INET6 family. I think we can do it the following way:\n\n     if socket_family in [socket.AF_INET, socket.AF_INET6]:\n         do something\n     elif socket_family \u003d\u003d socket.AF_UNIX:\n         do_something_else\n     else:\n         raise InvalidInput(reason\u003d_(\"Unsupported socket family: %s\"), socket_family)","commit_id":"2231e339bbf01ac74979e3c992fd6b8f0084c876"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"e914ab5facc92b6ca85ffa2443ec995c335d7ee3","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            raise InvalidInput(reason\u003d_(\u0027The backlog must be more than 0\u0027))"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        if hasattr(socket, \"AF_UNIX\") and socket_family \u003d\u003d socket.AF_UNIX:"},{"line_number":110,"context_line":"            self.socket \u003d self._get_unix_socket(socket_file, socket_mode,"},{"line_number":111,"context_line":"                                                backlog)"},{"line_number":112,"context_line":"        else:"},{"line_number":113,"context_line":"            self.socket \u003d self._get_socket(host, port, backlog)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_549cbc5c","line":110,"updated":"2015-11-18 11:44:14.000000000","message":"need a LOG.info here ?","commit_id":"2231e339bbf01ac74979e3c992fd6b8f0084c876"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"e60a247f671caddc274d91a735770a9e90acb378","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            raise InvalidInput(reason\u003d_(\u0027The backlog must be more than 0\u0027))"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        if hasattr(socket, \"AF_UNIX\") and socket_family \u003d\u003d socket.AF_UNIX:"},{"line_number":110,"context_line":"            self.socket \u003d self._get_unix_socket(socket_file, socket_mode,"},{"line_number":111,"context_line":"                                                backlog)"},{"line_number":112,"context_line":"        else:"},{"line_number":113,"context_line":"            self.socket \u003d self._get_socket(host, port, backlog)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_d55d0616","line":110,"in_reply_to":"ba8a016a_549cbc5c","updated":"2015-11-18 12:50:11.000000000","message":"Agree, it makes sense to add logging","commit_id":"2231e339bbf01ac74979e3c992fd6b8f0084c876"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"e914ab5facc92b6ca85ffa2443ec995c335d7ee3","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        if hasattr(socket, \"AF_UNIX\") and socket_family \u003d\u003d socket.AF_UNIX:"},{"line_number":110,"context_line":"            self.socket \u003d self._get_unix_socket(socket_file, socket_mode,"},{"line_number":111,"context_line":"                                                backlog)"},{"line_number":112,"context_line":"        else:"},{"line_number":113,"context_line":"            self.socket \u003d self._get_socket(host, port, backlog)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        (self.host, self.port) \u003d self.socket.getsockname()[0:2]"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_948f8429","line":112,"updated":"2015-11-18 11:44:14.000000000","message":"Here if  user pass  socket_family \u003d socket.AF_UNIX ,  what  should we do , raise a exception or  log a warning and fall back the behavior we have before ?","commit_id":"2231e339bbf01ac74979e3c992fd6b8f0084c876"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"e60a247f671caddc274d91a735770a9e90acb378","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        if hasattr(socket, \"AF_UNIX\") and socket_family \u003d\u003d socket.AF_UNIX:"},{"line_number":110,"context_line":"            self.socket \u003d self._get_unix_socket(socket_file, socket_mode,"},{"line_number":111,"context_line":"                                                backlog)"},{"line_number":112,"context_line":"        else:"},{"line_number":113,"context_line":"            self.socket \u003d self._get_socket(host, port, backlog)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        (self.host, self.port) \u003d self.socket.getsockname()[0:2]"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_557116a7","line":112,"in_reply_to":"ba8a016a_948f8429","updated":"2015-11-18 12:50:11.000000000","message":"It wouldn\u0027t be possible for a user to pass socket_family \u003d socket.AF_UNIX if it is not supported by the socket module.","commit_id":"2231e339bbf01ac74979e3c992fd6b8f0084c876"}]}
