)]}'
{"oslo_service/service.py":[{"author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"change_message_id":"381822ed4f128f407b03912a8c2a1bb15815766b","unresolved":false,"context_lines":[{"line_number":674,"context_line":"    if workers and workers \u003c 0:"},{"line_number":675,"context_line":"        raise TypeError(\"Number of workers can not be negative!\")"},{"line_number":676,"context_line":""},{"line_number":677,"context_line":"    if workers is None or workers \u003c\u003d 1:"},{"line_number":678,"context_line":"        launcher \u003d ServiceLauncher(conf)"},{"line_number":679,"context_line":"        launcher.launch_service(service)"},{"line_number":680,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa80f949_20dda814","line":677,"updated":"2015-11-03 15:48:28.000000000","message":"Little bit confusing that two values of workers(0 and 1) give us ServiceLauncher. I would raise an exception if workers \u003c\u003d 0.\nIf workers \u003d\u003d 1:\nrun ServiceLauncher\nelse ProcessLauncher.\nWhat do you think about it?","commit_id":"7372a649ff8c31b2bc38bf2ac80d7b3339c43ed6"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"fd89d80bd8854501f52e769264339aa62f71f32d","unresolved":false,"context_lines":[{"line_number":674,"context_line":"    if workers and workers \u003c 0:"},{"line_number":675,"context_line":"        raise TypeError(\"Number of workers can not be negative!\")"},{"line_number":676,"context_line":""},{"line_number":677,"context_line":"    if workers is None or workers \u003c\u003d 1:"},{"line_number":678,"context_line":"        launcher \u003d ServiceLauncher(conf)"},{"line_number":679,"context_line":"        launcher.launch_service(service)"},{"line_number":680,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa80f949_a6671724","line":677,"in_reply_to":"fa80f949_20dda814","updated":"2015-11-05 14:30:05.000000000","message":"Okay, let\u0027s make workers a positive number","commit_id":"7372a649ff8c31b2bc38bf2ac80d7b3339c43ed6"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"893ad0a2b1f39b9d9ad644d48010f65d58011d09","unresolved":false,"context_lines":[{"line_number":672,"context_line":"    \"\"\""},{"line_number":673,"context_line":""},{"line_number":674,"context_line":"    if workers is not None and workers \u003c\u003d 0:"},{"line_number":675,"context_line":"        raise TypeError(\"Number of workers should be positive!\")"},{"line_number":676,"context_line":""},{"line_number":677,"context_line":"    if workers is None or workers \u003d\u003d 1:"},{"line_number":678,"context_line":"        launcher \u003d ServiceLauncher(conf)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_9734ec4a","line":675,"updated":"2015-11-06 22:12:34.000000000","message":"So my only complaint is the type error here.\n\nhttps://docs.python.org/2/library/exceptions.html#exceptions.TypeError\n\nIt seems like a value error should be used instead, because the type really isn\u0027t wrong, but the value is.\n\nhttps://docs.python.org/2/library/exceptions.html#exceptions.ValueError\n\n\u0027\u0027\u0027\nRaised when a built-in operation or function receives an argument that has the right type but an inappropriate value, and the situation is not described by a more precise exception such as IndexError.\n\u0027\u0027\u0027\n\n^ Sounds more appropriate to me.","commit_id":"844ddf9d012261a4c0736cb9f6e6b6a938f3927b"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"e0aaa9ef3d1f5e2e6f83ce2306f15518dcd2c60d","unresolved":false,"context_lines":[{"line_number":672,"context_line":"    \"\"\""},{"line_number":673,"context_line":""},{"line_number":674,"context_line":"    if workers is not None and workers \u003c\u003d 0:"},{"line_number":675,"context_line":"        raise TypeError(\"Number of workers should be positive!\")"},{"line_number":676,"context_line":""},{"line_number":677,"context_line":"    if workers is None or workers \u003d\u003d 1:"},{"line_number":678,"context_line":"        launcher \u003d ServiceLauncher(conf)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_30cf1481","line":675,"in_reply_to":"da85f559_9734ec4a","updated":"2015-11-09 14:50:13.000000000","message":"Thanks for suggestion, done","commit_id":"844ddf9d012261a4c0736cb9f6e6b6a938f3927b"}]}