)]}'
{"oslo_service/tests/test_service.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"a669193bd88ee93b09ad765ba816d1ffd369a564","unresolved":false,"context_lines":[{"line_number":508,"context_line":"    def run_server(self, workers\u003d3):"},{"line_number":509,"context_line":"        queue \u003d multiprocessing.Queue()"},{"line_number":510,"context_line":"        proc \u003d multiprocessing.Process(target\u003deventlet_service.run,"},{"line_number":511,"context_line":"                                       args\u003d(queue,),"},{"line_number":512,"context_line":"                                       kwargs\u003d{\u0027workers\u0027: workers})"},{"line_number":513,"context_line":"        proc.start()"},{"line_number":514,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a7b0d38_002edda4","line":511,"updated":"2015-12-28 16:43:46.000000000","message":"Why do you move queue from kwargs here?","commit_id":"e7846ee8d0d99066c336a5c719bdbd11560c4dd7"},{"author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"change_message_id":"edb2132ca2d51c8e4c75205dde0c46f50863d122","unresolved":false,"context_lines":[{"line_number":508,"context_line":"    def run_server(self, workers\u003d3):"},{"line_number":509,"context_line":"        queue \u003d multiprocessing.Queue()"},{"line_number":510,"context_line":"        proc \u003d multiprocessing.Process(target\u003deventlet_service.run,"},{"line_number":511,"context_line":"                                       args\u003d(queue,),"},{"line_number":512,"context_line":"                                       kwargs\u003d{\u0027workers\u0027: workers})"},{"line_number":513,"context_line":"        proc.start()"},{"line_number":514,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a7b0d38_4218681e","line":511,"in_reply_to":"1a7b0d38_002edda4","updated":"2015-12-28 18:07:08.000000000","message":"queue is not optional argument. If you try to run eventlet_service.run without queue argument it will crash. That\u0027s why I moved queue from kwargs to args.","commit_id":"e7846ee8d0d99066c336a5c719bdbd11560c4dd7"}]}
