)]}'
{"oslo_service/wsgi.py":[{"author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"change_message_id":"9cc859eded2045813e107cac8cbf28c407978855","unresolved":false,"context_lines":[{"line_number":236,"context_line":"        \"\"\""},{"line_number":237,"context_line":"        try:"},{"line_number":238,"context_line":"            if self._server is not None:"},{"line_number":239,"context_line":"                self._server.wait()"},{"line_number":240,"context_line":"        except greenlet.GreenletExit:"},{"line_number":241,"context_line":"            LOG.info(_LI(\"WSGI server has stopped.\"))"},{"line_number":242,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_bbceb558","line":239,"range":{"start_line":239,"start_character":29,"end_line":239,"end_character":33},"updated":"2015-12-30 08:39:40.000000000","message":"Calling wait() after kill() causes exception: http://eventlet.net/doc/modules/greenthread.html#eventlet.greenthread.GreenThread.kill","commit_id":"c892f374a31210dbb9d2643dba6311bb5e7b9e52"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"6fe75e60ee204a8d2ee6db769605e10c5dacdbb1","unresolved":false,"context_lines":[{"line_number":236,"context_line":"        \"\"\""},{"line_number":237,"context_line":"        try:"},{"line_number":238,"context_line":"            if self._server is not None:"},{"line_number":239,"context_line":"                self._server.wait()"},{"line_number":240,"context_line":"        except greenlet.GreenletExit:"},{"line_number":241,"context_line":"            LOG.info(_LI(\"WSGI server has stopped.\"))"},{"line_number":242,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_4ce57da6","line":239,"range":{"start_line":239,"start_character":29,"end_line":239,"end_character":33},"in_reply_to":"fa69d971_bbceb558","updated":"2015-12-30 09:50:18.000000000","message":"Isn\u0027t that what we expect in L240?\n\nWait() method that we have now seems to be supposed to be called after stop(). But meanwhile all other entities (like ServiceLauncher and ProcessLauncher) are built in the way that wait() is called right after start and the majority (if not all?) of consuming services also use start() wait() sequence. So, here we result in calling pool.waitall() on an empty pool which causes service to exit before an eventlet server gets actually started.\n\nI guess it can only be reproduced when ServiceLauncher is used, because ProcessLauncher doesn\u0027t invoke service\u0027s wait method and just waits for children to exit.","commit_id":"c892f374a31210dbb9d2643dba6311bb5e7b9e52"}]}
