)]}'
{"oslo_service/service.py":[{"author":{"_account_id":6608,"name":"Paul Carlton","email":"paul.carlton2@hpe.com","username":"paul-carlton2"},"change_message_id":"bb9230c460046087351ef599dd215b10be905c99","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        # Avoid checking if we are a daemon, because the signal isn\u0027t"},{"line_number":79,"context_line":"        # SIGHUP."},{"line_number":80,"context_line":"        return False"},{"line_number":81,"context_line":"    x \u003d _is_daemon()"},{"line_number":82,"context_line":"    return x"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_636d3698","line":81,"updated":"2016-06-06 12:58:04.000000000","message":"nit: is this a hangover from debugging?","commit_id":"f8b15e4786f9c6f71f88b9d77525e7725cc80881"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"d5c032a038b4c153d5c85e87bae72d2ae434e391","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        # Avoid checking if we are a daemon, because the signal isn\u0027t"},{"line_number":79,"context_line":"        # SIGHUP."},{"line_number":80,"context_line":"        return False"},{"line_number":81,"context_line":"    x \u003d _is_daemon()"},{"line_number":82,"context_line":"    return x"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_fa48a72f","line":81,"in_reply_to":"7aa08908_636d3698","updated":"2016-06-06 14:00:57.000000000","message":"Oops yes, thank you, fixed","commit_id":"f8b15e4786f9c6f71f88b9d77525e7725cc80881"}],"oslo_service/tests/test_service.py":[{"author":{"_account_id":9459,"name":".Haifeng Yan","email":"yanheven@qq.com","username":"yan"},"change_message_id":"79a87471d0f2d625b0b59df8d89582499f0da890","unresolved":false,"context_lines":[{"line_number":546,"context_line":"        pipe_mock.return_value \u003d [None, None]"},{"line_number":547,"context_line":"        launcher \u003d service.ProcessLauncher(self.conf)"},{"line_number":548,"context_line":"        serv \u003d _Service()"},{"line_number":549,"context_line":"        launcher.launch_service(serv, workers\u003d0)"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"        def stager():"},{"line_number":552,"context_line":"            # -1: start state"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_0e8fe775","line":549,"range":{"start_line":549,"start_character":46,"end_line":549,"end_character":47},"updated":"2016-07-20 08:32:13.000000000","message":"the same question as Paul,\nshould workers \u003e 1?","commit_id":"8a9a3927b4f705b817a6644752b3b3236e975739"},{"author":{"_account_id":9459,"name":".Haifeng Yan","email":"yanheven@qq.com","username":"yan"},"change_message_id":"43290e69e186d666a39a8a212a263e1aca5191a8","unresolved":false,"context_lines":[{"line_number":546,"context_line":"        pipe_mock.return_value \u003d [None, None]"},{"line_number":547,"context_line":"        launcher \u003d service.ProcessLauncher(self.conf)"},{"line_number":548,"context_line":"        serv \u003d _Service()"},{"line_number":549,"context_line":"        launcher.launch_service(serv, workers\u003d0)"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"        def stager():"},{"line_number":552,"context_line":"            # -1: start state"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_6eeae3ad","line":549,"range":{"start_line":549,"start_character":46,"end_line":549,"end_character":47},"in_reply_to":"dada55a8_0e8fe775","updated":"2016-07-20 08:38:47.000000000","message":"workers \u003e 0","commit_id":"8a9a3927b4f705b817a6644752b3b3236e975739"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"2e0041a841b24990436c881060e39fffc5de4cdc","unresolved":false,"context_lines":[{"line_number":546,"context_line":"        pipe_mock.return_value \u003d [None, None]"},{"line_number":547,"context_line":"        launcher \u003d service.ProcessLauncher(self.conf)"},{"line_number":548,"context_line":"        serv \u003d _Service()"},{"line_number":549,"context_line":"        launcher.launch_service(serv, workers\u003d0)"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"        def stager():"},{"line_number":552,"context_line":"            # -1: start state"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_837b78f4","line":549,"range":{"start_line":549,"start_character":46,"end_line":549,"end_character":47},"in_reply_to":"dada55a8_6eeae3ad","updated":"2016-08-05 14:13:14.000000000","message":"Sorry I left this so long, I\u0027ve been looking at other stuff. This is set to 0 intentionally so we don\u0027t really start any children. You can see I\u0027ve also mocked _start_child.\n\nThis unit test is primarily about the signal handlers and their interaction/sequencing through the #wait method. Having real child processes would add a lot of faff without telling us anything extra about the signal handling.","commit_id":"8a9a3927b4f705b817a6644752b3b3236e975739"},{"author":{"_account_id":9459,"name":".Haifeng Yan","email":"yanheven@qq.com","username":"yan"},"change_message_id":"6fe14d1bdf472daf2641f80ff1d118c988446393","unresolved":false,"context_lines":[{"line_number":562,"context_line":"            else:"},{"line_number":563,"context_line":"                self.fail(\"TERM did not kill launcher\")"},{"line_number":564,"context_line":"        stager.stage \u003d -1"},{"line_number":565,"context_line":"        handle_signal_mock.side_effect \u003d stager"},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"        launcher.wait()"},{"line_number":568,"context_line":"        self.assertEqual(3, stager.stage)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_a7016107","line":565,"range":{"start_line":565,"start_character":8,"end_line":565,"end_character":47},"updated":"2016-08-05 15:47:46.000000000","message":"should launcher \u003d service.ProcessLauncher(self.conf) be after handle_signal_mock.side_effect \u003d stager ? as handle_signal will be called  when initiate ProcessLauncher.","commit_id":"114041b18e878a7057af6a0d4bf8d0e84c001fad"},{"author":{"_account_id":9459,"name":".Haifeng Yan","email":"yanheven@qq.com","username":"yan"},"change_message_id":"7b4275edd0e3db276380067c7d30a2c1e94431e0","unresolved":false,"context_lines":[{"line_number":562,"context_line":"            else:"},{"line_number":563,"context_line":"                self.fail(\"TERM did not kill launcher\")"},{"line_number":564,"context_line":"        stager.stage \u003d -1"},{"line_number":565,"context_line":"        handle_signal_mock.side_effect \u003d stager"},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"        launcher.wait()"},{"line_number":568,"context_line":"        self.assertEqual(3, stager.stage)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_9f17f9ec","line":565,"range":{"start_line":565,"start_character":8,"end_line":565,"end_character":47},"in_reply_to":"9ad45d7e_39442d73","updated":"2016-08-08 14:15:06.000000000","message":"it\u0027s ok. just personal preference.","commit_id":"114041b18e878a7057af6a0d4bf8d0e84c001fad"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"76e93ad461015bf8bad9f6d0e52b9a3c3e077d3f","unresolved":false,"context_lines":[{"line_number":562,"context_line":"            else:"},{"line_number":563,"context_line":"                self.fail(\"TERM did not kill launcher\")"},{"line_number":564,"context_line":"        stager.stage \u003d -1"},{"line_number":565,"context_line":"        handle_signal_mock.side_effect \u003d stager"},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"        launcher.wait()"},{"line_number":568,"context_line":"        self.assertEqual(3, stager.stage)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_39442d73","line":565,"range":{"start_line":565,"start_character":8,"end_line":565,"end_character":47},"in_reply_to":"bacf61ea_a7016107","updated":"2016-08-08 13:42:34.000000000","message":"It doesn\u0027t matter, although if we did move it I\u0027d have to adjust the numbers in stager to account for the extra call. Why, do you think this is a problem somehow?","commit_id":"114041b18e878a7057af6a0d4bf8d0e84c001fad"}]}
