)]}'
{"oslo_service/loopingcall.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"61d60d7e635558441a11500662b9782b8304e564","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    @property"},{"line_number":101,"context_line":"    def _running(self):"},{"line_number":102,"context_line":"        if self._IS_MONKEY_PATCHED:"},{"line_number":103,"context_line":"            return not self.abort.is_set()"},{"line_number":104,"context_line":"        else:"},{"line_number":105,"context_line":"            return self.__running"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf659307_cfe3afd7","line":102,"updated":"2018-04-11 15:16:39.000000000","message":"Instead of having to remember to check this variable at every place where it makes a difference, can we define some classes to hold the \"strategy\" that is reflected by the difference and then just use the right sort of instance of those classes? That would make it easier to test both cases, since we could test the classes separately. It would also make it easier to understand all of the differences between the patched and unpatched modes.","commit_id":"ce8edbad32f84fc207de1f50e398caafb11faa12"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"9021f6f47b5d9e492a9e82741347747987516c1f","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    @property"},{"line_number":101,"context_line":"    def _running(self):"},{"line_number":102,"context_line":"        if self._IS_MONKEY_PATCHED:"},{"line_number":103,"context_line":"            return not self.abort.is_set()"},{"line_number":104,"context_line":"        else:"},{"line_number":105,"context_line":"            return self.__running"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf659307_eed42e22","line":102,"in_reply_to":"bf659307_cfe3afd7","updated":"2018-04-13 17:55:49.000000000","message":"Done","commit_id":"ce8edbad32f84fc207de1f50e398caafb11faa12"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"9bb2135c360956dc36eff9b180c3c47fc355e195","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        return _GreenEvent()"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"class _ThreadingEvent(object):"},{"line_number":88,"context_line":"    def __init__(self):"},{"line_number":89,"context_line":"        self._abort \u003d threading.Event()"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"bf659307_6e26ded0","line":87,"updated":"2018-04-13 18:26:08.000000000","message":"It would be good to have a common base class for these to make it clear they are expected to have the same API. But we can do that in a follow-up.","commit_id":"9091986228de7bc87d3e70565c9ab0c53b0b8af1"}]}
