)]}'
{"oslo_service/service.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"a1c8a82c97f6b49941db199f9c3a8e6201acffa5","unresolved":false,"context_lines":[{"line_number":520,"context_line":"            status \u003d exc.code"},{"line_number":521,"context_line":"            signo \u003d exc.signo"},{"line_number":522,"context_line":"        except SystemExit as exc:"},{"line_number":523,"context_line":"            launcher.stop()"},{"line_number":524,"context_line":"            status \u003d exc.code"},{"line_number":525,"context_line":"        except BaseException:"},{"line_number":526,"context_line":"            LOG.exception(\u0027Unhandled exception\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_0bf1e495","line":523,"updated":"2018-06-19 07:07:45.000000000","message":"Not sure that the good place to call stop().\n\nBecause is certain case when this method exits, we call restart() that already call stop().","commit_id":"96d14d8b4ef85ae6a59569ed307c91e57fd57e8f"},{"author":{"_account_id":17144,"name":"jun923.gu","email":"gujun1989@126.com","username":"jun923.gu"},"change_message_id":"40bb8638d7fabc7ac3e4c254943961a5c26e3d2b","unresolved":false,"context_lines":[{"line_number":520,"context_line":"            status \u003d exc.code"},{"line_number":521,"context_line":"            signo \u003d exc.signo"},{"line_number":522,"context_line":"        except SystemExit as exc:"},{"line_number":523,"context_line":"            launcher.stop()"},{"line_number":524,"context_line":"            status \u003d exc.code"},{"line_number":525,"context_line":"        except BaseException:"},{"line_number":526,"context_line":"            LOG.exception(\u0027Unhandled exception\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_4b5a7bf2","line":523,"in_reply_to":"5f7c97a3_0bf1e495","updated":"2018-06-19 08:05:22.000000000","message":"Yes, But I found that ServiceLauncher also call restart().","commit_id":"96d14d8b4ef85ae6a59569ed307c91e57fd57e8f"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"a1c8a82c97f6b49941db199f9c3a8e6201acffa5","unresolved":false,"context_lines":[{"line_number":522,"context_line":"        except SystemExit as exc:"},{"line_number":523,"context_line":"            launcher.stop()"},{"line_number":524,"context_line":"            status \u003d exc.code"},{"line_number":525,"context_line":"        except BaseException:"},{"line_number":526,"context_line":"            LOG.exception(\u0027Unhandled exception\u0027)"},{"line_number":527,"context_line":"            status \u003d 2"},{"line_number":528,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_0bfb2447","line":525,"updated":"2018-06-19 07:07:45.000000000","message":"You should call stop here too, then ? Like the ServiceLauncher ?","commit_id":"96d14d8b4ef85ae6a59569ed307c91e57fd57e8f"},{"author":{"_account_id":17144,"name":"jun923.gu","email":"gujun1989@126.com","username":"jun923.gu"},"change_message_id":"40bb8638d7fabc7ac3e4c254943961a5c26e3d2b","unresolved":false,"context_lines":[{"line_number":522,"context_line":"        except SystemExit as exc:"},{"line_number":523,"context_line":"            launcher.stop()"},{"line_number":524,"context_line":"            status \u003d exc.code"},{"line_number":525,"context_line":"        except BaseException:"},{"line_number":526,"context_line":"            LOG.exception(\u0027Unhandled exception\u0027)"},{"line_number":527,"context_line":"            status \u003d 2"},{"line_number":528,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_eb3827d5","line":525,"in_reply_to":"5f7c97a3_0bfb2447","updated":"2018-06-19 08:05:22.000000000","message":"Yes, If like the ServiceLauncher, the stop also should be called here.","commit_id":"96d14d8b4ef85ae6a59569ed307c91e57fd57e8f"}]}