)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"9fa57dc5599f97fb196772c7eecb18cc68544297","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fixing race condition and fix discrepency when reusing Events"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Is there a race condition on the wait method, a greenthread A is blocked"},{"line_number":10,"context_line":"on the wait, but another greenthread B calls clear() and"},{"line_number":11,"context_line":"then set(), B calls self._event.send(), but A is waiting on a different"},{"line_number":12,"context_line":"eventlet Event which is no longer used by the oslo.service Event..."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Also the threading.Event object allows calling set() multiple times, but"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_ffb188e4","line":11,"range":{"start_line":10,"start_character":25,"end_line":11,"end_character":10},"updated":"2018-11-21 19:48:56.000000000","message":"This can\u0027t happen, though, because clear() is only called in one place, and an exception will be raised on the line before if greenthread A is still running.","commit_id":"94697c462d1df1e8fa85fd2197637ad1a715abfb"}],"oslo_service/loopingcall.py":[{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"739778d79cf94d8badacbc0043dc447c189573fd","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        self._event.send(True)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def wait(self, timeout\u003dNone):"},{"line_number":105,"context_line":"        with timeutils.StopWatch(timeout) as timer:"},{"line_number":106,"context_line":"            while True:"},{"line_number":107,"context_line":"                event \u003d self._event"},{"line_number":108,"context_line":"                with eventlettimeout.Timeout(timer.leftover(), False):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_e28e087a","line":105,"updated":"2018-12-04 01:55:40.000000000","message":"The test error is because using the StopWatch means extra calls to time.now() which aren\u0027t expected by the mocking code.","commit_id":"0a27e04947b5eae45f6c2a97045653f5853a4ff6"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"8035a708ed8217b823e064f6837d73cb52f8376c","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        with timeutils.StopWatch(timeout) as timer:"},{"line_number":106,"context_line":"            while True:"},{"line_number":107,"context_line":"                event \u003d self._event"},{"line_number":108,"context_line":"                with eventlettimeout.Timeout(timer.leftover(), False):"},{"line_number":109,"context_line":"                    event.wait()"},{"line_number":110,"context_line":"                if event is not self._event:"},{"line_number":111,"context_line":"                    continue"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f769fc5_068811e5","line":108,"range":{"start_line":108,"start_character":59,"end_line":108,"end_character":61},"updated":"2019-01-01 21:41:05.000000000","message":"Should pass return_none\u003dTrue here to avoid errors when timeout\u003dNone, although I assume in practice we\u0027ll always have a timeout here.","commit_id":"c589ffa8fd74cab4f259829414334a1831e8578d"}]}
