)]}'
{"oslo_service/threadgroup.py":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"4499a75db567684f87456c78c76620ec7512b8cd","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        \"\"\"Schedule a function to be run upon completion of the thread.\"\"\""},{"line_number":64,"context_line":"        self.thread.link(func, *args, **kwargs)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def cancel(self, *throw_args):"},{"line_number":67,"context_line":"        \"\"\"Cancel the thread by raising the given exception within it."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        :param throw_args: the exc_info data to throw into the thread."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_b3e3d9ca","line":66,"range":{"start_line":66,"start_character":22,"end_line":66,"end_character":27},"updated":"2018-12-11 22:39:24.000000000","message":"What is this, Java? :-P","commit_id":"a4312c5df395477dc6731577ca63b7b69256db04"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"f8519bc9fd343732a19ba8d91c8e9706ed987d0b","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        \"\"\"Schedule a function to be run upon completion of the thread.\"\"\""},{"line_number":64,"context_line":"        self.thread.link(func, *args, **kwargs)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def cancel(self, *throw_args):"},{"line_number":67,"context_line":"        \"\"\"Cancel the thread by raising the given exception within it."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        :param throw_args: the exc_info data to throw into the thread."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_b022d352","line":66,"range":{"start_line":66,"start_character":22,"end_line":66,"end_character":27},"in_reply_to":"3f79a3b5_a9492531","updated":"2018-12-12 16:59:04.000000000","message":"TIL :-)","commit_id":"a4312c5df395477dc6731577ca63b7b69256db04"},{"author":{"_account_id":4257,"name":"Zane Bitter","email":"zbitter@redhat.com","username":"zaneb"},"change_message_id":"f9b685f9632c83d143832f53e8b4aff8ab8aa662","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        \"\"\"Schedule a function to be run upon completion of the thread.\"\"\""},{"line_number":64,"context_line":"        self.thread.link(func, *args, **kwargs)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def cancel(self, *throw_args):"},{"line_number":67,"context_line":"        \"\"\"Cancel the thread by raising the given exception within it."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        :param throw_args: the exc_info data to throw into the thread."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_a9492531","line":66,"range":{"start_line":66,"start_character":22,"end_line":66,"end_character":27},"in_reply_to":"3f79a3b5_b3e3d9ca","updated":"2018-12-12 02:13:31.000000000","message":"Python also uses the word \u0027throw\u0027 to refer to throwing an exception into a co-routine from the outside (as opposed to raising it in the ordinary flow of control). To quote PEP288:\n\n  The name of the throw method was selected for several reasons. Raise\n  is a keyword and so cannot be used as a method name. Unlike raise\n  which immediately raises an exception from the current execution\n  point, throw will first return to the generator and then raise the\n  exception. The word throw is suggestive of putting the exception in\n  another location. The word throw is already associated with exceptions\n  in other languages.\n\nhttps://www.python.org/dev/peps/pep-0288/#specification-for-generator-exception-passing\n\nSo it\u0027s not entirely surprising that eventlet chose to use that terminology here, which we mirrored: http://eventlet.net/doc/modules/greenthread.html#eventlet.greenthread.GreenThread.cancel\n\n:-P","commit_id":"a4312c5df395477dc6731577ca63b7b69256db04"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"4499a75db567684f87456c78c76620ec7512b8cd","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        self.timers.append(timer)"},{"line_number":160,"context_line":"        return timer"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def add_timer(self, interval, callback, initial_delay\u003dNone,"},{"line_number":163,"context_line":"                  *args, **kwargs):"},{"line_number":164,"context_line":"        \"\"\"Add a timer with a fixed period."},{"line_number":165,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_284c3373","line":162,"range":{"start_line":162,"start_character":24,"end_line":162,"end_character":32},"updated":"2018-12-11 22:39:24.000000000","message":"Nit: missing interval","commit_id":"a4312c5df395477dc6731577ca63b7b69256db04"}]}
